From: Harish Patil <harish.patil@qlogic.com>
To: Thomas Monjalon <thomas.monjalon@6wind.com>
Cc: "dev@dpdk.org" <dev@dpdk.org>, Sony Chacko <sony.chacko@qlogic.com>
Subject: Re: [dpdk-dev] [PATCH 3/5] bnx2x: Add RTE_LIBRTE_BNX2X_REG_ACCESS config option
Date: Sun, 8 Nov 2015 16:14:57 +0000 [thread overview]
Message-ID: <D264B41B.EF37A%harish.patil@qlogic.com> (raw)
In-Reply-To: <5600189.IfZWYQEBpk@xps13>
>> >Either other "debug" logs can be put as INFO level, or
>> >you need a level 9 for verbose debug.
>> >But I don't really understand what is the problem of a verbose debug.
>> >
>> >It is not critical for the acceptance of this patch. Just wanted to
>> >discuss
>> >it as we have many config options to tune the debug.
>> >
>> >Please, at least, use the DEBUG word in the option name as done for
>> >CONFIG_RTE_LIBRTE_BNX2X_DEBUG_RX.
>> >
>>
>> Currently PMD_DRV_LOG(DEBUG,..) is used all over the places and
>>converting
>> that into INFO/NOTICE levels results in lot of changes.
>
>Having a lot of changes to do is not a good argument.
>But that's an argument to reduce the size of the bnx2x driver.
Okay, we need to look into that if there is a way.
>And more generally, this driver would deserve some big changes.
>
>> Even if we convert other debug logs as INFO level logs, since level 8 is
>> the default debug level, the user would have to edit config file to
>> prevent flooding of the messages on the console.
>
>The user *should* change the log evel in most cases.
>Or we could raise the default level to INFO.
>And users of packaged DPDK may already have a different configuration
>from the distribution.
Yes, I think we should default it to INFO.
>
>> So I guess adding a debug
>> option without needing additional level would suffice for now. I shall
>> rename it as CONFIG_RTE_LIBRTE_BNX2X_DEBUG_PERIODIC and include all
>> periodic events like statistics, register R/Ws etc under this debug.
>
>Yes it could work.
>But it would be nice to have a consistent log management across drivers.
>
Okay, I will re-submit the patch with this change, thanks for the feedback.
________________________________
This message and any attached documents contain information from the sending company or its parent company(s), subsidiaries, divisions or branch offices that may be confidential. If you are not the intended recipient, you may not read, copy, distribute, or use this information. If you have received this transmission in error, please notify the sender immediately by reply e-mail and then delete this message.
next prev parent reply other threads:[~2015-11-08 16:15 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-09-12 0:42 [dpdk-dev] [PATCH 0/5] bnx2x: Enhancement, fixes, licensing and doumentation Rasesh Mody
2015-09-12 0:42 ` [dpdk-dev] [PATCH 1/5] bnx2x: SR-IOV VF driver changes to support OOB PF driver Rasesh Mody
2015-10-20 16:10 ` Thomas Monjalon
2015-10-21 15:24 ` Harish Patil
2015-10-21 15:34 ` Thomas Monjalon
2015-10-21 15:42 ` Harish Patil
2015-09-12 0:42 ` [dpdk-dev] [PATCH 2/5] bnx2x: Fix x86_64-native-linuxapp-clang build error Rasesh Mody
2015-10-20 16:11 ` Thomas Monjalon
2015-10-23 16:36 ` Harish Patil
2015-10-23 16:42 ` Thomas Monjalon
2015-09-12 0:42 ` [dpdk-dev] [PATCH 3/5] bnx2x: Add RTE_LIBRTE_BNX2X_REG_ACCESS config option Rasesh Mody
2015-10-20 16:18 ` Thomas Monjalon
2015-10-23 22:28 ` Harish Patil
2015-10-24 13:09 ` Thomas Monjalon
2015-11-07 3:08 ` Harish Patil
[not found] ` <5600189.IfZWYQEBpk@xps13>
2015-11-08 16:14 ` Harish Patil [this message]
2015-09-12 0:42 ` [dpdk-dev] [PATCH 4/5] doc: Add BNX2X PMD documentation Rasesh Mody
2015-09-12 0:42 ` [dpdk-dev] [PATCH 5/5] bnx2x: Add LICENSE.bnx2x_pmd and update source files Rasesh Mody
2015-09-12 1:17 ` [dpdk-dev] [PATCH 0/5] bnx2x: Enhancement, fixes, licensing and doumentation Stephen Hemminger
2015-09-12 2:27 ` Harish Patil
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=D264B41B.EF37A%harish.patil@qlogic.com \
--to=harish.patil@qlogic.com \
--cc=dev@dpdk.org \
--cc=sony.chacko@qlogic.com \
--cc=thomas.monjalon@6wind.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).