From: Harish Patil <harish.patil@qlogic.com>
To: Stephen Hemminger <stephen@networkplumber.org>
Cc: "dev@dpdk.org" <dev@dpdk.org>
Subject: Re: [dpdk-dev] [PATCH] bnx2x: tx_start_bd->vlan_or_ethertype is le16
Date: Tue, 1 Dec 2015 22:47:29 +0000 [thread overview]
Message-ID: <D28361A1.1047AA%harish.patil@qlogic.com> (raw)
In-Reply-To: <20151201143754.06675ca9@xeon-e3>
>
>On Tue, 1 Dec 2015 21:53:59 +0000
>Harish Patil <harish.patil@qlogic.com> wrote:
>
>> >
>> >Anyone to review please?
>> >
>> >2015-11-03 12:26, Chas Williams:
>> >> Signed-off-by: Chas Williams <3chas3@gmail.com>
>> >> ---
>> >> drivers/net/bnx2x/bnx2x.c | 3 ++-
>> >> 1 file changed, 2 insertions(+), 1 deletion(-)
>> >>
>> >> diff --git a/drivers/net/bnx2x/bnx2x.c b/drivers/net/bnx2x/bnx2x.c
>> >> index fed7a06..76444eb 100644
>> >> --- a/drivers/net/bnx2x/bnx2x.c
>> >> +++ b/drivers/net/bnx2x/bnx2x.c
>> >> @@ -2169,7 +2169,8 @@ int bnx2x_tx_encap(struct bnx2x_tx_queue *txq,
>> >>struct rte_mbuf **m_head, int m_p
>> >> struct ether_hdr *eh
>> >> = rte_pktmbuf_mtod(m0, struct
>>ether_hdr *);
>> >>
>> >> - tx_start_bd->vlan_or_ethertype =
>>eh->ether_type;
>> >> + tx_start_bd->vlan_or_ethertype
>> >> + =
>>rte_cpu_to_le_16(rte_be_to_cpu_16(eh->ether_type));
>> >> }
>> >> }
>> >
>> >
>>
>> Acked-by: Harish Patil <harish.patil@qlogic.com>
>>
>>
>> Minor question - any specific reason to use rte_be_to_cpu_16() on
>> ether_type alone before converting from native order to le16?
>
>ether_type is in network byte order (big endian)
>and hardware wants little endian. On x86 the second step is a nop.
>
Thanks. Yes the question was for second step, second step would be a no-op
on x86 - thanks for clarifying.
________________________________
This message and any attached documents contain information from the sending company or its parent company(s), subsidiaries, divisions or branch offices that may be confidential. If you are not the intended recipient, you may not read, copy, distribute, or use this information. If you have received this transmission in error, please notify the sender immediately by reply e-mail and then delete this message.
next prev parent reply other threads:[~2015-12-01 22:48 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-11-03 17:26 Chas Williams
2015-11-24 13:42 ` Thomas Monjalon
2015-12-01 21:53 ` Harish Patil
2015-12-01 22:37 ` Stephen Hemminger
2015-12-01 22:47 ` Harish Patil [this message]
2015-12-01 23:34 ` Thomas Monjalon
2015-12-01 23:58 ` Charles (Chas) Williams
2015-12-02 1:04 ` Thomas Monjalon
2015-12-02 10:18 ` Charles (Chas) Williams
2015-12-02 10:44 ` Thomas Monjalon
2015-12-06 21:55 ` Thomas Monjalon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=D28361A1.1047AA%harish.patil@qlogic.com \
--to=harish.patil@qlogic.com \
--cc=dev@dpdk.org \
--cc=stephen@networkplumber.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).