DPDK patches and discussions
 help / color / mirror / Atom feed

From: "Wang, Yipeng1" <yipeng1.wang@intel.com>
To: Vincent Jardin <vincent.jardin@6wind.com>
Cc: "dev@dpdk.org" <dev@dpdk.org>,
	"Gobriel, Sameh" <sameh.gobriel@intel.com>,
	 "Wang, Ren" <ren.wang@intel.com>,
	"Tai, Charlie" <charlie.tai@intel.com>
Subject: Re: [dpdk-dev] [RFC] Add Membership Library
Date: Thu, 1 Jun 2017 01:03:36 +0000	[thread overview]
Message-ID: <D2C4A16CA39F7F4E8E384D204491D7A640717076@ORSMSX105.amr.corp.intel.com> (raw)
In-Reply-To: <15c49491fa0.27fc.bb328046f2889bc8f44aafa891a44dd2@6wind.com>

Hi Vincent,

Thanks for the comments and some quick responses below:

- DPDK Bloom Filter is derived from the libbloom (as shown by the included BSD license), but optimized for performance with various DPDK goodness such as rte_zmalloc, rte_bitmap, rte_jhash, etc. It doesn't seem appropriate to    bring those DPDK specific features into libbloom, which is designed for more generic environments.
- DPDK Bloom Filter is just one very basic mode among other more sophisticated ones in the DPDK Membership Library, which supports a different set of APIs (e.g., bulk lookup, multi-match, etc.) than those supported in libbloom.
- It may make sense to bring some generic (i.e., non DPDK specific) improvements back to libbloom once identified.

Thanks
Yipeng

> -----Original Message-----
> From: Vincent Jardin [mailto:vincent.jardin@6wind.com]
> Sent: Saturday, May 27, 2017 2:42 AM
> To: Wang, Yipeng1 <yipeng1.wang@intel.com>
> Cc: dev@dpdk.org; Gobriel, Sameh <sameh.gobriel@intel.com>; Wang, Ren
> <ren.wang@intel.com>; Tai, Charlie <charlie.tai@intel.com>
> Subject: Re: [dpdk-dev] [RFC] Add Membership Library
> 
> Why duplicating Jyri's libbloom - https://github.com/jvirkki/libbloom - for this
> DPDK capability? Why not showing that you can contribute to libbloom and
> make it linkable with the DPDK?
> 
> There are so many duplicated code...
> 
> Thank you,
>   Vincent
> 

next prev parent reply	other threads:[~2017-06-01  1:03 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-05-27  1:34 Yipeng Wang
2017-05-27  1:34 ` Yipeng Wang
2017-05-27  9:42 ` Vincent Jardin
2017-06-01  1:03   ` Wang, Yipeng1 [this message]
2017-06-01 23:48     ` Vincent Jardin
2017-07-17 21:04       ` Vincent JARDIN
2017-06-02 20:51     ` Stephen Hemminger

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=D2C4A16CA39F7F4E8E384D204491D7A640717076@ORSMSX105.amr.corp.intel.com \
    --to=yipeng1.wang@intel.com \
    --cc=charlie.tai@intel.com \
    --cc=dev@dpdk.org \
    --cc=ren.wang@intel.com \
    --cc=sameh.gobriel@intel.com \
    --cc=vincent.jardin@6wind.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).