From: "Sanford, Robert" <rsanford@akamai.com>
To: "dev@dpdk.org" <dev@dpdk.org>,
"cristian.dumitrescu@intel.com" <cristian.dumitrescu@intel.com>
Subject: Re: [dpdk-dev] [PATCH 1/4] app/test: enhance test_port_ring_writer
Date: Fri, 1 Apr 2016 19:42:34 +0000 [thread overview]
Message-ID: <D32445AB.11A30%rsanford@akamai.com> (raw)
In-Reply-To: <1459198297-49854-2-git-send-email-rsanford@akamai.com>
We don't need to change this line, because we never access more than
RTE_PORT_IN_BURST_SIZE_MAX (64) elements in this array:
- struct rte_mbuf *mbuf[RTE_PORT_IN_BURST_SIZE_MAX];
+ struct rte_mbuf *mbuf[2 * RTE_PORT_IN_BURST_SIZE_MAX];
--
Robert
>Add code to send two 60-packet bursts to a ring port_out.
>This tests a ring writer buffer overflow problem and fix
>(in patch 2/4).
>
>Signed-off-by: Robert Sanford <rsanford@akamai.com>
>---
> app/test/test_table_ports.c | 27 +++++++++++++++++++++++++--
> 1 files changed, 25 insertions(+), 2 deletions(-)
>
>diff --git a/app/test/test_table_ports.c b/app/test/test_table_ports.c
>index 2532367..0c0ec0a 100644
>--- a/app/test/test_table_ports.c
>+++ b/app/test/test_table_ports.c
>@@ -149,8 +149,8 @@ test_port_ring_writer(void)
>
> /* -- Traffic TX -- */
> int expected_pkts, received_pkts;
>- struct rte_mbuf *mbuf[RTE_PORT_IN_BURST_SIZE_MAX];
>- struct rte_mbuf *res_mbuf[RTE_PORT_IN_BURST_SIZE_MAX];
>+ struct rte_mbuf *mbuf[2 * RTE_PORT_IN_BURST_SIZE_MAX];
>+ struct rte_mbuf *res_mbuf[2 * RTE_PORT_IN_BURST_SIZE_MAX];
>
> port_ring_writer_params.ring = RING_TX;
> port_ring_writer_params.tx_burst_sz = RTE_PORT_IN_BURST_SIZE_MAX;
>@@ -216,5 +216,28 @@ test_port_ring_writer(void)
> for (i = 0; i < RTE_PORT_IN_BURST_SIZE_MAX; i++)
> rte_pktmbuf_free(res_mbuf[i]);
>
>+ /* TX Bulk - send two 60-packet bursts */
>+ uint64_t pkt_mask = 0xfffffffffffffff0ULL;
>+
>+ for (i = 0; i < 4; i++)
>+ mbuf[i] = NULL;
>+ for (i = 4; i < 64; i++)
>+ mbuf[i] = rte_pktmbuf_alloc(pool);
>+ rte_port_ring_writer_ops.f_tx_bulk(port, mbuf, pkt_mask);
>+ for (i = 4; i < 64; i++)
>+ mbuf[i] = rte_pktmbuf_alloc(pool);
>+ rte_port_ring_writer_ops.f_tx_bulk(port, mbuf, pkt_mask);
>+ rte_port_ring_writer_ops.f_flush(port);
>+
>+ expected_pkts = 2 * 60;
>+ received_pkts = rte_ring_sc_dequeue_burst(port_ring_writer_params.ring,
>+ (void **)res_mbuf, 2 * RTE_PORT_IN_BURST_SIZE_MAX);
>+
>+ if (received_pkts != expected_pkts)
>+ return -10;
>+
>+ for (i = 0; i < received_pkts; i++)
>+ rte_pktmbuf_free(res_mbuf[i]);
>+
> return 0;
> }
>--
>1.7.1
next prev parent reply other threads:[~2016-04-01 19:42 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-03-28 20:51 [dpdk-dev] [PATCH 0/4] port: fix and test bugs in tx_bulk ops Robert Sanford
2016-03-28 20:51 ` [dpdk-dev] [PATCH 1/4] app/test: enhance test_port_ring_writer Robert Sanford
2016-04-01 19:42 ` Sanford, Robert [this message]
2016-04-06 16:46 ` Dumitrescu, Cristian
2016-03-28 20:51 ` [dpdk-dev] [PATCH 2/4] port: fix ring writer buffer overflow Robert Sanford
2016-03-31 11:21 ` Dumitrescu, Cristian
2016-03-28 20:51 ` [dpdk-dev] [PATCH 3/4] port: fix full burst checks in f_tx_bulk ops Robert Sanford
2016-03-31 15:41 ` Dumitrescu, Cristian
2016-04-01 19:31 ` Sanford, Robert
2016-03-28 20:51 ` [dpdk-dev] [PATCH 4/4] port: fix ethdev writer burst too big Robert Sanford
2016-03-31 13:22 ` Dumitrescu, Cristian
2016-03-30 11:00 ` [dpdk-dev] [PATCH 0/4] port: fix and test bugs in tx_bulk ops Thomas Monjalon
2016-03-30 11:58 ` Dumitrescu, Cristian
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=D32445AB.11A30%rsanford@akamai.com \
--to=rsanford@akamai.com \
--cc=cristian.dumitrescu@intel.com \
--cc=dev@dpdk.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).