From: "Wiles, Keith" <keith.wiles@intel.com>
To: Thomas Monjalon <thomas@monjalon.net>
Cc: DPDK <dev@dpdk.org>,
"Dumitrescu, Cristian" <cristian.dumitrescu@intel.com>,
"Lu, Wenzhuo" <wenzhuo.lu@intel.com>
Subject: [dpdk-dev] hierarchy_commit() message displayed when not using TM
Date: Wed, 26 Jul 2017 14:35:18 +0000 [thread overview]
Message-ID: <D3D856D3-CCC7-4B47-8BEB-401C093CCEA3@intel.com> (raw)
In-Reply-To: <5680989.RRpAUyPcSC@xps>
> On Jul 26, 2017, at 12:39 AM, Thomas Monjalon <thomas@monjalon.net> wrote:
>
>> I noticed a new message:
>> i40e_dev_start(): please call hierarchy_commit() before starting the port
>> i40e_dev_start(): please call hierarchy_commit() before starting the port
>> i40e_dev_start(): please call hierarchy_commit() before starting the port
>> i40e_dev_start(): please call hierarchy_commit() before starting the port
>>
>> and I tried to add the call in pktgen, but it had no effect. To me the TM API should be defaulted to the original mode and just work unless someone needs to use the TM APIs. The hierarchy_commit routine could not need to be called in the normal case is my guess.
>
> PS: I've noticed that you are the author of all the pktgen commits.
> Are you using git-am when applying patches from other contributors?
Cristian and Wenzhuo responded in another email and the messages above will be fixed.
Regards,
Keith
next prev parent reply other threads:[~2017-07-26 14:35 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-07-25 22:21 [dpdk-dev] [pktgen PATCH 0/6] fix compilation Thomas Monjalon
2017-07-25 22:21 ` [dpdk-dev] [pktgen PATCH 1/6] remove unused functions Thomas Monjalon
2017-07-25 22:21 ` [dpdk-dev] [pktgen PATCH 2/6] fix screen type saving Thomas Monjalon
2017-07-25 22:21 ` [dpdk-dev] [pktgen PATCH 3/6] fix compilation of printf based functions Thomas Monjalon
2017-07-25 22:21 ` [dpdk-dev] [pktgen PATCH 4/6] fix compilation with gcc 7 Thomas Monjalon
2017-07-25 22:21 ` [dpdk-dev] [pktgen PATCH 5/6] fix 32-bit build Thomas Monjalon
2017-07-25 22:21 ` [dpdk-dev] [pktgen PATCH 6/6] fix build with dpdk-17.08-rc2 Thomas Monjalon
2017-07-26 3:54 ` [dpdk-dev] [pktgen PATCH 0/6] fix compilation Wiles, Keith
2017-07-26 4:40 ` Roberts, Lee A.
2017-07-26 5:39 ` Thomas Monjalon
2017-07-26 14:35 ` Wiles, Keith [this message]
2017-07-26 14:58 ` [dpdk-dev] hierarchy_commit() message displayed when not using TM Lu, Wenzhuo
2017-07-26 14:52 ` [dpdk-dev] [pktgen PATCH 0/6] fix compilation Wiles, Keith
2017-07-26 15:01 ` Thomas Monjalon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=D3D856D3-CCC7-4B47-8BEB-401C093CCEA3@intel.com \
--to=keith.wiles@intel.com \
--cc=cristian.dumitrescu@intel.com \
--cc=dev@dpdk.org \
--cc=thomas@monjalon.net \
--cc=wenzhuo.lu@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).