From: "Patil, Harish" <Harish.Patil@cavium.com>
To: Thomas Monjalon <thomas@monjalon.net>
Cc: "ferruh.yigit@intel.com" <ferruh.yigit@intel.com>,
"dev@dpdk.org" <dev@dpdk.org>,
Dept-Eng DPDK Dev <Dept-EngDPDKDev@cavium.com>,
"Mody, Rasesh" <Rasesh.Mody@cavium.com>
Subject: Re: [dpdk-dev] [PATCH 1/8] net/qede: fix to disable per-VF Tx switching feature
Date: Wed, 8 Nov 2017 02:34:54 +0000 [thread overview]
Message-ID: <D627ACD7.172838%Harish.Patil@cavium.com> (raw)
In-Reply-To: <6189711.sNO2pZEAvp@xps>
-----Original Message-----
From: Thomas Monjalon <thomas@monjalon.net>
Date: Tuesday, November 7, 2017 at 6:44 PM
To: Harish Patil <Harish.Patil@cavium.com>
Cc: "ferruh.yigit@intel.com" <ferruh.yigit@intel.com>, "dev@dpdk.org"
<dev@dpdk.org>, Dept-Eng DPDK Dev <Dept-EngDPDKDev@cavium.com>, "Mody,
Rasesh" <Rasesh.Mody@cavium.com>
Subject: Re: [dpdk-dev] [PATCH 1/8] net/qede: fix to disable per-VF Tx
switching feature
>08/11/2017 02:34, Patil, Harish:
>> >> --- a/config/common_base
>> >> +++ b/config/common_base
>> >> +CONFIG_RTE_LIBRTE_QEDE_VF_TX_SWITCH=n
>> >
>> >We should remove all compile-time options because they cannot be used
>> >when DPDK is pre-packaged.
>> >That's why the rule is "NO NEW COMPILE TIME OPTION".
>> >
>> >After discussion with Ferruh, this patch is accepted as a hotfix.
>> >But this option is expected to be removed quickly.
>> >I've sent a patch to remove this option in 18.02:
>> > http://dpdk.org/ml/archives/dev/2017-November/081488.html
>> >It gives you some time to supersede my patch by introducing a
>> >run-time driver option.
>> >
>> >Thanks
>>
>> Hi Thomas,
>> Sure, thanks, we will address before 18.02-rc1.
>> Do you have any example on how to add a run-time driver option?
>> Does it mean to introduce some change in ethdev?
>
>It is done by parsing devargs with rte_kvargs.
>Examples:
> http://dpdk.org/commit/447e0d379
> http://dpdk.org/commit/001a520e4
> http://dpdk.org/commit/7958b1310
Thanks Thomas.
>
next prev parent reply other threads:[~2017-11-08 2:34 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-11-07 8:34 [dpdk-dev] [PATCH 0/8] net/qede: coverity issue fixes and bug fixes Rasesh Mody
2017-11-07 8:34 ` [dpdk-dev] [PATCH 1/8] net/qede: fix to disable per-VF Tx switching feature Rasesh Mody
2017-11-08 0:53 ` Thomas Monjalon
2017-11-08 1:34 ` Patil, Harish
2017-11-08 1:44 ` Thomas Monjalon
2017-11-08 2:34 ` Patil, Harish [this message]
2017-11-07 8:34 ` [dpdk-dev] [PATCH 2/8] net/qede: fix vxlan filter deletion Rasesh Mody
2017-11-07 8:34 ` [dpdk-dev] [PATCH 3/8] net/qede: fix to update device link structure Rasesh Mody
2017-11-07 8:34 ` [dpdk-dev] [PATCH 4/8] net/qede: remove duplicate includes Rasesh Mody
2017-11-07 8:34 ` [dpdk-dev] [PATCH 5/8] net/qede: fix to release the acquired ptt Rasesh Mody
2017-11-07 8:34 ` [dpdk-dev] [PATCH 6/8] net/qede/base: fix to initialize filter API return code Rasesh Mody
2017-11-07 8:34 ` [dpdk-dev] [PATCH 7/8] net/qede/base: fix division by zero Rasesh Mody
2017-11-07 8:34 ` [dpdk-dev] [PATCH 8/8] net/qede: fix null pointer dereferences Rasesh Mody
2017-11-07 22:53 ` [dpdk-dev] [PATCH 0/8] net/qede: coverity issue fixes and bug fixes Ferruh Yigit
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=D627ACD7.172838%Harish.Patil@cavium.com \
--to=harish.patil@cavium.com \
--cc=Dept-EngDPDKDev@cavium.com \
--cc=Rasesh.Mody@cavium.com \
--cc=dev@dpdk.org \
--cc=ferruh.yigit@intel.com \
--cc=thomas@monjalon.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).