From: "Gobriel, Sameh" <sameh.gobriel@intel.com>
To: Thomas Monjalon <thomas@monjalon.net>,
"Medvedkin, Vladimir" <vladimir.medvedkin@intel.com>
Cc: "dev@dpdk.org" <dev@dpdk.org>,
"Wang, Yipeng1" <yipeng1.wang@intel.com>,
"Richardson, Bruce" <bruce.richardson@intel.com>,
"De Lara Guarch, Pablo" <pablo.de.lara.guarch@intel.com>,
"Yigit, Ferruh" <ferruh.yigit@intel.com>
Subject: Re: [dpdk-dev] [PATCH v2] maintainers: claim maintainership of Toeplitz hash
Date: Thu, 7 Feb 2019 21:32:55 +0000 [thread overview]
Message-ID: <D6455DCED8CA9B4B940598A7ACF7B9FDB50256E4@ORSMSX113.amr.corp.intel.com> (raw)
In-Reply-To: <8657694.f1liP514bC@xps>
I agree with Thomas. It makes sense to separate out hash function from hash table implementation.
Sameh
-----Original Message-----
From: Thomas Monjalon [mailto:thomas@monjalon.net]
Sent: Thursday, February 7, 2019 1:25 PM
To: Medvedkin, Vladimir <vladimir.medvedkin@intel.com>
Cc: dev@dpdk.org; Wang, Yipeng1 <yipeng1.wang@intel.com>; Gobriel, Sameh <sameh.gobriel@intel.com>; Richardson, Bruce <bruce.richardson@intel.com>; De Lara Guarch, Pablo <pablo.de.lara.guarch@intel.com>; Yigit, Ferruh <ferruh.yigit@intel.com>
Subject: Re: [dpdk-dev] [PATCH v2] maintainers: claim maintainership of Toeplitz hash
07/02/2019 20:28, Medvedkin, Vladimir:
> On 06/02/2019 10:38, Thomas Monjalon wrote:
> > 05/02/2019 14:57, Vladimir Medvedkin:
> >> --- a/MAINTAINERS
> >> +++ b/MAINTAINERS
> >> +M: Vladimir Medvedkin <vladimir.medvedkin@intel.com>
> >> +F: lib/librte_hash/rte_thash.h
> > I'm not sure about adding maintainership for one file.
> > You are the author of this file, so you should be consulted during
> > reviews if you don't catch them by yourself.
> > But I prefer seeing maintainers as taking charge and understanding
> > of a full library as a block.
> >
> > And unfortunately, it does not work with the script:
> > devtools/get-maintainer.sh lib/librte_hash/rte_cuckoo_hash.h You
> > would appear as maintainer for all hash files.
>
> It could be solved by adding header.
>
> In fact thash is not used by other parts of the hash library (instead
> it could be used by softnic for example).
>
> From my point of view, hash library consists of two parts, hash table
> itself and a number of hash functions. Hash functions, in turn, can be
> used for many other purposes, not just for a hash table. Maybe we
> should separate hash functions and hash table? And if you think it is
> a bad idea, so be it, 4 maintainers for hash is enough.
I don't know.
It's opening the door for more split of maintainers areas.
I would like to get more opinions from other maintainers, please.
next prev parent reply other threads:[~2019-02-07 21:32 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-02-03 16:34 [dpdk-dev] [PATCH] maintainers: claim co-maintainership of LPM Vladimir Medvedkin
2019-02-03 16:34 ` [dpdk-dev] [PATCH] maintainers: claim maintainership of Toeplitz hash Vladimir Medvedkin
2019-02-05 13:57 ` [dpdk-dev] [PATCH v2] " Vladimir Medvedkin
2019-02-06 10:38 ` Thomas Monjalon
2019-02-07 19:28 ` Medvedkin, Vladimir
2019-02-07 21:24 ` Thomas Monjalon
2019-02-07 21:32 ` Gobriel, Sameh [this message]
2019-02-07 23:13 ` Wang, Yipeng1
2019-02-08 11:34 ` Medvedkin, Vladimir
2019-02-03 16:34 ` [dpdk-dev] [PATCH] rte_thash: replace license text with SPDX tag Vladimir Medvedkin
2019-02-05 13:57 ` [dpdk-dev] [PATCH v2] " Vladimir Medvedkin
2019-02-06 10:45 ` Thomas Monjalon
2019-02-04 9:58 ` [dpdk-dev] [PATCH] maintainers: claim co-maintainership of LPM Bruce Richardson
2019-02-05 13:57 ` [dpdk-dev] [PATCH v2] " Vladimir Medvedkin
2019-02-06 10:41 ` Thomas Monjalon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=D6455DCED8CA9B4B940598A7ACF7B9FDB50256E4@ORSMSX113.amr.corp.intel.com \
--to=sameh.gobriel@intel.com \
--cc=bruce.richardson@intel.com \
--cc=dev@dpdk.org \
--cc=ferruh.yigit@intel.com \
--cc=pablo.de.lara.guarch@intel.com \
--cc=thomas@monjalon.net \
--cc=vladimir.medvedkin@intel.com \
--cc=yipeng1.wang@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).