From: "Wiles, Keith" <keith.wiles@intel.com>
To: "Richardson, Bruce" <bruce.richardson@intel.com>
Cc: "dev@dpdk.org" <dev@dpdk.org>
Subject: Re: [dpdk-dev] [PATCH] net/tap: fix coverity warning on strncpy
Date: Fri, 17 Feb 2017 15:05:40 +0000 [thread overview]
Message-ID: <D8053801-BD60-46B3-9BF2-417044D78ACD@intel.com> (raw)
In-Reply-To: <20170217150245.GB8652@bricha3-MOBL3.ger.corp.intel.com>
> On Feb 17, 2017, at 9:02 AM, Richardson, Bruce <bruce.richardson@intel.com> wrote:
>
> On Fri, Feb 17, 2017 at 08:44:26AM -0600, Keith Wiles wrote:
>> Calling strncpy with a maximum size argument of 16 bytes on destination
>> array "ifr.ifr_ifrn.ifrn_name" of size 16 bytes might leave the
>> destination string unterminated.
>>
>> Signed-off-by: Keith Wiles <keith.wiles@intel.com>
>> ---
>> drivers/net/tap/rte_eth_tap.c | 2 +-
>> 1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/drivers/net/tap/rte_eth_tap.c b/drivers/net/tap/rte_eth_tap.c
>> index efc4426..f9938d7 100644
>> --- a/drivers/net/tap/rte_eth_tap.c
>> +++ b/drivers/net/tap/rte_eth_tap.c
>> @@ -297,7 +297,7 @@ tap_link_set_flags(struct pmd_internals *pmd, short flags, int add)
>> return -1;
>> }
>> memset(&ifr, 0, sizeof(ifr));
>> - strncpy(ifr.ifr_name, pmd->name, IFNAMSIZ);
>> + strncpy(ifr.ifr_name, pmd->name, IFNAMSIZ-1);
> This is why I always prefer to use snprintf for copying strings, you
> can't avoid null terminating.
Normally I use snprintf to not sure why I reverted to strncpy. Maybe leftover from a previous driver I used as the template.
>
> snprintf(ifr.ifr_name, IFNAMSIZ, "%s", pmd->name);
>
> /Bruce
Regards,
Keith
next prev parent reply other threads:[~2017-02-17 15:05 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-02-17 14:44 Keith Wiles
2017-02-17 14:48 ` Wiles, Keith
2017-02-17 15:02 ` Bruce Richardson
2017-02-17 15:05 ` Wiles, Keith [this message]
2017-02-17 15:13 ` Bruce Richardson
2017-02-17 15:15 ` Ferruh Yigit
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=D8053801-BD60-46B3-9BF2-417044D78ACD@intel.com \
--to=keith.wiles@intel.com \
--cc=bruce.richardson@intel.com \
--cc=dev@dpdk.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).