From: Raslan Darawsheh <rasland@mellanox.com>
To: Ali Alnubani <alialnu@mellanox.com>, "dev@dpdk.org" <dev@dpdk.org>
Cc: Slava Ovsiienko <viacheslavo@mellanox.com>,
Jeremy Plsek <jplsek@iol.unh.edu>
Subject: Re: [dpdk-dev] [PATCH] net/mlx5: fix build with strict alignment enabled
Date: Sun, 20 Oct 2019 07:58:19 +0000 [thread overview]
Message-ID: <DB3PR0502MB39641FD76D432ADB5BB72F36C26E0@DB3PR0502MB3964.eurprd05.prod.outlook.com> (raw)
In-Reply-To: <20191015145508.19625-1-alialnu@mellanox.com>
Hi,
> -----Original Message-----
> From: dev <dev-bounces@dpdk.org> On Behalf Of Ali Alnubani
> Sent: Tuesday, October 15, 2019 5:56 PM
> To: dev@dpdk.org
> Cc: Slava Ovsiienko <viacheslavo@mellanox.com>; Jeremy Plsek
> <jplsek@iol.unh.edu>
> Subject: [dpdk-dev] [PATCH] net/mlx5: fix build with strict alignment enabled
>
> This patch converts some of the casts to unaligned integer types.
>
> This fixes the following error, which is seen on x86, with
> gcc 7.4.0:
>
> drivers/net/mlx5/mlx5_rxtx.c: In function ‘mlx5_tx_dseg_iptr’:
> drivers/net/mlx5/mlx5_rxtx.c:2740:9: error: passing argument 1 of
> ‘memcpy’ makes pointer from integer without a cast
> [-Werror=int-conversion]
> memcpy(dst, src, len);
> ^~~
>
> The memcpy call is replaced with 2 copies of uint32 for better
> performance on ARM.
>
> Fixes: 18a1c20044c0 ("net/mlx5: implement Tx burst template")
>
> Reported-by: Jeremy Plsek <jplsek@iol.unh.edu>
> Signed-off-by: Ali Alnubani <alialnu@mellanox.com>
Patch applied to next-net-mlx,
Kindest regards,
Raslan Darawsheh
prev parent reply other threads:[~2019-10-20 7:58 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-10-15 14:56 Ali Alnubani
2019-10-15 15:06 ` Slava Ovsiienko
2019-10-17 7:19 ` [dpdk-dev] [PATCH v2] " Ali Alnubani
2019-10-20 7:58 ` Raslan Darawsheh [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=DB3PR0502MB39641FD76D432ADB5BB72F36C26E0@DB3PR0502MB3964.eurprd05.prod.outlook.com \
--to=rasland@mellanox.com \
--cc=alialnu@mellanox.com \
--cc=dev@dpdk.org \
--cc=jplsek@iol.unh.edu \
--cc=viacheslavo@mellanox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).