From: Raslan Darawsheh <rasland@mellanox.com>
To: Slava Ovsiienko <viacheslavo@mellanox.com>,
"dev@dpdk.org" <dev@dpdk.org>
Cc: Matan Azrad <matan@mellanox.com>, Ori Kam <orika@mellanox.com>
Subject: Re: [dpdk-dev] [PATCH] net/mlx5: fix vport id value in port id action
Date: Thu, 14 Nov 2019 12:25:27 +0000 [thread overview]
Message-ID: <DB3PR0502MB3964C05FFD64C84066D14273C2710@DB3PR0502MB3964.eurprd05.prod.outlook.com> (raw)
In-Reply-To: <1573721796-22614-1-git-send-email-viacheslavo@mellanox.com>
Hi,
> -----Original Message-----
> From: Viacheslav Ovsiienko <viacheslavo@mellanox.com>
> Sent: Thursday, November 14, 2019 10:57 AM
> To: dev@dpdk.org
> Cc: Matan Azrad <matan@mellanox.com>; Raslan Darawsheh
> <rasland@mellanox.com>; Ori Kam <orika@mellanox.com>
> Subject: [PATCH] net/mlx5: fix vport id value in port id action
>
> The kernel driver (starting from OFED 4.7.3.1.3) uses the upper half
> of metadata register C0 to provide VHCA and vport id's. The mlx5 PMD
> should check the actual mask of register C0 and shift the vport id
> value for port actions appropriately.
>
> Fixes: f07341e7aed3 ("net/mlx5: update source and destination vport
> translations")
>
> Signed-off-by: Viacheslav Ovsiienko <viacheslavo@mellanox.com>
> ---
> drivers/net/mlx5/mlx5_flow_dv.c | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/net/mlx5/mlx5_flow_dv.c
> b/drivers/net/mlx5/mlx5_flow_dv.c
> index 2094e18..5a0cd09 100644
> --- a/drivers/net/mlx5/mlx5_flow_dv.c
> +++ b/drivers/net/mlx5/mlx5_flow_dv.c
> @@ -6532,7 +6532,8 @@ struct field_modify_info modify_tcp[] = {
> NULL,
> "No eswitch info was found for
> port");
> if (priv->vport_meta_mask)
> - *dst_port_id = priv->vport_meta_tag;
> + *dst_port_id = priv->vport_meta_tag >>
> + rte_bsf32(priv->vport_meta_mask);
> else
> *dst_port_id = priv->vport_id;
> return 0;
> --
> 1.8.3.1
Patch applied to next-net-mlx,
Kindest regards,
Raslan Darawsheh
prev parent reply other threads:[~2019-11-14 12:25 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-11-14 8:56 Viacheslav Ovsiienko
2019-11-14 12:05 ` Matan Azrad
2019-11-14 12:25 ` Raslan Darawsheh [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=DB3PR0502MB3964C05FFD64C84066D14273C2710@DB3PR0502MB3964.eurprd05.prod.outlook.com \
--to=rasland@mellanox.com \
--cc=dev@dpdk.org \
--cc=matan@mellanox.com \
--cc=orika@mellanox.com \
--cc=viacheslavo@mellanox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).