DPDK patches and discussions
 help / color / mirror / Atom feed
From: Raslan Darawsheh <rasland@mellanox.com>
To: Slava Ovsiienko <viacheslavo@mellanox.com>,
	"dev@dpdk.org" <dev@dpdk.org>
Cc: Matan Azrad <matan@mellanox.com>, Ori Kam <orika@mellanox.com>
Subject: Re: [dpdk-dev] [PATCH] net/mlx5: fix assert in tx inline settings ajustment
Date: Tue, 19 Nov 2019 15:59:20 +0000	[thread overview]
Message-ID: <DB3PR0502MB3964DFAD6253B7717195F7FCC24C0@DB3PR0502MB3964.eurprd05.prod.outlook.com> (raw)
In-Reply-To: <1574169189-872-1-git-send-email-viacheslavo@mellanox.com>

Hi,

> -----Original Message-----
> From: Viacheslav Ovsiienko <viacheslavo@mellanox.com>
> Sent: Tuesday, November 19, 2019 3:13 PM
> To: dev@dpdk.org
> Cc: Matan Azrad <matan@mellanox.com>; Raslan Darawsheh
> <rasland@mellanox.com>; Ori Kam <orika@mellanox.com>
> Subject: [PATCH] net/mlx5: fix assert in tx inline settings ajustment
> 
> Assert condition is fixed to not alert for the case when multi-packet write is
> not supported/engaged at all.
> 
> Fixes: b53cd86965a1 ("net/mlx5: adjust inline setting for large Tx queue
> sizes")
> 
> Signed-off-by: Viacheslav Ovsiienko <viacheslavo@mellanox.com>
> ---
>  drivers/net/mlx5/mlx5_txq.c | 3 ++-
>  1 file changed, 2 insertions(+), 1 deletion(-)
> 
> diff --git a/drivers/net/mlx5/mlx5_txq.c b/drivers/net/mlx5/mlx5_txq.c
> index a0d6164..47b1de8 100644
> --- a/drivers/net/mlx5/mlx5_txq.c
> +++ b/drivers/net/mlx5/mlx5_txq.c
> @@ -1210,7 +1210,8 @@ struct mlx5_txq_obj *
>  	assert(txq_ctrl->max_inline_data <= max_inline);
>  	assert(txq_ctrl->txq.inlen_mode <= max_inline);
>  	assert(txq_ctrl->txq.inlen_mode <= txq_ctrl->txq.inlen_send);
> -	assert(txq_ctrl->txq.inlen_mode <= txq_ctrl->txq.inlen_empw);
> +	assert(txq_ctrl->txq.inlen_mode <= txq_ctrl->txq.inlen_empw ||
> +	       !txq_ctrl->txq.inlen_empw);
>  	return 0;
>  error:
>  	rte_errno = ENOMEM;
> --
> 1.8.3.1


Patch applied to next-net-mlx,
Kindest regards,
Raslan Darawsheh

      reply	other threads:[~2019-11-19 15:59 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-11-19 13:13 Viacheslav Ovsiienko
2019-11-19 15:59 ` Raslan Darawsheh [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=DB3PR0502MB3964DFAD6253B7717195F7FCC24C0@DB3PR0502MB3964.eurprd05.prod.outlook.com \
    --to=rasland@mellanox.com \
    --cc=dev@dpdk.org \
    --cc=matan@mellanox.com \
    --cc=orika@mellanox.com \
    --cc=viacheslavo@mellanox.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).