From: Liming Sun <lsun@ezchip.com>
To: Thomas Monjalon <thomas.monjalon@6wind.com>
Cc: "dev@dpdk.org" <dev@dpdk.org>
Subject: Re: [dpdk-dev] [PATCH v2 1/3] driver/net/mpipe: support native build on tilegx platform.
Date: Tue, 9 Feb 2016 21:15:27 +0000 [thread overview]
Message-ID: <DB5PR02MB10157D3226559BCFE8CB1B69BCD60@DB5PR02MB1015.eurprd02.prod.outlook.com> (raw)
In-Reply-To: <1753191.PlZlSmjA8r@xps13>
Looks like this patch serie has been merged into dpdk-next-net/rel_16_04.
What would be the usual way to submit changes for new comments? Would it be incremental changes (new commit) based on previous one? Thanks.
________________________________________
From: Thomas Monjalon <thomas.monjalon@6wind.com>
Sent: Tuesday, February 9, 2016 3:33 PM
To: Liming Sun
Cc: dev@dpdk.org; bruce.richardson@intel.com
Subject: Re: [dpdk-dev] [PATCH v2 1/3] driver/net/mpipe: support native build on tilegx platform.
2016-02-09 18:37, Liming Sun:
> From: Thomas Monjalon [mailto:thomas.monjalon@6wind.com]
> A comment about the TILE-Mx would be welcome.
> Is it supported currently?
> Isn't it an ARM arch?
>
> [lsun] Yes, it's ARM arch, but with similar mpipe driver.
> It's not fully supported yet. I'll remove this change and add it in a different serie when it's ready.
OK
So we'll discuss how to integrate it later.
> > +# Compile combined lib by default.
> > +CONFIG_RTE_BUILD_COMBINE_LIBS=y
>
> Why forcing this option in the defconfig file?
>
> [lsun] It's just trying to make it handy for other applications like OVS or ODP on top of DPDK. However we could remove this change if it's not the recommended way.
Yes please remove it.
> > ARCH ?= tile
> > +
> > +HOST_ARCH := ${shell uname -m}
> > +ifneq ($(filter tile%,${HOST_ARCH}),) CROSS = else
> > CROSS ?= tile-
> > +endif
>
> I don't think the CROSS variable should have a default value.
> It really depends on the toolchain.
>
> [lsun] Make sense. The current code (before the change) has default value 'CROSS ?= tile-' defined, which cause some issue when doing native build. Another way is to define it as "CROSS ?=" just like other platforms. So when doing cross-compile, we could pass " CROSS=tile-" .
No need to keep a "CROSS ?=" line.
The variables defined in the command line get the priority.
> Talking about the toolchain, is it possible to build DPDK with the provided binary toolchain http://www.tilera.com/scm/tilegx-x86_64.tar.bz2 ?
> This is the Tilera Open Source page: http://www.tilera.com/scm/
>
> [lsun] I tried it just now. The gcc appears ok. But this tarball lacks of some header files and libraries to compile DPDK.
Yes that's what I've experienced.
> We're looking into it to see whether it can be easily fixed.
Please keep us informed when the toolchain is ready. Thanks
next prev parent reply other threads:[~2016-02-09 21:15 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-12-15 15:37 [dpdk-dev] [PATCH 0/3] Some misc fixes and optimization for the mpipe driver Liming Sun
2015-12-15 15:37 ` [dpdk-dev] [PATCH 1/3] driver/net/mpipe: support native build on tilegx platform Liming Sun
2016-01-08 2:59 ` Tony Lu
2015-12-15 15:37 ` [dpdk-dev] [PATCH 2/3] driver/net/mpipe: optimize mpipe buffer return mechanism Liming Sun
2016-01-08 3:04 ` Tony Lu
2015-12-15 15:37 ` [dpdk-dev] [PATCH 3/3] driver/net/mpipe: fix a mpipe link initialization ordering issue Liming Sun
2016-01-08 3:08 ` Tony Lu
2016-01-08 14:30 ` [dpdk-dev] [PATCH v2 1/3] driver/net/mpipe: support native build on tilegx platform Liming Sun
2016-01-08 14:30 ` [dpdk-dev] [PATCH v2 2/3] driver/net/mpipe: optimize mpipe buffer return mechanism Liming Sun
2016-01-08 14:30 ` [dpdk-dev] [PATCH v2 3/3] driver/net/mpipe: fix a mpipe link initialization ordering issue Liming Sun
2016-02-09 15:49 ` [dpdk-dev] [PATCH v2 1/3] driver/net/mpipe: support native build on tilegx platform Bruce Richardson
2016-02-09 16:16 ` Thomas Monjalon
2016-02-09 18:37 ` Liming Sun
2016-02-09 20:33 ` Thomas Monjalon
2016-02-09 21:15 ` Liming Sun [this message]
2016-02-09 22:47 ` Thomas Monjalon
2016-02-10 9:49 ` Bruce Richardson
2016-02-10 10:00 ` Thomas Monjalon
2016-03-08 19:48 ` Thomas Monjalon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=DB5PR02MB10157D3226559BCFE8CB1B69BCD60@DB5PR02MB1015.eurprd02.prod.outlook.com \
--to=lsun@ezchip.com \
--cc=dev@dpdk.org \
--cc=thomas.monjalon@6wind.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).