From: Hemant Agrawal <hemant.agrawal@nxp.com>
To: "Hunt, David" <david.hunt@intel.com>,
"olivier.matz@6wind.com" <olivier.matz@6wind.com>
Cc: "dev@dpdk.org" <dev@dpdk.org>,
"jerin.jacob@caviumnetworks.com" <jerin.jacob@caviumnetworks.com>
Subject: Re: [dpdk-dev] [PATCH v2 2/2] mempool:pktmbuf pool default fallback for mempool ops error
Date: Fri, 16 Sep 2016 09:34:21 +0000 [thread overview]
Message-ID: <DB5PR04MB1605BC3D6DF0D30E2C53E97589F30@DB5PR04MB1605.eurprd04.prod.outlook.com> (raw)
In-Reply-To: <ae7a992c-c5fc-348e-2f75-b60fe01cc2d1@intel.com>
Hi David,
> -----Original Message-----
> From: Hunt, David [mailto:david.hunt@intel.com]
> Sent: Friday, September 16, 2016 2:00 PM
> To: Hemant Agrawal <hemant.agrawal@nxp.com>; olivier.matz@6wind.com
> Cc: dev@dpdk.org; jerin.jacob@caviumnetworks.com
> Subject: Re: [PATCH v2 2/2] mempool:pktmbuf pool default fallback for
> mempool ops error
>
> Hi Hemant,
>
> On 15/9/2016 6:13 PM, Hemant Agrawal wrote:
> > In the rte_pktmbuf_pool_create, if the default external mempool is not
> > available, the implementation can default to "ring_mp_mc", which is an
> > software implementation.
> >
> > Signed-off-by: Hemant Agrawal <hemant.agrawal@nxp.com>
> > ---
> > lib/librte_mbuf/rte_mbuf.c | 5 +++++
> > 1 file changed, 5 insertions(+)
> >
> > diff --git a/lib/librte_mbuf/rte_mbuf.c b/lib/librte_mbuf/rte_mbuf.c
> > index 4846b89..4adb4f5 100644
> > --- a/lib/librte_mbuf/rte_mbuf.c
> > +++ b/lib/librte_mbuf/rte_mbuf.c
> > @@ -176,6 +176,11 @@ rte_pktmbuf_pool_create(const char *name,
> > unsigned n,
> >
> > rte_errno = rte_mempool_set_ops_byname(mp,
> > RTE_MBUF_DEFAULT_MEMPOOL_OPS, NULL);
> > +
> > + /* on error, try falling back to the software based default pool */
> > + if (rte_errno == -EOPNOTSUPP)
> > + rte_errno = rte_mempool_set_ops_byname(mp, "ring_mp_mc",
> NULL);
>
> Should we log a warning message here saying that we're falling back to the
> mp/mc handler?
>
[Hemant]Agree. Will add it.
> > +
> > if (rte_errno != 0) {
> > RTE_LOG(ERR, MBUF, "error setting mempool handler\n");
> > return NULL;
next prev parent reply other threads:[~2016-09-16 9:34 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-09-08 14:50 [dpdk-dev] [PATCH 1/2] eal/mempool: introduce check for external mempool availability Hemant Agrawal
2016-09-08 14:50 ` [dpdk-dev] [PATCH 2/2] mempool:pktmbuf pool default fallback for mempool ops error Hemant Agrawal
2016-09-15 17:13 ` [dpdk-dev] [PATCH v2 1/2] eal/mempool: introduce check for external mempool availability Hemant Agrawal
2016-09-15 17:13 ` [dpdk-dev] [PATCH v2 2/2] mempool:pktmbuf pool default fallback for mempool ops error Hemant Agrawal
2016-09-16 8:29 ` Hunt, David
2016-09-16 9:34 ` Hemant Agrawal [this message]
2016-09-16 9:13 ` [dpdk-dev] [PATCH v2 1/2] eal/mempool: introduce check for external mempool availability Hunt, David
2016-09-16 9:34 ` Hemant Agrawal
2016-09-16 16:46 ` [dpdk-dev] [PATCH v3 1/2] eal/mempool: check for external mempool support Hemant Agrawal
2016-09-16 16:46 ` [dpdk-dev] [PATCH v3 2/2] mempool: pktmbuf pool default fallback for mempool ops error Hemant Agrawal
2016-09-19 13:57 ` Olivier Matz
2016-09-22 13:12 ` Hemant Agrawal
2016-10-13 13:15 ` Hemant Agrawal
2016-10-14 12:10 ` Olivier Matz
2016-11-07 12:30 ` Hemant Agrawal
2016-11-22 9:24 ` Olivier Matz
2016-12-08 8:57 ` Hemant Agrawal
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=DB5PR04MB1605BC3D6DF0D30E2C53E97589F30@DB5PR04MB1605.eurprd04.prod.outlook.com \
--to=hemant.agrawal@nxp.com \
--cc=david.hunt@intel.com \
--cc=dev@dpdk.org \
--cc=jerin.jacob@caviumnetworks.com \
--cc=olivier.matz@6wind.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).