From: Raslan Darawsheh <rasland@mellanox.com>
To: "Ferruh Yigit" <ferruh.yigit@intel.com>,
"Wu, Jingjing" <jingjing.wu@intel.com>,
"Gaëtan Rivet" <gaetan.rivet@6wind.com>
Cc: Thomas Monjalon <thomas@monjalon.net>,
"dev@dpdk.org" <dev@dpdk.org>,
Saleh Alsouqi <salehals@mellanox.com>
Subject: Re: [dpdk-dev] [PATCH] app/testpmd: app/testpmd: add device removal command
Date: Sun, 3 Dec 2017 09:32:15 +0000 [thread overview]
Message-ID: <DB5PR05MB12214B48C443037DFA40E640C23F0@DB5PR05MB1221.eurprd05.prod.outlook.com> (raw)
In-Reply-To: <24d62f28-52c6-6df6-525c-920c97e52112@intel.com>
Hi Ferruh,
Yes I believe this patch is no more required.
Kindest regards,
Raslan Darawsheh
-----Original Message-----
From: Ferruh Yigit [mailto:ferruh.yigit@intel.com]
Sent: Wednesday, November 29, 2017 12:02 AM
To: Wu, Jingjing <jingjing.wu@intel.com>; Gaëtan Rivet <gaetan.rivet@6wind.com>
Cc: Raslan Darawsheh <rasland@mellanox.com>; Thomas Monjalon <thomas@monjalon.net>; dev@dpdk.org; Saleh Alsouqi <salehals@mellanox.com>
Subject: Re: [dpdk-dev] [PATCH] app/testpmd: app/testpmd: add device removal command
On 9/7/2017 1:17 AM, Wu, Jingjing wrote:
>>>
>>> Since dealing with device is kind of new, it can be OK to create new
>>> command tree, but there are already hotplug commands per port:
>>> "port attach #PCI|#VDEV_NAME"
>>> "port detach #P"
>>>
>>
>> Those two commands deal with the etherdev hotplug API.
>> The new command should test the rte_dev one.
>>
> I was confused. The forwarding in testpmd setup is based on port id, right?
> And all the devices listed in testpmd is etherdev, and all functional testings are all based on port id, right?
> Then what is the difference to use port id or device name in testpmd?
> And if no difference, what is the difference between detach and remove?
>
> The only difference here I think is
> Remove command is using rte_bus hotplug framework.
> Attach/detach is using rte_eth_dev_detach API.
Hi Raslan,
With latest code "detach" does rte_bus hotplug remove. So I believe this patch is no more required. Can you please confirm?
Thanks,
ferruh
>
> I think remove command should be an important command, and should not have ambiguity.
> At least we need to doc it clearly.
>
>
>> As Thomas pointed out, the etherdev one deals only with eth ports,
>> while hotplug could be generalized to other devices, such as cryptodev.
>>
>>> perhaps it can be good to keep "attach", "detach" keywords for
>>> device to be consistent?
>>>
>>> "device attach #name"
>>> "device detach #name"
>>>
>>
>> I made a point of naming the hotplug operations in rte_bus
>> plug/unplug to avoid the confusion with the etherdev API. hotplug_add
>> / hotplug_remove also marks the distinction.
>>
>> I don't know if it would be helpful for a developer writing a PMD,
>> searching for a way to test a functionality to have an API name
>> mismatch.
>>
>>> Also a show equivalent can be added to work in device level:
>>> "show device info"
>>>
>>
>> I think it would be useful.
>>
>>>
>>> [1]
>>> https://emea01.safelinks.protection.outlook.com/?url=http%3A%2F%2Fdp
>>> dk.org%2Fml%2Farchives%2Fdev%2F2017-August%2F072764.html&data=02%7C0
>>> 1%7Crasland%40mellanox.com%7Cdde3d3196af240dc46e508d536abb3fd%7Ca652
>>> 971c7d2e4d9ba6a4d149256f461b%7C0%7C0%7C636475033483509610&sdata=tddN
>>> jwaa3H%2BNh2n7%2F%2BraWc82h9jNuFp9JXZx%2F%2BASH8M%3D&reserved=0
>>>
>>>
>>
>> --
>> Gaëtan Rivet
>> 6WIND
>
prev parent reply other threads:[~2017-12-03 9:32 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-08-23 14:37 Raslan Darawsheh
2017-08-23 15:09 ` Gaëtan Rivet
2017-08-23 16:18 ` Thomas Monjalon
2017-08-25 7:53 ` Gaëtan Rivet
2017-08-25 8:55 ` Thomas Monjalon
2017-08-28 9:55 ` Gaëtan Rivet
2017-08-28 10:30 ` Ferruh Yigit
2017-08-28 11:00 ` Thomas Monjalon
2017-08-28 11:12 ` Gaëtan Rivet
2017-09-07 8:17 ` Wu, Jingjing
2017-11-28 22:02 ` Ferruh Yigit
2017-12-03 9:32 ` Raslan Darawsheh [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=DB5PR05MB12214B48C443037DFA40E640C23F0@DB5PR05MB1221.eurprd05.prod.outlook.com \
--to=rasland@mellanox.com \
--cc=dev@dpdk.org \
--cc=ferruh.yigit@intel.com \
--cc=gaetan.rivet@6wind.com \
--cc=jingjing.wu@intel.com \
--cc=salehals@mellanox.com \
--cc=thomas@monjalon.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).