DPDK patches and discussions
 help / color / mirror / Atom feed

From: Raslan Darawsheh <rasland@mellanox.com>
To: "Wiles, Keith" <keith.wiles@intel.com>
Cc: Thomas Monjalon <thomas@monjalon.net>,
	"dev@dpdk.org" <dev@dpdk.org>,
	Shahaf Shuler <shahafs@mellanox.com>,
	Ori Kam <orika@mellanox.com>,
	"Yigit, Ferruh" <ferruh.yigit@intel.com>
Subject: Re: [dpdk-dev] [PATCH v5 3/3] net/tap: add queues when attaching from secondary process
Date: Wed, 10 Oct 2018 14:39:46 +0000	[thread overview]
Message-ID: <DB5PR05MB12541505136415440A349CF9C2E00@DB5PR05MB1254.eurprd05.prod.outlook.com> (raw)
In-Reply-To: <53E19DB1-1266-4588-8EB2-04062A5DEBB1@intel.com>

Just sent a new Version with the commit log reworded as mentioned. 

Kindest regards,
Raslan Darawsheh

> -----Original Message-----
> From: Wiles, Keith <keith.wiles@intel.com>
> Sent: Wednesday, October 10, 2018 3:48 PM
> To: Raslan Darawsheh <rasland@mellanox.com>
> Cc: Thomas Monjalon <thomas@monjalon.net>; dev@dpdk.org; Shahaf
> Shuler <shahafs@mellanox.com>; Ori Kam <orika@mellanox.com>; Yigit,
> Ferruh <ferruh.yigit@intel.com>
> Subject: Re: [PATCH v5 3/3] net/tap: add queues when attaching from
> secondary process
> 
> 
> 
> > On Oct 10, 2018, at 2:03 AM, Raslan Darawsheh <rasland@mellanox.com>
> wrote:
> >
> > In the case the device is created by the primary process, the
> > secondary must request some file descriptors to attach the queues.
> > The file descriptors are shared via IPC Unix socket.
> >
> > Thanks to the IPC synchronization, the secondary process is now able
> > to do Rx/Tx on a TAP created by the primary process.
> >
> > Signed-off-by: Raslan Darawsheh <rasland@mellanox.com>
> > Signed-off-by: Thomas Monjalon <thomas@monjalon.net>
> >
> > ---
> >    v2:
> >       - translate file descriptors via IPC API
> >       - add documentation
> >    v3:
> >       - rabse the commit
> >       - use private static array for fd's to be local for each process
> >
> >    v4:
> >       - removed TODO and FIXME tags
> >       - used strlcpy instead of strcpy
> >
> >    v5: rebase the commit on top of Alejandro Lucero patch for secondary
> >        process private pointer.
> >
> >
> https://emea01.safelinks.protection.outlook.com/?url=http%3A%2F%2Fpatc
> >
> hes.dpdk.org%2Fpatch%2F46185%2F&amp;data=02%7C01%7Crasland%40me
> llanox.
> >
> com%7Ccfacb17302174d9f4d4608d62eae9952%7Ca652971c7d2e4d9ba6a4d14
> 9256f4
> >
> 61b%7C0%7C0%7C636747724769870635&amp;sdata=ascg78Cv3PhUY1blcdUi
> QHh1mmJ
> > JZ2rD5pFUnoEzH9Q%3D&amp;reserved=0
> >
> Maybe the patch title could be better,
> 
> net/tap: allow secondary process to access primary TAP device queues
> 
> Maybe we can just have the title changed at apply time and not require a
> new patch.
> 
> Regards,
> Keith

next prev parent reply	other threads:[~2018-10-10 14:39 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-10-10  7:03 [dpdk-dev] [PATCH v5 1/3] net/tap: add queue and port ids in Rx/Tx queues structures Raslan Darawsheh
2018-10-10  7:03 ` [dpdk-dev] [PATCH v5 2/3] net/tap: move fds of Rx/Tx queues to be in process private Raslan Darawsheh
2018-10-10  7:03 ` [dpdk-dev] [PATCH v5 3/3] net/tap: add queues when attaching from secondary process Raslan Darawsheh
2018-10-10 12:47   ` Wiles, Keith
2018-10-10 14:39     ` Raslan Darawsheh [this message]
2018-10-10 12:50 ` [dpdk-dev] [PATCH v5 1/3] net/tap: add queue and port ids in Rx/Tx queues structures Wiles, Keith
2018-10-10 14:07   ` Thomas Monjalon
2018-10-10 14:40     ` Raslan Darawsheh

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=DB5PR05MB12541505136415440A349CF9C2E00@DB5PR05MB1254.eurprd05.prod.outlook.com \
    --to=rasland@mellanox.com \
    --cc=dev@dpdk.org \
    --cc=ferruh.yigit@intel.com \
    --cc=keith.wiles@intel.com \
    --cc=orika@mellanox.com \
    --cc=shahafs@mellanox.com \
    --cc=thomas@monjalon.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).