From: Ali Alnubani <alialnu@mellanox.com>
To: Bruce Richardson <bruce.richardson@intel.com>
Cc: "dev@dpdk.org" <dev@dpdk.org>, "bluca@debian.org" <bluca@debian.org>
Subject: Re: [dpdk-dev] [PATCH 2/2] examples: enable building multiprocess applications
Date: Thu, 23 May 2019 17:54:38 +0000 [thread overview]
Message-ID: <DB6PR0501MB216707149FDE25209ACEFB43D7010@DB6PR0501MB2167.eurprd05.prod.outlook.com> (raw)
In-Reply-To: <20190523153245.GA1388@bricha3-MOBL.ger.corp.intel.com>
Hi Bruce,
Comments are inline.
> -----Original Message-----
> From: Bruce Richardson <bruce.richardson@intel.com>
> Sent: Thursday, May 23, 2019 6:33 PM
> To: Ali Alnubani <alialnu@mellanox.com>
> Cc: dev@dpdk.org; bluca@debian.org
> Subject: Re: [PATCH 2/2] examples: enable building multiprocess applications
>
> On Thu, May 23, 2019 at 02:54:13PM +0000, Ali Alnubani wrote:
> > This enables building the example multiprocess applications in the
> > subdirectory multi_process.
> >
> > Signed-off-by: Ali Alnubani <alialnu@mellanox.com>
> > ---
> > examples/meson.build | 8 +++++++-
> > .../client_server_mp/mp_client/meson.build | 14 ++++++++++++++
> > .../client_server_mp/mp_server/meson.build | 14 ++++++++++++++
> > examples/multi_process/hotplug_mp/meson.build | 12 ++++++++++++
> > examples/multi_process/simple_mp/meson.build | 12 ++++++++++++
> > .../multi_process/{ => symmetric_mp}/meson.build | 8 +++++---
> > 6 files changed, 64 insertions(+), 4 deletions(-) create mode 100644
> > examples/multi_process/client_server_mp/mp_client/meson.build
> > create mode 100644
> > examples/multi_process/client_server_mp/mp_server/meson.build
> > create mode 100644 examples/multi_process/hotplug_mp/meson.build
> > create mode 100644 examples/multi_process/simple_mp/meson.build
> > rename examples/multi_process/{ => symmetric_mp}/meson.build (68%)
> >
> > diff --git a/examples/meson.build b/examples/meson.build index
> > 53a786eb4..647114c23 100644
> > --- a/examples/meson.build
> > +++ b/examples/meson.build
> > @@ -24,7 +24,7 @@ all_examples = [
> > 'l2fwd-keepalive', 'l3fwd',
> > 'l3fwd-acl', 'l3fwd-power',
> > 'l3fwd-vf', 'link_status_interrupt',
> > - 'load_balancer', 'multi_process',
> > + 'load_balancer',
> > 'netmap_compat', 'packet_ordering',
> > 'performance-thread', 'ptpclient',
> > 'qos_meter', 'qos_sched',
> > @@ -35,6 +35,12 @@ all_examples = [
> > 'vhost', 'vhost_crypto',
> > 'vhost_scsi', 'vm_power_manager',
> > 'vmdq', 'vmdq_dcb',
> > + 'multi_process/simple_mp',
> > + 'multi_process/hotplug_mp',
> > + 'multi_process/symmetric_mp',
> > + 'multi_process/client_server_mp/mp_server',
> > + 'multi_process/client_server_mp/mp_client',
> > +
> > ]
>
> Since these are in alphabetical order, I think we should keep the multi-
> process apps in the list in the correct order, rather than at the end.
Corrected in v2.
>
> > # install all example code on install - irrespective of whether the
> > example in # question is to be built as part of this build or not.
> > diff --git
> > a/examples/multi_process/client_server_mp/mp_client/meson.build
> > b/examples/multi_process/client_server_mp/mp_client/meson.build
> > new file mode 100644
> > index 000000000..196c39fc5
> > --- /dev/null
> > +++ b/examples/multi_process/client_server_mp/mp_client/meson.build
> > @@ -0,0 +1,14 @@
> > +# SPDX-License-Identifier: BSD-3-Clause # Copyright 2019 Mellanox
> > +Technologies, Ltd
> > +
> > +# meson file, for building this example as part of a main DPDK build.
> > +#
> > +# To build this example as a standalone application with an
> > +already-installed # DPDK instance, use 'make'
> > +
> > +includes += include_directories('../shared')
> > +
> > +name = 'mp_client'
>
> I believe your previous patch in this set already set up the names correctly
> for these apps, so I think you should remove this and the other name
> assignment lines in the other files. I'd like to try and enforce consistency in
> naming, and not having overrides of the name value in the individual app
> meson.build files is key to enforcing that consistency.
I left those assignments from a previous version of the patchset, my bad.
Also corrected in v2.
>
> Otherwise, thanks for doing this, and the rest of the patch looks fine to me.
>
> /Bruce
I sent a v2, but realized I forgot to tag it. Sorry.
http://patches.dpdk.org/project/dpdk/list/?series=4761
Thanks,
Ali
next prev parent reply other threads:[~2019-05-23 17:54 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-05-23 14:54 [dpdk-dev] [PATCH 1/2] examples: strip directory and use suffix as name Ali Alnubani
2019-05-23 14:54 ` [dpdk-dev] [PATCH 2/2] examples: enable building multiprocess applications Ali Alnubani
2019-05-23 15:32 ` Bruce Richardson
2019-05-23 17:54 ` Ali Alnubani [this message]
2019-05-23 17:40 ` [dpdk-dev] [PATCH 1/2] examples: strip directory and use suffix as name Ali Alnubani
2019-05-23 17:40 ` [dpdk-dev] [PATCH 2/2] examples: enable building multiprocess applications Ali Alnubani
2019-05-23 18:42 ` Luca Boccassi
2019-06-04 10:36 ` Thomas Monjalon
2019-05-23 18:42 ` [dpdk-dev] [PATCH 1/2] examples: strip directory and use suffix as name Luca Boccassi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=DB6PR0501MB216707149FDE25209ACEFB43D7010@DB6PR0501MB2167.eurprd05.prod.outlook.com \
--to=alialnu@mellanox.com \
--cc=bluca@debian.org \
--cc=bruce.richardson@intel.com \
--cc=dev@dpdk.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).