From: Wisam Monther <wisamm@mellanox.com>
To: Kevin Traynor <ktraynor@redhat.com>,
"jingjing.wu@intel.com" <jingjing.wu@intel.com>,
"wenzhuo.lu@intel.com" <wenzhuo.lu@intel.com>,
Thomas Monjalon <thomas@monjalon.net>
Cc: Raslan Darawsheh <rasland@mellanox.com>,
"dev@dpdk.org" <dev@dpdk.org>,
Shahaf Shuler <shahafs@mellanox.com>
Subject: Re: [dpdk-dev] [PATCH 1/2] app/testpmd: add custom topology command
Date: Wed, 16 May 2018 12:43:11 +0000 [thread overview]
Message-ID: <DB6PR05MB34308CD323655CE36F020E6DA9920@DB6PR05MB3430.eurprd05.prod.outlook.com> (raw)
In-Reply-To: <fa034cec-a658-064f-5c19-c6892b379f20@redhat.com>
PSB.
BRs,
Wisam Jaddo
-----Original Message-----
From: Kevin Traynor [mailto:ktraynor@redhat.com]
Sent: Wednesday, May 16, 2018 3:41 PM
To: Wisam Monther; jingjing.wu@intel.com; wenzhuo.lu@intel.com; Thomas Monjalon
Cc: Raslan Darawsheh; dev@dpdk.org; Shahaf Shuler
Subject: Re: [dpdk-dev] [PATCH 1/2] app/testpmd: add custom topology command
On 05/15/2018 03:05 PM, Wisam Monther wrote:
> Hey Kevin,
>
> What if I have 10 ports and want all 9 ports to forward packets to
> port 0, this cannot done in paired.
> But with this topo the user can overwrite the topo.
> E.g:
> - Set custom-topo 1 0
> Will make those paired and those two as active only.
>
> - set custom-topo 2 0
> Will make those two as paired, but still port one will forward packets
> to 0.
> And the active ports will be 3 ports (0,1,2) And so on...
> With this topo you can create your own topo. (Mixed between all topos
> or even non-pattern topo for any usage) In my case its needed for
> representors and virtio.
>
> Any traffic coming from representors/vhost (from VM) need to be
> forwarded from PF/phy port to the wire.
>
Thanks for sharing the use case.
Will it be an issue that multiple cores may be sending to the same TxQ?
I didn't check to see if there is locking provided in the app.
[Wisam] I've tested such case recently, and yes it will cause a seg. Fault in this solution, since multiple cores will access same queues.
I'm currently working on a fix for it, I'm planning to map single queues for each core with custom topology to avoid such scenario.
> This new topo is useful for such cases.
>
> BRs,
> Wisam jaddo
>
next prev parent reply other threads:[~2018-05-16 12:43 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-05-15 14:05 Wisam Monther
2018-05-16 12:40 ` Kevin Traynor
2018-05-16 12:43 ` Wisam Monther [this message]
-- strict thread matches above, loose matches on Subject: below --
2018-05-09 12:34 [dpdk-dev] [PATCH 0/2] app/testpmd: introduce new commands in forward topology Wisam Jaddo
2018-05-09 12:34 ` [dpdk-dev] [PATCH 1/2] app/testpmd: add custom topology command Wisam Jaddo
2018-05-15 13:15 ` Kevin Traynor
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=DB6PR05MB34308CD323655CE36F020E6DA9920@DB6PR05MB3430.eurprd05.prod.outlook.com \
--to=wisamm@mellanox.com \
--cc=dev@dpdk.org \
--cc=jingjing.wu@intel.com \
--cc=ktraynor@redhat.com \
--cc=rasland@mellanox.com \
--cc=shahafs@mellanox.com \
--cc=thomas@monjalon.net \
--cc=wenzhuo.lu@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).