From: Shahaf Shuler <shahafs@mellanox.com>
To: Adrien Mazarguil <adrien.mazarguil@6wind.com>
Cc: "Nélio Laranjeiro" <nelio.laranjeiro@6wind.com>,
"Yongseok Koh" <yskoh@mellanox.com>,
"dev@dpdk.org" <dev@dpdk.org>,
"Guillaume Gaudonville" <guillaume.gaudonville@6wind.com>,
"Raslan Darawsheh" <rasland@mellanox.com>,
"Wael Abualrub" <waela@mellanox.com>
Subject: Re: [dpdk-dev] [PATCH v2 0/6] net/mlx5: add support for switch flow rules
Date: Sun, 22 Jul 2018 11:21:17 +0000 [thread overview]
Message-ID: <DB7PR05MB442601E2D3C64946E62506A6C3570@DB7PR05MB4426.eurprd05.prod.outlook.com> (raw)
In-Reply-To: <20180713092910.26276-1-adrien.mazarguil@6wind.com>
Hi Adrien,
Friday, July 13, 2018 12:41 PM, Adrien Mazarguil:
> Subject: [PATCH v2 0/6] net/mlx5: add support for switch flow rules
>
> This series adds support for switch flow rules, that is, rte_flow rules applied
> to mlx5 devices at the switch level.
>
> It allows applications to offload traffic redirection between DPDK ports in
> hardware, while optionally modifying it (e.g. performing encap/decap).
>
> For this to work, involved DPDK ports must be part of the same switch
> domain, as is the case with port representors, and the transfer attribute
> must be requested on flow rules.
>
> Also since the mlx5 switch is controlled through Netlink instead of Verbs, and
> given how tedious formatting Netlink messages is, a new dependency is
> added to mlx5: libmnl. See relevant patch.
There are some checkpatch[1] warning, but those are safe to ignore.
Adrien, one thing which is missing is a documentation update for mlx5 doc on the new dependency of libmnl.
Just like rdma-core: how to get it, how to install it, version required..
I won't postpone the series acceptance due to this (since I want to avoid big changes after the rc2), but we must have such doc before 18.08 release.
Series applied to next-net-mlx, thanks!
[1]
### net/mlx5: add framework for switch flow rules
ERROR:COMPLEX_MACRO: Macros with complex values should be enclosed in parentheses
#307: FILE: drivers/net/mlx5/mlx5_nl_flow.c:60:
+#define PATTERN_COMMON \
+ ITEM_VOID, ACTIONS
ERROR:COMPLEX_MACRO: Macros with complex values should be enclosed in parentheses
#309: FILE: drivers/net/mlx5/mlx5_nl_flow.c:62:
+#define ACTIONS_COMMON \
+ ACTION_VOID, END
total: 2 errors, 0 warnings, 0 checks, 537 lines checked
### net/mlx5: add fate actions to switch flow rules
ERROR:COMPLEX_MACRO: Macros with complex values should be enclosed in parentheses
#55: FILE: drivers/net/mlx5/mlx5_nl_flow.c:68:
+#define ACTIONS_FATE \
+ ACTION_PORT_ID, ACTION_DROP
ERROR:ASSIGN_IN_IF: do not use assignment in if condition
#136: FILE: drivers/net/mlx5/mlx5_nl_flow.c:277:
+ if (!mnl_attr_put_check(buf, size, TCA_MIRRED_PARMS,
ERROR:ASSIGN_IN_IF: do not use assignment in if condition
#159: FILE: drivers/net/mlx5/mlx5_nl_flow.c:300:
+ if (!mnl_attr_put_check(buf, size, TCA_GACT_PARMS,
total: 3 errors, 0 warnings, 0 checks, 134 lines checked
### net/mlx5: add VLAN item and actions to switch flow rules
ERROR:ASSIGN_IN_IF: do not use assignment in if condition
#367: FILE: drivers/net/mlx5/mlx5_nl_flow.c:930:
+ if (!mnl_attr_put_check(buf, size, TCA_VLAN_PARMS,
total: 1 errors, 0 warnings, 0 checks, 358 lines checked
>
> v2 changes:
>
> - Mostly compilation fixes for missing Netlink definitions on older systems.
> - Reduced stack consumption.
> - Adapted series to rely on mlx5_dev_to_port_id() instead of
> mlx5_dev_to_domain_id().
> - See relevant patches for more information.
>
> Adrien Mazarguil (6):
> net/mlx5: lay groundwork for switch offloads
> net/mlx5: add framework for switch flow rules
> net/mlx5: add fate actions to switch flow rules
> net/mlx5: add L2-L4 pattern items to switch flow rules
> net/mlx5: add VLAN item and actions to switch flow rules
> net/mlx5: add port ID pattern item to switch flow rules
>
> drivers/net/mlx5/Makefile | 142 ++++
> drivers/net/mlx5/mlx5.c | 32 +
> drivers/net/mlx5/mlx5.h | 28 +
> drivers/net/mlx5/mlx5_flow.c | 111 +++
> drivers/net/mlx5/mlx5_nl_flow.c | 1247
> ++++++++++++++++++++++++++++++++++
> mk/rte.app.mk | 2 +-
> 6 files changed, 1561 insertions(+), 1 deletion(-) create mode 100644
> drivers/net/mlx5/mlx5_nl_flow.c
>
> --
> 2.11.0
prev parent reply other threads:[~2018-07-22 11:21 UTC|newest]
Thread overview: 33+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-06-27 18:08 [dpdk-dev] [PATCH " Adrien Mazarguil
2018-06-27 18:08 ` [dpdk-dev] [PATCH 1/6] net/mlx5: lay groundwork for switch offloads Adrien Mazarguil
2018-07-12 0:17 ` Yongseok Koh
2018-07-12 10:46 ` Adrien Mazarguil
2018-07-12 17:33 ` Yongseok Koh
2018-06-27 18:08 ` [dpdk-dev] [PATCH 2/6] net/mlx5: add framework for switch flow rules Adrien Mazarguil
2018-07-12 0:59 ` Yongseok Koh
2018-07-12 10:46 ` Adrien Mazarguil
2018-07-12 18:25 ` Yongseok Koh
2018-06-27 18:08 ` [dpdk-dev] [PATCH 3/6] net/mlx5: add fate actions to " Adrien Mazarguil
2018-07-12 1:00 ` Yongseok Koh
2018-06-27 18:08 ` [dpdk-dev] [PATCH 4/6] net/mlx5: add L2-L4 pattern items " Adrien Mazarguil
2018-07-12 1:02 ` Yongseok Koh
2018-06-27 18:08 ` [dpdk-dev] [PATCH 5/6] net/mlx5: add VLAN item and actions " Adrien Mazarguil
2018-07-12 1:10 ` Yongseok Koh
2018-07-12 10:47 ` Adrien Mazarguil
2018-07-12 18:49 ` Yongseok Koh
2018-06-27 18:08 ` [dpdk-dev] [PATCH 6/6] net/mlx5: add port ID pattern item " Adrien Mazarguil
2018-07-12 1:13 ` Yongseok Koh
2018-06-28 9:05 ` [dpdk-dev] [PATCH 0/6] net/mlx5: add support for " Nélio Laranjeiro
2018-07-13 9:40 ` [dpdk-dev] [PATCH v2 " Adrien Mazarguil
2018-07-13 9:40 ` [dpdk-dev] [PATCH v2 1/6] net/mlx5: lay groundwork for switch offloads Adrien Mazarguil
2018-07-14 1:29 ` Yongseok Koh
2018-07-23 21:40 ` Ferruh Yigit
2018-07-24 0:50 ` Stephen Hemminger
2018-07-24 4:35 ` Shahaf Shuler
2018-07-24 19:33 ` Stephen Hemminger
2018-07-13 9:40 ` [dpdk-dev] [PATCH v2 2/6] net/mlx5: add framework for switch flow rules Adrien Mazarguil
2018-07-13 9:40 ` [dpdk-dev] [PATCH v2 3/6] net/mlx5: add fate actions to " Adrien Mazarguil
2018-07-13 9:40 ` [dpdk-dev] [PATCH v2 4/6] net/mlx5: add L2-L4 pattern items " Adrien Mazarguil
2018-07-13 9:40 ` [dpdk-dev] [PATCH v2 5/6] net/mlx5: add VLAN item and actions " Adrien Mazarguil
2018-07-13 9:40 ` [dpdk-dev] [PATCH v2 6/6] net/mlx5: add port ID pattern item " Adrien Mazarguil
2018-07-22 11:21 ` Shahaf Shuler [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=DB7PR05MB442601E2D3C64946E62506A6C3570@DB7PR05MB4426.eurprd05.prod.outlook.com \
--to=shahafs@mellanox.com \
--cc=adrien.mazarguil@6wind.com \
--cc=dev@dpdk.org \
--cc=guillaume.gaudonville@6wind.com \
--cc=nelio.laranjeiro@6wind.com \
--cc=rasland@mellanox.com \
--cc=waela@mellanox.com \
--cc=yskoh@mellanox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).