From: Shahaf Shuler <shahafs@mellanox.com>
To: Adrien Mazarguil <adrien.mazarguil@6wind.com>,
Mordechay Haimovsky <motih@mellanox.com>
Cc: "dev@dpdk.org" <dev@dpdk.org>,
"Nélio Laranjeiro" <nelio.laranjeiro@6wind.com>
Subject: Re: [dpdk-dev] [PATCH v2] net/mlx5: fix RSS flow configuration crash
Date: Thu, 2 Aug 2018 11:20:32 +0000 [thread overview]
Message-ID: <DB7PR05MB4426053198D00F27E7F7A3C9C32C0@DB7PR05MB4426.eurprd05.prod.outlook.com> (raw)
In-Reply-To: <20180802111833.GL5211@6wind.com>
Thursday, August 2, 2018 2:19 PM, Adrien Mazarguil:
> Subject: Re: [PATCH v2] net/mlx5: fix RSS flow configuration crash
>
> On Thu, Aug 02, 2018 at 11:41:07AM +0300, Moti Haimovsky wrote:
> > This commit fixes a segmentation fault observed when configuring
> > mlx5 with RSS flow rule containing invalid queues indices such as
> > negative numbers, queue numbers bigger than the number Rx queues the
> > PMD or has no queues at all.
> >
> > Fixes: 592f05b29a25 ("net/mlx5: add RSS flow action")
> > Cc: nelio.laranjeiro@6wind.com
> >
> > Signed-off-by: Moti Haimovsky <motih@mellanox.com>
> > ---
> > v2:
> > * Modifications according to review by Adrien Mazarguil.
> > in reply to 1533130807-9183-1-git-send-email-motih@mellanox.com
>
> Almost, there is one new occurrence with the same issue, see below.
>
> By the way, like for "types" and "level" fields, a zero value in "queue_num"
> could be interpreted as default in order to target all configured queues, for
> the convenience of applications that do not care.
>
> This is not explicitly documented so it's just a recommendation though.
>
> > v1:
> > * Added check for zero queues.
> > ---
> > drivers/net/mlx5/mlx5_flow.c | 11 +++++++++++
> > 1 file changed, 11 insertions(+)
> >
> > diff --git a/drivers/net/mlx5/mlx5_flow.c
> > b/drivers/net/mlx5/mlx5_flow.c index 6c3021a..5576044 100644
> > --- a/drivers/net/mlx5/mlx5_flow.c
> > +++ b/drivers/net/mlx5/mlx5_flow.c
> > @@ -2065,6 +2065,11 @@ struct mlx5_flow_tunnel_info {
> >
> RTE_FLOW_ERROR_TYPE_ACTION_CONF,
> > &rss->key_len,
> > "RSS hash key too large");
> > + if (!rss->queue_num)
> > + return rte_flow_error_set(error, ENOTSUP,
> > +
> RTE_FLOW_ERROR_TYPE_ACTION_CONF,
> > + &rss->queue_num,
Will fix locally. No need for new version.
>
> Here ^^
>
> > + "no queues were provided for
> RSS");
> > if (rss->queue_num > priv->config.ind_table_max_size)
> > return rte_flow_error_set(error, ENOTSUP,
> >
> RTE_FLOW_ERROR_TYPE_ACTION_CONF, @@ -2077,6 +2082,12 @@ struct
> > mlx5_flow_tunnel_info {
> > "some RSS protocols are not"
> > " supported");
> > for (i = 0; i != rss->queue_num; ++i) {
> > + if (rss->queue[i] >= priv->rxqs_n)
> > + return rte_flow_error_set
> > + (error, EINVAL,
> > + RTE_FLOW_ERROR_TYPE_ACTION_CONF,
> > + rss,
> > + "queue index out of range");
> > if (!(*priv->rxqs)[rss->queue[i]])
> > return rte_flow_error_set
> > (error, EINVAL,
> > --
> > 1.8.3.1
> >
>
> --
> Adrien Mazarguil
> 6WIND
prev parent reply other threads:[~2018-08-02 11:20 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-08-01 10:43 [dpdk-dev] [PATCH] " Moti Haimovsky
2018-08-01 11:01 ` Adrien Mazarguil
2018-08-01 13:40 ` [dpdk-dev] [PATCH v1] " Moti Haimovsky
2018-08-01 14:13 ` Adrien Mazarguil
2018-08-02 8:41 ` [dpdk-dev] [PATCH v2] " Moti Haimovsky
2018-08-02 11:17 ` Shahaf Shuler
2018-08-02 11:18 ` Adrien Mazarguil
2018-08-02 11:20 ` Shahaf Shuler [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=DB7PR05MB4426053198D00F27E7F7A3C9C32C0@DB7PR05MB4426.eurprd05.prod.outlook.com \
--to=shahafs@mellanox.com \
--cc=adrien.mazarguil@6wind.com \
--cc=dev@dpdk.org \
--cc=motih@mellanox.com \
--cc=nelio.laranjeiro@6wind.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).