From: Shahaf Shuler <shahafs@mellanox.com>
To: Adrien Mazarguil <adrien.mazarguil@6wind.com>
Cc: Ferruh Yigit <ferruh.yigit@intel.com>,
"dev@dpdk.org" <dev@dpdk.org>,
"stable@dpdk.org" <stable@dpdk.org>
Subject: Re: [dpdk-stable] [PATCH v2 1/3] net/mlx4: fix Rx resource leak in case of error
Date: Sun, 29 Apr 2018 06:02:02 +0000 [thread overview]
Message-ID: <DB7PR05MB44261C9953E846BD28C9CE03C3830@DB7PR05MB4426.eurprd05.prod.outlook.com> (raw)
In-Reply-To: <20180426162142.6617-1-adrien.mazarguil@6wind.com>
Thursday, April 26, 2018 7:26 PM, Adrien Mazarguil:
> Subject: [PATCH v2 1/3] net/mlx4: fix Rx resource leak in case of error
>
> When creation of a flow rule fails during dev_start(), the usage count of the
> common RSS context is not decremented, which triggers an assertion failure
> in debug mode during dev_close().
>
> This is addressed by tracking the initialization status of the common RSS
> context in order to add missing cleanup code.
>
> A similar issue exists in mlx4_rxq_attach(), where usage count is
> incremented on a Rx queue but not released in case of error. This may lead
> to the above issue since RSS contexts created by flow rules attach
> themselves to Rx queues, incrementing their usage count.
>
> Fixes: 5697a4142107 ("net/mlx4: relax Rx queue configuration order")
> Cc: stable@dpdk.org
>
> Signed-off-by: Adrien Mazarguil <adrien.mazarguil@6wind.com>
Series applied to next-net-mlx, thanks.
prev parent reply other threads:[~2018-04-29 6:02 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-04-25 15:40 [dpdk-stable] [PATCH v1] " Adrien Mazarguil
2018-04-26 16:26 ` [dpdk-stable] [PATCH v2 1/3] " Adrien Mazarguil
2018-04-26 16:26 ` [dpdk-stable] [PATCH v2 2/3] net/mlx4: fix default RSS hash fields Adrien Mazarguil
2018-04-26 16:26 ` [dpdk-stable] [PATCH v2 3/3] net/mlx4: fix inner RSS support for broken kernels Adrien Mazarguil
2018-04-29 6:02 ` Shahaf Shuler [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=DB7PR05MB44261C9953E846BD28C9CE03C3830@DB7PR05MB4426.eurprd05.prod.outlook.com \
--to=shahafs@mellanox.com \
--cc=adrien.mazarguil@6wind.com \
--cc=dev@dpdk.org \
--cc=ferruh.yigit@intel.com \
--cc=stable@dpdk.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).