From: Shahaf Shuler <shahafs@mellanox.com>
To: Adrien Mazarguil <adrien.mazarguil@6wind.com>
Cc: "Yongseok Koh" <yskoh@mellanox.com>,
"dev@dpdk.org" <dev@dpdk.org>,
"Yaroslav Brustinov" <ybrustin@cisco.com>,
"stable@dpdk.org" <stable@dpdk.org>,
"Nélio Laranjeiro" <nelio.laranjeiro@6wind.com>
Subject: Re: [dpdk-stable] [PATCH v2] net/mlx5: fix linkage error for glue lib
Date: Thu, 26 Jul 2018 05:44:51 +0000 [thread overview]
Message-ID: <DB7PR05MB44266E9EF029263AA0831A2EC32B0@DB7PR05MB4426.eurprd05.prod.outlook.com> (raw)
In-Reply-To: <20180725132252.GX5211@6wind.com>
Wednesday, July 25, 2018 4:23 PM, Adrien Mazarguil:
> Subject: Re: [PATCH v2] net/mlx5: fix linkage error for glue lib
>
> On Wed, Jul 25, 2018 at 04:18:54PM +0300, Shahaf Shuler wrote:
> > From: Yaroslav Brustinov <ybrustin@cisco.com>
> >
> > addressing a gcc 4.7.2 bug that cannot be reproduced with latter
> > versions:
> >
> > "bin/ld: Warning: alignment 8 of symbol `mlx5_glue' in
> > src/dpdk/drivers/net/mlx5/mlx5_glue.c.21.o is smaller than 16 in
> > src/dpdk/drivers/net/mlx5/mlx5_rxq.c.21.o"
> >
> > Fix it be forcing the alignment of the glue lib.
> >
> > Fixes: 0e83b8e536c1 ("net/mlx5: move rdma-core calls to separate
> > file")
> > Cc: stable@dpdk.org
> > Cc: nelio.laranjeiro@6wind.com
> > Cc: adrien.mazarguil@6wind.com
> >
> > Signed-off-by: Yaroslav Brustinov <ybrustin@cisco.com>
> > Signed-off-by: Shahaf Shuler <shahafs@mellanox.com>
>
> Except for a couple of minor nits below,
>
> Acked-by: Adrien Mazarguil <adrien.mazarguil@6wind.com>
Applied to next-net-mlx with the needed fixes. Thanks.
prev parent reply other threads:[~2018-07-26 5:44 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-07-24 8:54 [dpdk-stable] [PATCH] " Shahaf Shuler
2018-07-24 12:00 ` Adrien Mazarguil
2018-07-24 12:05 ` Adrien Mazarguil
2018-07-24 13:51 ` Shahaf Shuler
2018-07-24 14:24 ` Yaroslav Brustinov (ybrustin)
2018-07-24 16:03 ` Adrien Mazarguil
2018-07-25 7:38 ` Yaroslav Brustinov (ybrustin)
2018-07-25 9:24 ` Adrien Mazarguil
2018-07-25 10:02 ` Yaroslav Brustinov (ybrustin)
2018-07-25 13:18 ` [dpdk-stable] [PATCH v2] " Shahaf Shuler
2018-07-25 13:22 ` Adrien Mazarguil
2018-07-26 5:44 ` Shahaf Shuler [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=DB7PR05MB44266E9EF029263AA0831A2EC32B0@DB7PR05MB4426.eurprd05.prod.outlook.com \
--to=shahafs@mellanox.com \
--cc=adrien.mazarguil@6wind.com \
--cc=dev@dpdk.org \
--cc=nelio.laranjeiro@6wind.com \
--cc=stable@dpdk.org \
--cc=ybrustin@cisco.com \
--cc=yskoh@mellanox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).