From: Shahaf Shuler <shahafs@mellanox.com>
To: "Xueming(Steven) Li" <xuemingl@mellanox.com>,
"Nélio Laranjeiro" <nelio.laranjeiro@6wind.com>,
"Adrien Mazarguil" <adrien.mazarguil@6wind.com>,
"Yongseok Koh" <yskoh@mellanox.com>
Cc: "dev@dpdk.org" <dev@dpdk.org>
Subject: Re: [dpdk-dev] [PATCH] net/mlx5: fix compilation without tunnel RSS support
Date: Mon, 14 May 2018 06:00:19 +0000 [thread overview]
Message-ID: <DB7PR05MB44266FCFD17E6151593B7081C39C0@DB7PR05MB4426.eurprd05.prod.outlook.com> (raw)
In-Reply-To: <VI1PR05MB16789F76743FAEB1EBDA9B95AC9D0@VI1PR05MB1678.eurprd05.prod.outlook.com>
Sunday, May 13, 2018 4:28 PM, Xueming(Steven) Li:
> Thanks for fixing this, one minor issue below.
>
> > -----Original Message-----
> > From: Shahaf Shuler <shahafs@mellanox.com>
> > Sent: Sunday, May 13, 2018 4:08 PM
> > To: Nélio Laranjeiro <nelio.laranjeiro@6wind.com>; Adrien Mazarguil
> > <adrien.mazarguil@6wind.com>; Yongseok Koh <yskoh@mellanox.com>
> > Cc: dev@dpdk.org; Xueming(Steven) Li <xuemingl@mellanox.com>
> > Subject: [PATCH] net/mlx5: fix compilation without tunnel RSS support
> >
> > IBV_RX_HASH_INNER should be referenced only when having tunnel
> support in the Verbs headers.
> >
> > Fixes: 80f2d0ed7ff9 ("net/mlx5: add hardware flow debug dump")
> > Cc: xuemingl@mellanox.com
> >
> > Signed-off-by: Shahaf Shuler <shahafs@mellanox.com>
> > ---
> > drivers/net/mlx5/mlx5_flow.c | 9 ++++++---
> > 1 file changed, 6 insertions(+), 3 deletions(-)
> >
> > diff --git a/drivers/net/mlx5/mlx5_flow.c
> > b/drivers/net/mlx5/mlx5_flow.c index ec6d00f21b..04ace3ee79
> > 100644
> > --- a/drivers/net/mlx5/mlx5_flow.c
> > +++ b/drivers/net/mlx5/mlx5_flow.c
> > @@ -2188,7 +2188,12 @@ mlx5_flow_dump(struct rte_eth_dev *dev
> __rte_unused,
> > uint16_t j;
> > char buf[256];
> > uint8_t off;
> > + uint64_t extra_hash_fields = 0;
> >
> > +#ifdef HAVE_IBV_DEVICE_TUNNEL_SUPPORT
> > + if (flow->tunnel && flow->rss_conf.level > 1)
> > + extra_hash_fields = (uint32_t)IBV_RX_HASH_INNER; #endif
>
> Should "#endif" start with a new line?
It is in new line. You probably see it wrongly in outlook.
Have a look on the patch in patchwork:
http://dpdk.org/dev/patchwork/patch/39927/
next prev parent reply other threads:[~2018-05-14 6:00 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-05-13 8:07 Shahaf Shuler
2018-05-13 13:27 ` Xueming(Steven) Li
2018-05-14 6:00 ` Shahaf Shuler [this message]
2018-05-15 12:30 ` Shahaf Shuler
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=DB7PR05MB44266FCFD17E6151593B7081C39C0@DB7PR05MB4426.eurprd05.prod.outlook.com \
--to=shahafs@mellanox.com \
--cc=adrien.mazarguil@6wind.com \
--cc=dev@dpdk.org \
--cc=nelio.laranjeiro@6wind.com \
--cc=xuemingl@mellanox.com \
--cc=yskoh@mellanox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).