From: Shahaf Shuler <shahafs@mellanox.com>
To: Shahaf Shuler <shahafs@mellanox.com>, Yongseok Koh <yskoh@mellanox.com>
Cc: "dev@dpdk.org" <dev@dpdk.org>, "Ori Kam" <orika@mellanox.com>,
"Nélio Laranjeiro" <nelio.laranjeiro@6wind.com>
Subject: Re: [dpdk-dev] [PATCH] net/mlx5: fix VLAN filtering
Date: Thu, 2 Aug 2018 10:35:28 +0000 [thread overview]
Message-ID: <DB7PR05MB44268679D1C21B0AFF861A4FC32C0@DB7PR05MB4426.eurprd05.prod.outlook.com> (raw)
In-Reply-To: <20180731075720.112272-1-shahafs@mellanox.com>
Tuesday, July 31, 2018 10:57 AM, Shahaf Shuler:
> Subject: [dpdk-dev] [PATCH] net/mlx5: fix VLAN filtering
>
> The below commit has added a graph based expansion logic for RSS rule to
> satisfy Verbs requirements. With this logic, for example, the rule:
>
> flow create 0 ingress pattern eth / end actions rss queues 0 1 end types ipv4-
> tcp ipv6-tcp end / end
>
> will be expanded into the rules:
>
> flow create 0 ingress pattern eth / ipv4 / tcp / end actions rss queues 0 1 end
> types ipv4-tcp ipv6-tcp end / end
>
> flow create 0 ingress pattern eth / ipv6 / tcp / end actions rss queues 0 1 end
> types ipv4-tcp ipv6-tcp end / end
>
> flow create 0 ingress pattern eth / end actions queue index 0 / end
>
> The below commit defined two graphs:
> 1. graph for the tunnel case which starts from the ETH item 2. graph for the
> non-tunnel case which starts from the ETH item
>
> The graphs are ignoring the VLAN case. Hence rules with VLAN item will fail to
> traverse the graph and it will result in flow rule creation error.
>
> Adding the VLAN item to the existing graphs will not work as the flow engine
> will reject any VLAN item without a specific vid.
>
> To solve this case two new graphs were added (for the tunnel and non-
> tunnel case) which contain the VLAN item and are being used only when the
> VLAN item exists in the flow pattern.
>
> Two cases left un-covered for the inner RSS:
> 1. The case were VLAN exists in the pattern as part of the inner headers 2.
> The case were VLAN exists in the pattern both in the outer and the inner
> headers
>
> Solving those cases will require to add two more graphs.
> Holding a VLAN for the overlay network is not common, the subnets are
> usually defined by the tunnel protocol, for example the VXLAN vni.
> Hence adding those two graphs seems like an overkill at this point.
> Based on needs one can add those to provide the full support.
>
> Fixes: 592f05b29a25 ("net/mlx5: add RSS flow action")
> Cc: nelio.laranjeiro@6wind.com
>
> Signed-off-by: Shahaf Shuler <shahafs@mellanox.com>
Applied to next-net-mlx, thanks.
prev parent reply other threads:[~2018-08-02 10:35 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-07-31 7:57 Shahaf Shuler
2018-08-02 10:35 ` Shahaf Shuler [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=DB7PR05MB44268679D1C21B0AFF861A4FC32C0@DB7PR05MB4426.eurprd05.prod.outlook.com \
--to=shahafs@mellanox.com \
--cc=dev@dpdk.org \
--cc=nelio.laranjeiro@6wind.com \
--cc=orika@mellanox.com \
--cc=yskoh@mellanox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).