DPDK patches and discussions
 help / color / mirror / Atom feed
From: Shahaf Shuler <shahafs@mellanox.com>
To: Ferruh Yigit <ferruh.yigit@intel.com>,
	Neil Horman <nhorman@tuxdriver.com>,
	John McNamara <john.mcnamara@intel.com>,
	"Marko Kovacevic" <marko.kovacevic@intel.com>
Cc: "dev@dpdk.org" <dev@dpdk.org>, Thomas Monjalon <thomas@monjalon.net>
Subject: Re: [dpdk-dev] [PATCH v4] doc: announce ethdev CRC strip flag deprecation
Date: Tue, 17 Apr 2018 13:47:26 +0000	[thread overview]
Message-ID: <DB7PR05MB4426885D244CAD8E5F0E359EC3B70@DB7PR05MB4426.eurprd05.prod.outlook.com> (raw)
In-Reply-To: <20180417133949.32883-1-ferruh.yigit@intel.com>

Tuesday, April 17, 2018 4:40 PM, Ferruh Yigit:
> Subject: [PATCH v4] doc: announce ethdev CRC strip flag deprecation
> 
> Make CRC stripping default behavior, deprecate flag
> DEV_RX_OFFLOAD_CRC_STRIP.
> 
> Signed-off-by: Ferruh Yigit <ferruh.yigit@intel.com>
> Acked-by: Andrew Rybchenko <arybchenko@solarflare.com>
> ---
> v2:
> * Make CRC behavior active in this release
> 
> v3:
> * Distribute switch into next two releases for more smooth transition
>   v18.08: add new flag to keep crc, and implement this in PMDs
>   v18.11: remove crc strip flag and make default behavior to strip crc
> 
> v4:
> * Remove git artifact
> ---
>  doc/guides/rel_notes/deprecation.rst | 16 ++++++++++++++++
>  1 file changed, 16 insertions(+)
> 
> diff --git a/doc/guides/rel_notes/deprecation.rst
> b/doc/guides/rel_notes/deprecation.rst
> index fd9def20c..dbc405450 100644
> --- a/doc/guides/rel_notes/deprecation.rst
> +++ b/doc/guides/rel_notes/deprecation.rst
> @@ -100,6 +100,22 @@ Deprecation Notices
>    between the VF representor and the VF or the parent PF. Those new fields
>    are to be included in ``rte_eth_dev_info`` struct.
> 
> +* ethdev: A new offloading flag ``DEV_RX_OFFLOAD_KEEP_CRC`` will be
> +added in v18.08,
> +  This will replace the usage of not setting
> +``DEV_RX_OFFLOAD_CRC_STRIP`` flag
> +  and will be implemented in PMDs accordingly.
> +  In v18.08 both ``DEV_RX_OFFLOAD_KEEP_CRC`` and
> +``DEV_RX_OFFLOAD_CRC_STRIP`` flags
> +  will be available, usage will be:
> +  ``CRC_STRIP``: Strip CRC from packet
> +  ``KEEP_CRC``: Keep CRC in packet
> +  Both ``CRC_STRIP`` & ``KEEP_CRC``: Invalid
> +  No flag: Keep CRC in packet
> +
> +* ethdev: In v18.11 ``DEV_RX_OFFLOAD_CRC_STRIP`` offload flag will be
> +removed, default
> +  behavior without any flag will be changed to CRC strip.
> +  To keep CRC ``DEV_RX_OFFLOAD_KEEP_CRC`` flag is required.
> +  ``KEEP_CRC``: Keep CRC in packet
> +  No flag: Strip CRC from packet
> +
>  * i40e: The default flexible payload configuration which extracts the first 16
>    bytes of the payload for RSS will be deprecated starting from 18.02. If
>    required the previous behavior can be configured using existing flow
> --
> 2.14.3

Acked-by: Shahaf Shuler <shahafs@mellanox.com>

  reply	other threads:[~2018-04-17 13:47 UTC|newest]

Thread overview: 21+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-03-20 11:26 [dpdk-dev] [PATCH] " Ferruh Yigit
2018-03-20 11:35 ` Thomas Monjalon
2018-03-20 17:23   ` Ferruh Yigit
2018-03-21 19:47 ` [dpdk-dev] [PATCH v2 1/2] " Ferruh Yigit
2018-03-21 19:47   ` [dpdk-dev] [PATCH v2 2/2] ethdev: add new offload flag to keep CRC Ferruh Yigit
2018-03-21 21:05     ` Thomas Monjalon
2018-03-29  5:38     ` Shahaf Shuler
2018-03-29  7:43       ` Thomas Monjalon
2018-03-29  7:56         ` Shahaf Shuler
2018-03-29 13:32           ` Ferruh Yigit
2018-04-01  7:10             ` Shahaf Shuler
2018-04-16 17:23               ` Ferruh Yigit
2018-04-16 22:13                 ` Thomas Monjalon
2018-04-17 13:12   ` [dpdk-dev] [PATCH v3] doc: announce ethdev CRC strip flag deprecation Ferruh Yigit
2018-04-17 13:31     ` Andrew Rybchenko
2018-04-17 13:36     ` Ferruh Yigit
2018-04-17 13:39     ` [dpdk-dev] [PATCH v4] " Ferruh Yigit
2018-04-17 13:47       ` Shahaf Shuler [this message]
2018-05-28  1:05         ` Thomas Monjalon
2018-08-01 15:27       ` Maxime Coquelin
2018-08-02  8:50         ` Shahaf Shuler

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=DB7PR05MB4426885D244CAD8E5F0E359EC3B70@DB7PR05MB4426.eurprd05.prod.outlook.com \
    --to=shahafs@mellanox.com \
    --cc=dev@dpdk.org \
    --cc=ferruh.yigit@intel.com \
    --cc=john.mcnamara@intel.com \
    --cc=marko.kovacevic@intel.com \
    --cc=nhorman@tuxdriver.com \
    --cc=thomas@monjalon.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).