From: Shahaf Shuler <shahafs@mellanox.com>
To: Andrew Rybchenko <arybchenko@solarflare.com>,
"dev@dpdk.org" <dev@dpdk.org>
Cc: Ferruh Yigit <ferruh.yigit@intel.com>,
Thomas Monjalon <thomas@monjalon.net>,
Wei Dai <wei.dai@intel.com>
Subject: Re: [dpdk-dev] [PATCH v2 0/3] ethdev: fail if requested offload is not supported
Date: Mon, 14 May 2018 07:51:28 +0000 [thread overview]
Message-ID: <DB7PR05MB44269E4EBE8A350E70F0B458C39C0@DB7PR05MB4426.eurprd05.prod.outlook.com> (raw)
In-Reply-To: <1526283378-30507-1-git-send-email-arybchenko@solarflare.com>
Monday, May 14, 2018 10:36 AM, Andrew Rybchenko:
> Subject: [PATCH v2 0/3] ethdev: fail if requested offload is not supported
>
> The series has fixes for problems discussed in [1].
>
> Basically it does not allow unsupported offloads to pass.
>
> If fixes regressions for PMDs which carefully check offloads before, but these
> checks are removed now in favor of checks in ethdev.
>
> It may break applications which request some offload which is not supported
> by underlying PMD, but does not actually used.
>
> Depending on discussion results it should be either dropped or applied.
>
> [1]
> https://emea01.safelinks.protection.outlook.com/?url=http%3A%2F%2Fdpd
> k.org%2Fml%2Farchives%2Fdev%2F2018-
> May%2F101261.html&data=02%7C01%7Cshahafs%40mellanox.com%7C9a572
> e9d86b04c99854c08d5b96d75b5%7Ca652971c7d2e4d9ba6a4d149256f461b%7
> C0%7C0%7C636618802134607945&sdata=fQKCr%2FrFvakWVIFomy8iSD%2Bc
> VtSie8mvgx63Qqgq690%3D&reserved=0
>
> v1 -> v2:
> - use IGNORE flag to separate old and new offload API cases on
> Tx queue setup and avoid expected errors if old API is used
> as suggested by Shahaf
> - remove convertion of rxmode bits on Rx queue setup since exactly
> these bits are removed
>
> Andrew Rybchenko (3):
> ethdev: fail configure if requested offload is not supported
> ethdev: fail if Tx queue offload is not supported
> ethdev: fail if Rx queue offload is not supported
>
> lib/librte_ethdev/rte_ethdev.c | 62 +++++++++++++++++++---------------
> 1 file changed, 35 insertions(+), 27 deletions(-)
For the series -
Acked-by: Shahaf Shuler <shahafs@mellanox.com>
>
> --
> 2.17.0
next prev parent reply other threads:[~2018-05-14 7:51 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-05-11 16:25 [dpdk-dev] [PATCH " Andrew Rybchenko
2018-05-11 16:25 ` [dpdk-dev] [PATCH 1/3] ethdev: fail configure " Andrew Rybchenko
2018-05-11 16:25 ` [dpdk-dev] [PATCH 2/3] ethdev: fail if Tx queue offload is not supported at all Andrew Rybchenko
2018-05-13 5:37 ` Shahaf Shuler
2018-05-13 13:30 ` Shahaf Shuler
2018-05-14 6:54 ` Andrew Rybchenko
2018-05-11 16:25 ` [dpdk-dev] [PATCH 3/3] ethdev: fail if Rx queue offload is not supported Andrew Rybchenko
2018-05-14 7:36 ` [dpdk-dev] [PATCH v2 0/3] ethdev: fail if requested " Andrew Rybchenko
2018-05-14 7:36 ` [dpdk-dev] [PATCH v2 1/3] ethdev: fail configure " Andrew Rybchenko
2018-05-14 7:36 ` [dpdk-dev] [PATCH v2 2/3] ethdev: fail if Tx queue " Andrew Rybchenko
2018-05-14 7:36 ` [dpdk-dev] [PATCH v2 3/3] ethdev: fail if Rx " Andrew Rybchenko
2018-05-14 7:51 ` Shahaf Shuler [this message]
2018-05-14 14:48 ` [dpdk-dev] [PATCH v2 0/3] ethdev: fail if requested " Ferruh Yigit
2018-06-18 8:43 ` Ferruh Yigit
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=DB7PR05MB44269E4EBE8A350E70F0B458C39C0@DB7PR05MB4426.eurprd05.prod.outlook.com \
--to=shahafs@mellanox.com \
--cc=arybchenko@solarflare.com \
--cc=dev@dpdk.org \
--cc=ferruh.yigit@intel.com \
--cc=thomas@monjalon.net \
--cc=wei.dai@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).