From: Shahaf Shuler <shahafs@mellanox.com>
To: Luca Boccassi <bluca@debian.org>,
Timothy Redaelli <tredaelli@redhat.com>,
Matan Azrad <matan@mellanox.com>
Cc: "dev@dpdk.org" <dev@dpdk.org>,
Adrien Mazarguil <adrien.mazarguil@6wind.com>
Subject: Re: [dpdk-dev] [PATCH] net/mlx4: Avoid stripping the glue library
Date: Wed, 1 Aug 2018 08:30:12 +0000 [thread overview]
Message-ID: <DB7PR05MB4426B3C7896DEE2CEE1CB107C32D0@DB7PR05MB4426.eurprd05.prod.outlook.com> (raw)
In-Reply-To: <1533043842.20916.48.camel@debian.org>
Tuesday, July 31, 2018 4:31 PM, Luca Boccassi:
> Subject: Re: [dpdk-dev] [PATCH] net/mlx4: Avoid stripping the glue library
>
> On Tue, 2018-07-31 at 15:15 +0200, Timothy Redaelli wrote:
> > Stripping binaries at build time is usually a bad thing since it makes
> > impossible to generate (split) debug symbols and this can lead to a
> > more difficult debugging.
> >
> > CC: Adrien Mazarguil <adrien.mazarguil@6wind.com>
> > Fixes: 27cea11686ff ("net/mlx4: spawn rdma-core dependency plug-in")
> >
> > Signed-off-by: Timothy Redaelli <tredaelli@redhat.com>
> > ---
> > drivers/net/mlx4/Makefile | 2 +-
> > 1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/drivers/net/mlx4/Makefile b/drivers/net/mlx4/Makefile
> > index 63bc00337..92e932250 100644
> > --- a/drivers/net/mlx4/Makefile
> > +++ b/drivers/net/mlx4/Makefile
> > @@ -115,7 +115,7 @@ endif
> > $(LIB_GLUE): mlx4_glue.o
> > $Q $(LD) $(GLUE_LDFLAGS) $(EXTRA_LDFLAGS) \
> > -Wl,-h,$(LIB_GLUE) \
> > - -s -shared -o $@ $< -libverbs -lmlx4
> > + -shared -o $@ $< -libverbs -lmlx4
> >
> > mlx4_glue.o: mlx4_autoconf.h
>
> Acked-by: Luca Boccassi <bluca@debian.org>
>
> Automated tools to generate separate packages with debug symbols (the
> standard at least in Debian and derivatives distros) break if a library is
> stripped, and it's very hard to notice as well as it's not an error per se.
Applied to next-net-mlx, thanks.
>
> --
> Kind regards,
> Luca Boccassi
next prev parent reply other threads:[~2018-08-01 8:30 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-07-31 13:15 Timothy Redaelli
2018-07-31 13:30 ` Luca Boccassi
2018-08-01 8:30 ` Shahaf Shuler [this message]
2018-07-31 13:32 ` Christian Ehrhardt
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=DB7PR05MB4426B3C7896DEE2CEE1CB107C32D0@DB7PR05MB4426.eurprd05.prod.outlook.com \
--to=shahafs@mellanox.com \
--cc=adrien.mazarguil@6wind.com \
--cc=bluca@debian.org \
--cc=dev@dpdk.org \
--cc=matan@mellanox.com \
--cc=tredaelli@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).