From: Shahaf Shuler <shahafs@mellanox.com>
To: Adrien Mazarguil <adrien.mazarguil@6wind.com>
Cc: "Thomas Monjalon" <thomas@monjalon.net>,
"Nélio Laranjeiro" <nelio.laranjeiro@6wind.com>,
"dev@dpdk.org" <dev@dpdk.org>,
"Yongseok Koh" <yskoh@mellanox.com>
Subject: Re: [dpdk-dev] [PATCH] mk: fix application compilation with lmnl and mlx5
Date: Wed, 25 Jul 2018 13:23:35 +0000 [thread overview]
Message-ID: <DB7PR05MB4426F4678B96057C7B6D77EBC3540@DB7PR05MB4426.eurprd05.prod.outlook.com> (raw)
In-Reply-To: <20180725090726.GV5211@6wind.com>
Wednesday, July 25, 2018 12:07 PM, Adrien Mazarguil:
> Subject: Re: [PATCH] mk: fix application compilation with lmnl and mlx5
>
> The approach of linking .a files instead of .so and still generate a dynamic
> program also has drawbacks: duplication and link time issues with multiple
> users. For instance, this may cause mlx4 and mlx5 to conflict on libibverbs and
> libmnl symbols, leaving one unable to include both PMDs into their program
> or prevent it from linking with these libraries for its own needs.
> I don't think it's worth the trouble.
>
OK,
Acked-by: Shahaf Shuler <shahafs@mellanox.com>
prev parent reply other threads:[~2018-07-25 13:24 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-07-24 9:29 Nelio Laranjeiro
2018-07-24 9:32 ` Adrien Mazarguil
2018-07-26 12:05 ` Thomas Monjalon
2018-07-24 11:21 ` Shahaf Shuler
2018-07-24 11:44 ` Nélio Laranjeiro
2018-07-24 11:53 ` Shahaf Shuler
2018-07-24 12:55 ` Adrien Mazarguil
2018-07-24 13:03 ` Shahaf Shuler
2018-07-24 15:13 ` Adrien Mazarguil
2018-07-25 6:39 ` Shahaf Shuler
2018-07-25 9:07 ` Adrien Mazarguil
2018-07-25 13:23 ` Shahaf Shuler [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=DB7PR05MB4426F4678B96057C7B6D77EBC3540@DB7PR05MB4426.eurprd05.prod.outlook.com \
--to=shahafs@mellanox.com \
--cc=adrien.mazarguil@6wind.com \
--cc=dev@dpdk.org \
--cc=nelio.laranjeiro@6wind.com \
--cc=thomas@monjalon.net \
--cc=yskoh@mellanox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).