From: Shahaf Shuler <shahafs@mellanox.com>
To: Ophir Munk <ophirmu@mellanox.com>, "dev@dpdk.org" <dev@dpdk.org>
Cc: Thomas Monjalon <thomas@monjalon.net>,
Olga Shern <olgas@mellanox.com>,
Ophir Munk <ophirmu@mellanox.com>,
"stable@dpdk.org" <stable@dpdk.org>
Subject: Re: [dpdk-stable] [dpdk-dev] [PATCH v1] net/mlx5: fix secondary process resource leakage
Date: Thu, 2 Aug 2018 10:40:30 +0000 [thread overview]
Message-ID: <DB7PR05MB4426FB9F559CCB3BDDCE960DC32C0@DB7PR05MB4426.eurprd05.prod.outlook.com> (raw)
In-Reply-To: <DB7PR05MB4426B7258025DF0B9EE657A0C32D0@DB7PR05MB4426.eurprd05.prod.outlook.com>
Wednesday, August 1, 2018 11:01 AM, Shahaf Shuler:
> Subject: RE: [dpdk-dev] [PATCH v1] net/mlx5: fix secondary process resource
> leakage
>
> Hi Ophir,
>
> Wednesday, August 1, 2018 1:38 AM, Ophir Munk:
> > Subject: [dpdk-dev] [PATCH v1] net/mlx5: fix secondary process
> > resource leakage
> >
> > When running testpmd with an mlx5 device and then executing at testpmd
> > prompt in a raw: "port start all" followed by "port stop all"
> > a new file named /var/tmp/net_mlx5_<socket num> is created as a result
> > of creating a new unix domain socket (used for communication between
> > the primary and secondary processes).
> > When the new unix socket file is created the old unix socket file
> > should have been removed. This commit fixes it by closing the old unix
> > socket just before creating the new one in function mlx5_socket_init()
> >
> > Fixes: f8b9a3bad467 ("net/mlx5: install a socket to exchange a file
> > descriptor")
> > Cc: stable@dpdk.org
> >
> > Signed-off-by: Ophir Munk <ophirmu@mellanox.com>
> > ---
> > drivers/net/mlx5/mlx5_socket.c | 6 ++++++
> > 1 file changed, 6 insertions(+)
> >
> > diff --git a/drivers/net/mlx5/mlx5_socket.c
> > b/drivers/net/mlx5/mlx5_socket.c index 99297d5..a3a5229 100644
> > --- a/drivers/net/mlx5/mlx5_socket.c
> > +++ b/drivers/net/mlx5/mlx5_socket.c
> > @@ -36,6 +36,12 @@
> > int flags;
> >
> > /*
> > + * Close the last socket that was used to communicate
> > + * with the secondary process
> > + */
> > + if (priv->primary_socket)
> > + mlx5_socket_uninit(dev);
>
> On the current code the primary socket is created on port start and removed
> on port close (this is the bug you address).
> Wouldn't it be better to just create it on probe?
> This way the primary sets up its socket when the ethdev is created and
> removes it when it is destroyed. The handling of the socket event still
> happen only when the primary ports start because only then the interrupt
> handler is installed.
After internal discussion w/ Ophir we decided to take this patch as is considering we are very late on this release and this fix has a low risk to break something else.
We need to address this one on the next release in a better way.
Applied to next-net-mlx, thanks.
>
> > + /*
> > * Initialise the socket to communicate with the secondary
> > * process.
> > */
> > --
> > 1.8.3.1
prev parent reply other threads:[~2018-08-02 10:40 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-07-31 22:38 [dpdk-stable] " Ophir Munk
2018-08-01 8:01 ` [dpdk-stable] [dpdk-dev] " Shahaf Shuler
2018-08-02 10:40 ` Shahaf Shuler [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=DB7PR05MB4426FB9F559CCB3BDDCE960DC32C0@DB7PR05MB4426.eurprd05.prod.outlook.com \
--to=shahafs@mellanox.com \
--cc=dev@dpdk.org \
--cc=olgas@mellanox.com \
--cc=ophirmu@mellanox.com \
--cc=stable@dpdk.org \
--cc=thomas@monjalon.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).