From: Phil Yang <Phil.Yang@arm.com>
To: Ferruh Yigit <ferruh.yigit@intel.com>,
Wenzhuo Lu <wenzhuo.lu@intel.com>,
Beilei Xing <beilei.xing@intel.com>,
Bernard Iremonger <bernard.iremonger@intel.com>
Cc: "dev@dpdk.org" <dev@dpdk.org>, nd <nd@arm.com>
Subject: Re: [dpdk-dev] [PATCH 3/4] app/testpmd: fix build with gcc 11
Date: Thu, 24 Sep 2020 11:01:16 +0000 [thread overview]
Message-ID: <DB7PR08MB38658DC5AF38766002439060E9390@DB7PR08MB3865.eurprd08.prod.outlook.com> (raw)
In-Reply-To: <20200921133830.1575872-3-ferruh.yigit@intel.com>
<snip>
> Subject: [dpdk-dev] [PATCH 3/4] app/testpmd: fix build with gcc 11
>
> Error observed with gcc 11 under development
> gcc (GCC) 11.0.0 20200920 (experimental)
>
> ../app/test-pmd/config.c:1777:61:
> warning: argument 3 of type ‘const uint32_t[n]’
> {aka ‘const unsigned int[n]’} declared as a variable length
> array [-Wvla-parameter]
> 1777 | port_flow_list(portid_t port_id, uint32_t n,
> const uint32_t group[n])
> | ~~~~~~~~~~~~~~~^~~~~~~~
> In file included from ../app/test-pmd/config.c:53:
> ../app/test-pmd/testpmd.h:764:67:
> note: previously declared as a pointer ‘const uint32_t *’
> {aka ‘const unsigned int *’}
> 764 | void port_flow_list(portid_t port_id, uint32_t n,
> const uint32_t *group);
> | ~~~~~~~~~~~~~~~~^~~~~
>
> Signed-off-by: Ferruh Yigit <ferruh.yigit@intel.com>
Verified with gcc version 11.0.0 20200920 (experimental).
Reviewed-by: Phil Yang <phil.yang@arm.com>
> ---
> app/test-pmd/config.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/app/test-pmd/config.c b/app/test-pmd/config.c
> index b6eb2a57a..380f3b5f6 100644
> --- a/app/test-pmd/config.c
> +++ b/app/test-pmd/config.c
> @@ -1774,7 +1774,7 @@ port_flow_aged(portid_t port_id, uint8_t destroy)
>
> /** List flow rules. */
> void
> -port_flow_list(portid_t port_id, uint32_t n, const uint32_t group[n])
> +port_flow_list(portid_t port_id, uint32_t n, const uint32_t *group)
> {
> struct rte_port *port;
> struct port_flow *pf;
> --
> 2.26.2
next prev parent reply other threads:[~2020-09-24 11:01 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-09-21 13:38 [dpdk-dev] [PATCH 1/4] net/qede: " Ferruh Yigit
2020-09-21 13:38 ` [dpdk-dev] [PATCH 2/4] raw/dpaa2: " Ferruh Yigit
[not found] ` <CAJFAV8wAio=NF2eMMx9URkNinht2sPtBrE9k1c0uD+_GJcM4aw@mail.gmail.com>
[not found] ` <CAJFAV8y9zFUAKoqhQxobdQDVPAOny4ie+Cm1fHneEX6g6zdtjw@mail.gmail.com>
[not found] ` <AM5PR0401MB2593386BAB0C09ABE92F9D65E60B0@AM5PR0401MB2593.eurprd04.prod.outlook.com>
2020-10-08 10:40 ` David Marchand
2020-10-08 11:29 ` Ferruh Yigit
2020-09-21 13:38 ` [dpdk-dev] [PATCH 3/4] app/testpmd: " Ferruh Yigit
2020-09-24 9:31 ` David Marchand
2020-10-04 8:57 ` Asaf Penso
2020-09-24 11:01 ` Phil Yang [this message]
2020-10-08 10:48 ` David Marchand
2020-09-21 13:38 ` [dpdk-dev] [PATCH 4/4] pmdinfogen: " Ferruh Yigit
2020-09-24 9:32 ` David Marchand
2020-10-08 10:48 ` David Marchand
2020-09-25 4:27 ` [dpdk-dev] [EXT] [PATCH 1/4] net/qede: " Rasesh Mody
2020-10-06 12:38 ` David Marchand
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=DB7PR08MB38658DC5AF38766002439060E9390@DB7PR08MB3865.eurprd08.prod.outlook.com \
--to=phil.yang@arm.com \
--cc=beilei.xing@intel.com \
--cc=bernard.iremonger@intel.com \
--cc=dev@dpdk.org \
--cc=ferruh.yigit@intel.com \
--cc=nd@arm.com \
--cc=wenzhuo.lu@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).