From: Kamalakshitha Aligeri <Kamalakshitha.Aligeri@arm.com>
To: Kamalakshitha Aligeri <Kamalakshitha.Aligeri@arm.com>,
"Yuying.Zhang@intel.com" <Yuying.Zhang@intel.com>,
"beilei.xing@intel.com" <beilei.xing@intel.com>,
"olivier.matz@6wind.com" <olivier.matz@6wind.com>,
"andrew.rybchenko@oktetlabs.ru" <andrew.rybchenko@oktetlabs.ru>,
"bruce.richardson@intel.com" <bruce.richardson@intel.com>,
"mb@smartsharesystems.com" <mb@smartsharesystems.com>,
"konstantin.ananyev@huawei.com" <konstantin.ananyev@huawei.com>,
Honnappa Nagarahalli <Honnappa.Nagarahalli@arm.com>,
Ruifeng Wang <Ruifeng.Wang@arm.com>,
Feifei Wang <Feifei.Wang2@arm.com>
Cc: "dev@dpdk.org" <dev@dpdk.org>, nd <nd@arm.com>, nd <nd@arm.com>
Subject: RE: [PATCH v10 2/2] net/i40e: replace put function
Date: Thu, 2 Mar 2023 21:44:57 +0000 [thread overview]
Message-ID: <DB7PR08MB386593AE27BC7897F17CE8F9F7B29@DB7PR08MB3865.eurprd08.prod.outlook.com> (raw)
In-Reply-To: <20230224181059.338206-3-kamalakshitha.aligeri@arm.com>
Hi all,
This patch shows a couple of failures in patchwork. I checked it and it is not related to the patch.
It shows as service_autotest failure.
Anybody know how to fix this?
> -----Original Message-----
> From: Kamalakshitha Aligeri <kamalakshitha.aligeri@arm.com>
> Sent: Friday, February 24, 2023 10:11 AM
> To: Yuying.Zhang@intel.com; beilei.xing@intel.com;
> olivier.matz@6wind.com; andrew.rybchenko@oktetlabs.ru;
> bruce.richardson@intel.com; mb@smartsharesystems.com;
> konstantin.ananyev@huawei.com; Honnappa Nagarahalli
> <Honnappa.Nagarahalli@arm.com>; Ruifeng Wang
> <Ruifeng.Wang@arm.com>; Feifei Wang <Feifei.Wang2@arm.com>
> Cc: dev@dpdk.org; nd <nd@arm.com>; Kamalakshitha Aligeri
> <Kamalakshitha.Aligeri@arm.com>
> Subject: [PATCH v10 2/2] net/i40e: replace put function
>
> Integrated zero-copy put API in mempool cache in i40e PMD.
> On Ampere Altra server, l3fwd single core's performance improves by 5%
> with the new API
>
> Signed-off-by: Kamalakshitha Aligeri <kamalakshitha.aligeri@arm.com>
> Reviewed-by: Ruifeng Wang <ruifeng.wang@arm.com>
> Reviewed-by: Feifei Wang <feifei.wang2@arm.com>
> Reviewed-by: Morten Brørup <mb@smartsharesystems.com>
> ---
> v3:
> Fixed the way mbufs are accessed from txep (Morten Brorup)
> v2:
> Fixed the code for n > RTE_MEMPOOL_CACHE_MAX_SIZE (Morten Brorup)
> v1:
> 1. Integrated the zc_put API in i40e PMD 2. Added mempool test cases with
> the zero-cpoy API's
>
> .mailmap | 1 +
> drivers/net/i40e/i40e_rxtx_vec_common.h | 27 ++++++++++++++++++++--
> ---
> 2 files changed, 23 insertions(+), 5 deletions(-)
>
> diff --git a/.mailmap b/.mailmap
> index a9f4f28fba..2581d0efe7 100644
> --- a/.mailmap
> +++ b/.mailmap
> @@ -677,6 +677,7 @@ Kai Ji <kai.ji@intel.com> Kaiwen Deng
> <kaiwenx.deng@intel.com> Kalesh AP <kalesh-
> anakkur.purayil@broadcom.com>
> Kamalakannan R <kamalakannan.r@intel.com>
> +Kamalakshitha Aligeri <kamalakshitha.aligeri@arm.com>
> Kamil Bednarczyk <kamil.bednarczyk@intel.com> Kamil Chalupnik
> <kamilx.chalupnik@intel.com> Kamil Rytarowski
> <kamil.rytarowski@caviumnetworks.com>
> diff --git a/drivers/net/i40e/i40e_rxtx_vec_common.h
> b/drivers/net/i40e/i40e_rxtx_vec_common.h
> index fe1a6ec75e..35cdb31b2e 100644
> --- a/drivers/net/i40e/i40e_rxtx_vec_common.h
> +++ b/drivers/net/i40e/i40e_rxtx_vec_common.h
> @@ -95,18 +95,35 @@ i40e_tx_free_bufs(struct i40e_tx_queue *txq)
>
> n = txq->tx_rs_thresh;
>
> - /* first buffer to free from S/W ring is at index
> - * tx_next_dd - (tx_rs_thresh-1)
> - */
> + /* first buffer to free from S/W ring is at index
> + * tx_next_dd - (tx_rs_thresh-1)
> + */
> txep = &txq->sw_ring[txq->tx_next_dd - (n - 1)];
>
> if (txq->offloads & RTE_ETH_TX_OFFLOAD_MBUF_FAST_FREE) {
> + struct rte_mempool *mp = txep[0].mbuf->pool;
> + struct rte_mempool_cache *cache =
> rte_mempool_default_cache(mp, rte_lcore_id());
> + void **cache_objs;
> +
> + if (unlikely(!cache))
> + goto fallback;
> +
> + cache_objs = rte_mempool_cache_zc_put_bulk(cache, mp,
> n);
> + if (unlikely(!cache_objs))
> + goto fallback;
> +
> for (i = 0; i < n; i++) {
> - free[i] = txep[i].mbuf;
> + cache_objs[i] = txep[i].mbuf;
> /* no need to reset txep[i].mbuf in vector path */
> }
> - rte_mempool_put_bulk(free[0]->pool, (void **)free, n);
> goto done;
> +
> +fallback:
> + for (i = 0; i < n; i++)
> + free[i] = txep[i].mbuf;
> + rte_mempool_generic_put(mp, (void **)free, n, cache);
> + goto done;
> +
> }
>
> m = rte_pktmbuf_prefree_seg(txep[0].mbuf);
> --
> 2.25.1
prev parent reply other threads:[~2023-03-02 21:45 UTC|newest]
Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-02-24 18:10 [PATCH v10 0/2] zero-copy get and put functions Kamalakshitha Aligeri
2023-02-24 18:10 ` [PATCH v10 1/2] mempool cache: add " Kamalakshitha Aligeri
2023-02-27 7:12 ` Ruifeng Wang
2023-04-06 10:13 ` Morten Brørup
2023-04-25 13:14 ` Morten Brørup
2023-06-07 10:32 ` Thomas Monjalon
2023-06-07 12:04 ` Morten Brørup
2023-06-07 12:32 ` Thomas Monjalon
2023-06-07 13:42 ` Morten Brørup
2023-06-07 14:05 ` Morten Brørup
2023-07-05 17:18 ` [PATCH v11 " Kamalakshitha Aligeri
2023-07-05 17:18 ` [PATCH v11 2/2] net/i40e: replace put function Kamalakshitha Aligeri
2023-07-06 9:20 ` Konstantin Ananyev
2023-07-06 13:32 ` Morten Brørup
2023-07-06 9:20 ` [PATCH v11 1/2] mempool cache: add zero-copy get and put functions Konstantin Ananyev
2023-07-05 18:02 ` Kamalakshitha Aligeri
2023-07-05 18:02 ` [PATCH v11 2/2] net/i40e: replace put function Kamalakshitha Aligeri
2023-07-18 11:36 ` Morten Brørup
2023-07-21 16:28 ` [PATCH v12 1/2] mempool cache: add zero-copy get and put functions Dharmik Thakkar
2023-07-21 16:28 ` [PATCH v12 2/2] net/i40e: replace put function Dharmik Thakkar
2023-07-31 12:16 ` [PATCH v12 1/2] mempool cache: add zero-copy get and put functions Thomas Monjalon
2023-10-13 5:41 ` Morten Brørup
2023-07-18 10:14 ` [PATCH v11 " Morten Brørup
2023-02-24 18:10 ` [PATCH v10 2/2] net/i40e: replace put function Kamalakshitha Aligeri
2023-03-02 21:44 ` Kamalakshitha Aligeri [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=DB7PR08MB386593AE27BC7897F17CE8F9F7B29@DB7PR08MB3865.eurprd08.prod.outlook.com \
--to=kamalakshitha.aligeri@arm.com \
--cc=Feifei.Wang2@arm.com \
--cc=Honnappa.Nagarahalli@arm.com \
--cc=Ruifeng.Wang@arm.com \
--cc=Yuying.Zhang@intel.com \
--cc=andrew.rybchenko@oktetlabs.ru \
--cc=beilei.xing@intel.com \
--cc=bruce.richardson@intel.com \
--cc=dev@dpdk.org \
--cc=konstantin.ananyev@huawei.com \
--cc=mb@smartsharesystems.com \
--cc=nd@arm.com \
--cc=olivier.matz@6wind.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).