From: Feifei Wang <Feifei.Wang2@arm.com>
To: Bruce Richardson <bruce.richardson@intel.com>
Cc: "dev@dpdk.org" <dev@dpdk.org>, nd <nd@arm.com>,
"Juraj Linkeš" <juraj.linkes@pantheon.tech>,
"Ruifeng Wang" <Ruifeng.Wang@arm.com>, nd <nd@arm.com>
Subject: [dpdk-dev] 回复: [PATCH v1 2/2] devtools: use absolute path for the build directory
Date: Wed, 28 Jul 2021 07:20:33 +0000 [thread overview]
Message-ID: <DB9PR08MB69236E9CA1C2AAF8626E20D8C8EA9@DB9PR08MB6923.eurprd08.prod.outlook.com> (raw)
In-Reply-To: <20210601015653.14499-3-feifei.wang2@arm.com>
Hi, Bruce
Sorry to disturb you again. Would you please help review the second patch
of this series? Thanks very much.
Best Regards
Feifei
> -----邮件原件-----
> 发件人: Feifei Wang <feifei.wang2@arm.com>
> 发送时间: Tuesday, June 1, 2021 9:57 AM
> 收件人: Bruce Richardson <bruce.richardson@intel.com>
> 抄送: dev@dpdk.org; nd <nd@arm.com>; Phil Yang <Phil.Yang@arm.com>;
> Juraj Linkeš <juraj.linkes@pantheon.tech>; Feifei Wang
> <Feifei.Wang2@arm.com>; Ruifeng Wang <Ruifeng.Wang@arm.com>
> 主题: [PATCH v1 2/2] devtools: use absolute path for the build directory
>
> From: Phil Yang <phil.yang@arm.com>
>
> To make the code easier to maintain, use the absolute path for the default
> build_dir to avoid repeatedly calling of readlink.
>
> Suggested-by: Juraj Linkeš <juraj.linkes@pantheon.tech>
> Signed-off-by: Phil Yang <phil.yang@arm.com>
> Signed-off-by: Feifei Wang <feifei.wang2@arm.com>
> Reviewed-by: Juraj Linkeš <juraj.linkes@pantheon.tech>
> Reviewed-by: Ruifeng Wang <ruifeng.wang@arm.com>
> ---
> devtools/test-meson-builds.sh | 14 +++++++-------
> 1 file changed, 7 insertions(+), 7 deletions(-)
>
> diff --git a/devtools/test-meson-builds.sh b/devtools/test-meson-builds.sh
> index 43b906598d..d6b0e7e059 100755
> --- a/devtools/test-meson-builds.sh
> +++ b/devtools/test-meson-builds.sh
> @@ -16,7 +16,7 @@ srcdir=$(dirname $(readlink -f $0))/..
>
> MESON=${MESON:-meson}
> use_shared="--default-library=shared"
> -builds_dir=${DPDK_BUILD_TEST_DIR:-.}
> +builds_dir=$(readlink -f ${DPDK_BUILD_TEST_DIR:-.})
>
> if command -v gmake >/dev/null 2>&1 ; then
> MAKE=gmake
> @@ -193,16 +193,16 @@ build () # <directory> <target cc | cross file> <ABI
> check> [meson options]
> fi
>
> install_target $builds_dir/$targetdir \
> - $(readlink -f $builds_dir/$targetdir/install)
> + $builds_dir/$targetdir/install
> echo "Checking ABI compatibility of $targetdir" >&$verbose
> echo $srcdir/devtools/gen-abi.sh \
> - $(readlink -f
> $builds_dir/$targetdir/install) >&$veryverbose
> + $builds_dir/$targetdir/install >&$veryverbose
> $srcdir/devtools/gen-abi.sh \
> - $(readlink -f
> $builds_dir/$targetdir/install) >&$veryverbose
> + $builds_dir/$targetdir/install >&$veryverbose
> echo $srcdir/devtools/check-abi.sh $abirefdir/$targetdir \
> - $(readlink -f
> $builds_dir/$targetdir/install) >&$veryverbose
> + $builds_dir/$targetdir/install >&$veryverbose
> $srcdir/devtools/check-abi.sh $abirefdir/$targetdir \
> - $(readlink -f
> $builds_dir/$targetdir/install) >&$verbose
> + $builds_dir/$targetdir/install >&$verbose
> fi
> }
>
> @@ -275,7 +275,7 @@ done
> # Test installation of the x86-generic target, to be used for checking # the
> sample apps build using the pkg-config file for cflags and libs load_env cc -
> build_path=$(readlink -f $builds_dir/build-x86-generic)
> +build_path=$builds_dir/build-x86-generic
> export DESTDIR=$build_path/install
> install_target $build_path $DESTDIR
> pc_file=$(find $DESTDIR -name libdpdk.pc)
> --
> 2.25.1
next prev parent reply other threads:[~2021-07-28 7:20 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-06-01 1:56 [dpdk-dev] [PATCH v1 0/2] relative path support for ABI compatibility check Feifei Wang
2021-06-01 1:56 ` [dpdk-dev] [PATCH v1 1/2] devtools: add " Feifei Wang
2021-06-22 2:08 ` [dpdk-dev] 回复: " Feifei Wang
2021-06-22 9:19 ` [dpdk-dev] " Bruce Richardson
2021-06-01 1:56 ` [dpdk-dev] [PATCH v1 2/2] devtools: use absolute path for the build directory Feifei Wang
2021-07-28 7:20 ` Feifei Wang [this message]
2021-08-06 15:43 ` Thomas Monjalon
2021-08-11 3:14 ` [dpdk-dev] 回复: " Feifei Wang
2021-08-11 6:17 ` [dpdk-dev] [PATCH v2 0/1] relative path support for ABI compatibility check Feifei Wang
2021-08-11 6:17 ` [dpdk-dev] [PATCH v2 1/1] devtools: add " Feifei Wang
2021-10-15 10:02 ` [dpdk-dev] 回复: " Feifei Wang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=DB9PR08MB69236E9CA1C2AAF8626E20D8C8EA9@DB9PR08MB6923.eurprd08.prod.outlook.com \
--to=feifei.wang2@arm.com \
--cc=Ruifeng.Wang@arm.com \
--cc=bruce.richardson@intel.com \
--cc=dev@dpdk.org \
--cc=juraj.linkes@pantheon.tech \
--cc=nd@arm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).