From: Honnappa Nagarahalli <Honnappa.Nagarahalli@arm.com>
To: David Marchand <david.marchand@redhat.com>
Cc: "dev@dpdk.org" <dev@dpdk.org>,
"aconole@redhat.com" <aconole@redhat.com>,
"blo@iol.unh.edu" <blo@iol.unh.edu>,
"bruce.richardson@intel.com" <bruce.richardson@intel.com>,
nd <nd@arm.com>,
Honnappa Nagarahalli <Honnappa.Nagarahalli@arm.com>,
nd <nd@arm.com>
Subject: Re: [dpdk-dev] [PATCH v2] test: rely on EAL detection for core list
Date: Tue, 19 Oct 2021 18:04:30 +0000 [thread overview]
Message-ID: <DBAPR08MB5814159807F5005995339D9F98BD9@DBAPR08MB5814.eurprd08.prod.outlook.com> (raw)
In-Reply-To: <CAJFAV8wkmBYX97qxVFwiwj3a63JVM3S-q001A-Z02hG+VSRLRw@mail.gmail.com>
<snip>
> >
> > >
> > > Cores count has a direct impact on the time needed to complete unit tests.
> > We also need to control the number of iterations with in the tests.
> >
> > We could add something like "-i low/medium/high". The test cases then can
> use this to decide on how many iterations to run.
>
> This patch hands control of parameters that affect all tests to the CI.
>
> But number of iterations is a per test thing.
Agree, it is a per test thing. But, multiple test files run the test case in several iterations. So, multiple test cases can make use of the same input from the user.
> What would be the definition of an "iteration"?
> Something that must be done in a maximum of cycles.. ?
You can look at test_atomic.c, we have the following #define
#define N 1000000
It is used as follows (in the simplest case) to repeat a test:
for (i = 0; i < N; i++)
rte_atomic16_inc(&a16);
The value 1000000 defines how long this test will take.
In a CI environment, we want to reduce the time taken, whereas in a local lab machine, I might not care about the time it takes to run the test. This could be an input from the user which the test cases can make use of. For ex: for 'low', test case might set N = 10000 and so on.
>
> This could be something to look at, but it goes beyond this patch.
Agreed, this can be a separate patch.
>
>
> --
> David Marchand
next prev parent reply other threads:[~2021-10-19 18:04 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-10-18 17:01 [dpdk-dev] [PATCH] " David Marchand
2021-10-18 17:53 ` Bruce Richardson
2021-10-19 9:52 ` David Marchand
2021-10-19 10:04 ` Bruce Richardson
2021-10-19 11:26 ` [dpdk-dev] [PATCH v2] " David Marchand
2021-10-19 12:43 ` Bruce Richardson
2021-10-19 14:46 ` Honnappa Nagarahalli
2021-10-19 15:04 ` David Marchand
2021-10-19 18:04 ` Honnappa Nagarahalli [this message]
2021-10-19 19:09 ` Aaron Conole
2021-10-19 19:28 ` David Marchand
2021-10-20 11:20 ` David Marchand
2021-10-21 14:50 ` David Marchand
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=DBAPR08MB5814159807F5005995339D9F98BD9@DBAPR08MB5814.eurprd08.prod.outlook.com \
--to=honnappa.nagarahalli@arm.com \
--cc=aconole@redhat.com \
--cc=blo@iol.unh.edu \
--cc=bruce.richardson@intel.com \
--cc=david.marchand@redhat.com \
--cc=dev@dpdk.org \
--cc=nd@arm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).