From: Honnappa Nagarahalli <Honnappa.Nagarahalli@arm.com>
To: Joyce Kong <Joyce.Kong@arm.com>,
"thomas@monjalon.net" <thomas@monjalon.net>,
"david.marchand@redhat.com" <david.marchand@redhat.com>,
Ruifeng Wang <Ruifeng.Wang@arm.com>,
"konstantin.ananyev@intel.com" <konstantin.ananyev@intel.com>,
"rsanford@akamai.com" <rsanford@akamai.com>,
"erik.g.carrillo@intel.com" <erik.g.carrillo@intel.com>,
"olivier.matz@6wind.com" <olivier.matz@6wind.com>,
"yipeng1.wang@intel.com" <yipeng1.wang@intel.com>,
"sameh.gobriel@intel.com" <sameh.gobriel@intel.com>,
"bruce.richardson@intel.com" <bruce.richardson@intel.com>,
"vladimir.medvedkin@intel.com" <vladimir.medvedkin@intel.com>,
"anatoly.burakov@intel.com" <anatoly.burakov@intel.com>,
"andrew.rybchenko@oktetlabs.ru" <andrew.rybchenko@oktetlabs.ru>,
"jerinj@marvell.com" <jerinj@marvell.com>,
"declan.doherty@intel.com" <declan.doherty@intel.com>,
"ciara.power@intel.com" <ciara.power@intel.com>,
"xiaoyun.li@intel.com" <xiaoyun.li@intel.com>,
"nicolas.chautru@intel.com" <nicolas.chautru@intel.com>,
"maryam.tahhan@intel.com" <maryam.tahhan@intel.com>,
"reshma.pattan@intel.com" <reshma.pattan@intel.com>,
"cristian.dumitrescu@intel.com" <cristian.dumitrescu@intel.com>
Cc: "dev@dpdk.org" <dev@dpdk.org>, nd <nd@arm.com>, nd <nd@arm.com>
Subject: Re: [dpdk-dev] [PATCH v1 09/12] app/compress: use compiler atomic builtins for display sync
Date: Tue, 9 Nov 2021 22:59:14 +0000 [thread overview]
Message-ID: <DBAPR08MB5814D67806DEC28FEB3EA42398929@DBAPR08MB5814.eurprd08.prod.outlook.com> (raw)
In-Reply-To: <20210802101847.3462-10-joyce.kong@arm.com>
<snip>
>
> Convert rte_atomic_test_and_set usage to compiler atomic CAS operation for
> display sync.
>
> Signed-off-by: Joyce Kong <joyce.kong@arm.com>
> Reviewed-by: Ruifeng Wang <ruifeng.wang@arm.com>
> ---
> app/test-compress-perf/comp_perf_test_common.h | 2 +-
> app/test-compress-perf/comp_perf_test_cyclecount.c | 10 +++++++---
> app/test-compress-perf/comp_perf_test_throughput.c | 11 ++++++++---
> app/test-compress-perf/comp_perf_test_verify.c | 6 ++++--
> 4 files changed, 20 insertions(+), 9 deletions(-)
>
> diff --git a/app/test-compress-perf/comp_perf_test_common.h b/app/test-
> compress-perf/comp_perf_test_common.h
> index 72705c6a2b..d039e5a29a 100644
> --- a/app/test-compress-perf/comp_perf_test_common.h
> +++ b/app/test-compress-perf/comp_perf_test_common.h
> @@ -14,7 +14,7 @@ struct cperf_mem_resources {
> uint16_t qp_id;
> uint8_t lcore_id;
>
> - rte_atomic16_t print_info_once;
> + uint16_t print_info_once;
>
> uint32_t total_bufs;
> uint8_t *compressed_data;
> diff --git a/app/test-compress-perf/comp_perf_test_cyclecount.c b/app/test-
> compress-perf/comp_perf_test_cyclecount.c
> index 55559a7d5a..e002e53bdf 100644
> --- a/app/test-compress-perf/comp_perf_test_cyclecount.c
> +++ b/app/test-compress-perf/comp_perf_test_cyclecount.c
> @@ -468,7 +468,7 @@ cperf_cyclecount_test_runner(void *test_ctx)
> struct cperf_cyclecount_ctx *ctx = test_ctx;
> struct comp_test_data *test_data = ctx->ver.options;
> uint32_t lcore = rte_lcore_id();
> - static rte_atomic16_t display_once = RTE_ATOMIC16_INIT(0);
> + static uint16_t display_once;
> static rte_spinlock_t print_spinlock;
> int i;
>
> @@ -488,10 +488,12 @@ cperf_cyclecount_test_runner(void *test_ctx)
>
> ctx->ver.mem.lcore_id = lcore;
>
> + uint16_t exp = 0;
> /*
> * printing information about current compression thread
> */
> - if (rte_atomic16_test_and_set(&ctx->ver.mem.print_info_once))
> + if (__atomic_compare_exchange_n(&ctx->ver.mem.print_info_once,
> &exp,
> + 1, 0, __ATOMIC_RELAXED,
> __ATOMIC_RELAXED))
> printf(" lcore: %u,"
> " driver name: %s,"
> " device name: %s,"
> @@ -547,8 +549,10 @@ cperf_cyclecount_test_runner(void *test_ctx)
> duration_setup_per_op = ctx->duration_op /
> (ctx->ver.mem.total_bufs * test_data->num_iter);
>
> + exp = 0;
> /* R E P O R T processing */
> - if (rte_atomic16_test_and_set(&display_once)) {
> + if (__atomic_compare_exchange_n(&display_once, &exp, 1, 0,
> + __ATOMIC_RELAXED, __ATOMIC_RELAXED)) {
I think we can re-organize the current code which will avoid using atomic operations on 'display_once'. How about the following code?
rte_spinlock_lock(&print_spinlock);
if (display_once != 1) {
display_once = 1;
printf("\nLegend for the table\n".....
<all other printfs>
}
printf....
printf....
printf....
rte_spinlock_unlock(&print_spinlock);
Rest of the changes look fine.
>
> rte_spinlock_lock(&print_spinlock);
>
> diff --git a/app/test-compress-perf/comp_perf_test_throughput.c b/app/test-
> compress-perf/comp_perf_test_throughput.c
> index 13922b658c..f587ad2ec3 100644
> --- a/app/test-compress-perf/comp_perf_test_throughput.c
> +++ b/app/test-compress-perf/comp_perf_test_throughput.c
> @@ -329,15 +329,18 @@ cperf_throughput_test_runner(void *test_ctx)
> struct cperf_benchmark_ctx *ctx = test_ctx;
> struct comp_test_data *test_data = ctx->ver.options;
> uint32_t lcore = rte_lcore_id();
> - static rte_atomic16_t display_once = RTE_ATOMIC16_INIT(0);
> + static uint16_t display_once;
> int i, ret = EXIT_SUCCESS;
>
> ctx->ver.mem.lcore_id = lcore;
>
> + uint16_t exp = 0;
> /*
> * printing information about current compression thread
> */
> - if (rte_atomic16_test_and_set(&ctx->ver.mem.print_info_once))
> + if (__atomic_compare_exchange_n(&ctx->ver.mem.print_info_once,
> &exp,
> + 1, 0, __ATOMIC_RELAXED,
> __ATOMIC_RELAXED))
> +
> printf(" lcore: %u,"
> " driver name: %s,"
> " device name: %s,"
> @@ -391,7 +394,9 @@ cperf_throughput_test_runner(void *test_ctx)
> ctx->decomp_gbps = rte_get_tsc_hz() / ctx->decomp_tsc_byte * 8 /
> 1000000000;
>
> - if (rte_atomic16_test_and_set(&display_once)) {
> + exp = 0;
> + if (__atomic_compare_exchange_n(&display_once, &exp, 1, 0,
> + __ATOMIC_RELAXED, __ATOMIC_RELAXED)) {
> printf("\n%12s%6s%12s%17s%15s%16s\n",
> "lcore id", "Level", "Comp size", "Comp ratio [%]",
> "Comp [Gbps]", "Decomp [Gbps]");
> diff --git a/app/test-compress-perf/comp_perf_test_verify.c b/app/test-
> compress-perf/comp_perf_test_verify.c
> index 5e13257b79..6a2497985b 100644
> --- a/app/test-compress-perf/comp_perf_test_verify.c
> +++ b/app/test-compress-perf/comp_perf_test_verify.c
> @@ -388,7 +388,7 @@ cperf_verify_test_runner(void *test_ctx)
> struct cperf_verify_ctx *ctx = test_ctx;
> struct comp_test_data *test_data = ctx->options;
> int ret = EXIT_SUCCESS;
> - static rte_atomic16_t display_once = RTE_ATOMIC16_INIT(0);
> + static uint16_t display_once;
> uint32_t lcore = rte_lcore_id();
>
> ctx->mem.lcore_id = lcore;
> @@ -428,7 +428,9 @@ cperf_verify_test_runner(void *test_ctx)
> test_data->input_data_sz * 100;
>
> if (!ctx->silent) {
> - if (rte_atomic16_test_and_set(&display_once)) {
> + uint16_t exp = 0;
> + if (__atomic_compare_exchange_n(&display_once, &exp, 1,
> 0,
> + __ATOMIC_RELAXED, __ATOMIC_RELAXED)) {
> printf("%12s%6s%12s%17s\n",
> "lcore id", "Level", "Comp size", "Comp ratio [%]");
> }
> --
> 2.17.1
next prev parent reply other threads:[~2021-11-09 22:59 UTC|newest]
Thread overview: 28+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-08-02 10:18 [dpdk-dev] [PATCH v1 00/12] use compiler atomic builtins for app Joyce Kong
2021-08-02 10:18 ` [dpdk-dev] [PATCH v1 01/12] test/pmd_perf: use compiler atomic builtins for polling sync Joyce Kong
2021-11-08 22:50 ` Honnappa Nagarahalli
2021-11-10 6:10 ` Joyce Kong
2021-08-02 10:18 ` [dpdk-dev] [PATCH v1 02/12] test/ring_perf: use compiler atomic builtins for lcores sync Joyce Kong
2021-11-09 5:43 ` Honnappa Nagarahalli
2021-08-02 10:18 ` [dpdk-dev] [PATCH v1 03/12] test/timer: use compiler atomic builtins for sync Joyce Kong
2021-11-09 20:59 ` Honnappa Nagarahalli
2021-08-02 10:18 ` [dpdk-dev] [PATCH v1 04/12] test/stack_perf: use compiler atomics for lcore sync Joyce Kong
2021-11-09 21:12 ` Honnappa Nagarahalli
2021-08-02 10:18 ` [dpdk-dev] [PATCH v1 05/12] test/bpf: use compiler atomics for calculation Joyce Kong
2021-08-02 10:18 ` [dpdk-dev] [PATCH v1 06/12] test/func_reentrancy: use compiler atomic for data sync Joyce Kong
2021-11-09 21:54 ` Honnappa Nagarahalli
2021-08-02 10:18 ` [dpdk-dev] [PATCH v1 07/12] app/eventdev: use compiler atomic builtins for packets sync Joyce Kong
2021-11-10 23:19 ` Honnappa Nagarahalli
2021-11-11 7:27 ` Joyce Kong
2021-08-02 10:18 ` [dpdk-dev] [PATCH v1 08/12] app/crypto: use compiler atomic builtins for display sync Joyce Kong
2021-11-09 22:11 ` Honnappa Nagarahalli
2021-08-02 10:18 ` [dpdk-dev] [PATCH v1 09/12] app/compress: " Joyce Kong
2021-11-09 22:59 ` Honnappa Nagarahalli [this message]
2021-11-11 8:13 ` Joyce Kong
2021-08-02 10:18 ` [dpdk-dev] [PATCH v1 10/12] app/testpmd: use compiler atomic builtins for port sync Joyce Kong
2021-11-09 23:14 ` Honnappa Nagarahalli
2021-11-11 8:51 ` Joyce Kong
2021-08-02 10:18 ` [dpdk-dev] [PATCH v1 11/12] app/bbdev: use compiler atomics for thread sync Joyce Kong
2021-11-10 21:25 ` Honnappa Nagarahalli
2021-08-02 10:18 ` [dpdk-dev] [PATCH v1 12/12] app: remove unnecessary include of atomic Joyce Kong
2021-10-21 6:35 ` [dpdk-dev] [PATCH v1 00/12] use compiler atomic builtins for app Joyce Kong
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=DBAPR08MB5814D67806DEC28FEB3EA42398929@DBAPR08MB5814.eurprd08.prod.outlook.com \
--to=honnappa.nagarahalli@arm.com \
--cc=Joyce.Kong@arm.com \
--cc=Ruifeng.Wang@arm.com \
--cc=anatoly.burakov@intel.com \
--cc=andrew.rybchenko@oktetlabs.ru \
--cc=bruce.richardson@intel.com \
--cc=ciara.power@intel.com \
--cc=cristian.dumitrescu@intel.com \
--cc=david.marchand@redhat.com \
--cc=declan.doherty@intel.com \
--cc=dev@dpdk.org \
--cc=erik.g.carrillo@intel.com \
--cc=jerinj@marvell.com \
--cc=konstantin.ananyev@intel.com \
--cc=maryam.tahhan@intel.com \
--cc=nd@arm.com \
--cc=nicolas.chautru@intel.com \
--cc=olivier.matz@6wind.com \
--cc=reshma.pattan@intel.com \
--cc=rsanford@akamai.com \
--cc=sameh.gobriel@intel.com \
--cc=thomas@monjalon.net \
--cc=vladimir.medvedkin@intel.com \
--cc=xiaoyun.li@intel.com \
--cc=yipeng1.wang@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).