From: Feifei Wang <Feifei.Wang2@arm.com>
To: Pavan Nikhilesh Bhagavatula <pbhagavatula@marvell.com>,
Harry van Haaren <harry.van.haaren@intel.com>,
Nikhil Rao <nikhil.rao@intel.com>,
Pavan Nikhilesh <pbhagavatula@caviumnetworks.com>
Cc: "dev@dpdk.org" <dev@dpdk.org>,
"jerinj@marvell.com" <jerinj@marvell.com>, nd <nd@arm.com>,
"stable@dpdk.org" <stable@dpdk.org>,
Ruifeng Wang <Ruifeng.Wang@arm.com>,
Honnappa Nagarahalli <Honnappa.Nagarahalli@arm.com>,
nd <nd@arm.com>
Subject: [dpdk-stable] 回复: [EXT] [PATCH v3] examples/eventdev: refactor ethdev port stop
Date: Thu, 14 Jan 2021 06:24:18 +0000 [thread overview]
Message-ID: <DBBPR08MB441108E37ABB790273F5E3D1C8A80@DBBPR08MB4411.eurprd08.prod.outlook.com> (raw)
In-Reply-To: <CO6PR18MB3828E5B54CE6F98E7A61C2A5DED11@CO6PR18MB3828.namprd18.prod.outlook.com>
> -----邮件原件-----
> 发件人: Pavan Nikhilesh Bhagavatula <pbhagavatula@marvell.com>
> 发送时间: 2021年1月5日 18:09
> 收件人: Feifei Wang <Feifei.Wang2@arm.com>; Harry van Haaren
> <harry.van.haaren@intel.com>; Nikhil Rao <nikhil.rao@intel.com>; Pavan
> Nikhilesh <pbhagavatula@caviumnetworks.com>
> 抄送: dev@dpdk.org; jerinj@marvell.com; nd <nd@arm.com>;
> stable@dpdk.org; Ruifeng Wang <Ruifeng.Wang@arm.com>; Honnappa
> Nagarahalli <Honnappa.Nagarahalli@arm.com>
> 主题: RE: [EXT] [PATCH v3] examples/eventdev: refactor ethdev port stop
>
Hi, Pavan
> Hi Feifei,
>
> >Move eth stop code from "signal_handler" function to the end of "main"
> >function. There are two reasons for this:
> >
> >First, this improves code maintenance and makes code look simple and
> >clear. Based on this change, after receiving the interrupt signal,
> >"fdata->done" is set as 1. Then the main thread will wait all worker
> >lcores to jump out of the loop. Finally, the main thread will stop and
> >then close eth dev port.
> >
> >Second, for older version, the main thread first stops eth dev port and
> >then waits the end of worker lcore. This may cause errors because it
> >may stop the eth dev port which worker lcores are using. This moving
> >change can fix this by waiting all worker threads to exit and then stop
> >the eth dev port.
>
> Apologies for the delayed reply,
>
> In case of event dev the workers don't interact with eth device directly,
> Instead eth device "injects" packets into event device and event device is
> responsible for scheduling them to the workers.
>
> If the producer is not stopped i.e. in this case eth device then the worker
> threads might never exit and the main core would wait indefinitely for
> workers to exit. This will be predominantly seen in cases where there are
> only a few flows and large number of workers causing a lot of intra thread
> dependency.
For the case that the event device scheduling packets to the workers. Though the producer
is not stopped (eth device), when the main core receive the interrupt signal, the "fdata->done"
will be set as 1. Then all the workers load the value 1 of "fdata->done" and jump out of the loop
to finish their thread.
Best Regards
Feifei
>
> Regards,
> Pavan.
>
> >
> >In the meanwhile, remove wmb in signal_handler.
> >
> >This is because when the main lcore receive the stop signal, it stores
> >1 into fdata->done. And then the worker lcores load "fdata->done" and
> >jump out of the loop to stop running. Nothing should be stored after
> >updating
> >fdata->done, so the wmb is unnecessary.
> >
> >Fixes: 085edac2ca38 ("examples/eventdev_pipeline: support Tx
> >adapter")
> >Cc: pbhagavatula@marvell.com
> >Cc: stable@dpdk.org
> >
> >Suggested-by: Ruifeng Wang <ruifeng.wang@arm.com>
> >Signed-off-by: Feifei Wang <feifei.wang2@arm.com>
> >Reviewed-by: Ruifeng Wang <ruifeng.wang@arm.com>
> >Reviewed-by: Honnappa Nagarahalli
> ><honnappa.nagarahalli@arm.com>
> >Acked-by: Harry van Haaren <harry.van.haaren@intel.com>
> >---
> >
> >v2:
> >1. Delete unused variable to fix build error 2. Reduce commit message
> >length to fix coding style issues
> >
> >v3:
> >1. Title improvement (Van Haaren)
> >
> > examples/eventdev_pipeline/main.c | 16 ++++------------
> > 1 file changed, 4 insertions(+), 12 deletions(-)
> >
> >diff --git a/examples/eventdev_pipeline/main.c
> >b/examples/eventdev_pipeline/main.c
> >index 823f8b51c..fdbaf667b 100644
> >--- a/examples/eventdev_pipeline/main.c
> >+++ b/examples/eventdev_pipeline/main.c
> >@@ -280,7 +280,6 @@ static void
> > signal_handler(int signum)
> > {
> > static uint8_t once;
> >- uint16_t portid;
> >
> > if (fdata->done)
> > rte_exit(1, "Exiting on signal %d\n", signum); @@ -291,17
> +290,6 @@
> >signal_handler(int signum)
> > rte_event_dev_dump(0, stdout);
> > once = 1;
> > fdata->done = 1;
> >- rte_smp_wmb();
> >-
> >- RTE_ETH_FOREACH_DEV(portid) {
> >- rte_event_eth_rx_adapter_stop(portid);
> >- rte_event_eth_tx_adapter_stop(portid);
> >- if (rte_eth_dev_stop(portid) < 0)
> >- printf("Failed to stop port %u", portid);
> >- }
> >-
> >- rte_eal_mp_wait_lcore();
> >-
> > }
> > if (signum == SIGTSTP)
> > rte_event_dev_dump(0, stdout);
> >@@ -465,6 +453,10 @@ main(int argc, char **argv)
> > }
> >
> > RTE_ETH_FOREACH_DEV(portid) {
> >+ rte_event_eth_rx_adapter_stop(portid);
> >+ rte_event_eth_tx_adapter_stop(portid);
> >+ if (rte_eth_dev_stop(portid) < 0)
> >+ printf("Failed to stop port %u", portid);
> > rte_eth_dev_close(portid);
> > }
> >
> >--
> >2.25.1
next prev parent reply other threads:[~2021-01-14 6:24 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-12-21 5:34 [dpdk-stable] [PATCH] examples/eventdev: move eth stop to the end Feifei Wang
2020-12-21 9:32 ` [dpdk-stable] [PATCH v2] " Feifei Wang
2020-12-21 9:56 ` [dpdk-stable] [PATCH] " Van Haaren, Harry
2020-12-22 5:31 ` [dpdk-stable] 回复: " Feifei Wang
2021-01-05 5:14 ` [dpdk-stable] [PATCH v3] examples/eventdev: refactor ethdev port stop Feifei Wang
2021-01-05 10:09 ` [dpdk-stable] [EXT] " Pavan Nikhilesh Bhagavatula
2021-01-14 6:24 ` Feifei Wang [this message]
2021-01-14 8:50 ` [dpdk-stable] 回复: " Feifei Wang
[not found] ` <20210114103101.738262-1-feifei.wang2@arm.com>
2021-01-14 10:30 ` [dpdk-stable] [PATCH v4 1/3] doc: fix core enabled bug for eventdev pipeline example Feifei Wang
2021-01-14 10:31 ` [dpdk-stable] [PATCH v4 2/3] examples/eventdev: add info output for main core Feifei Wang
2021-01-14 10:31 ` [dpdk-stable] [PATCH v4 3/3] examples/eventdev: move eth stop to the end Feifei Wang
2021-01-25 17:51 ` [dpdk-stable] [EXT] " Pavan Nikhilesh Bhagavatula
2021-01-26 13:37 ` [dpdk-stable] [dpdk-dev] " Jerin Jacob
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=DBBPR08MB441108E37ABB790273F5E3D1C8A80@DBBPR08MB4411.eurprd08.prod.outlook.com \
--to=feifei.wang2@arm.com \
--cc=Honnappa.Nagarahalli@arm.com \
--cc=Ruifeng.Wang@arm.com \
--cc=dev@dpdk.org \
--cc=harry.van.haaren@intel.com \
--cc=jerinj@marvell.com \
--cc=nd@arm.com \
--cc=nikhil.rao@intel.com \
--cc=pbhagavatula@caviumnetworks.com \
--cc=pbhagavatula@marvell.com \
--cc=stable@dpdk.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).