From: "Kavanagh, Mark B" <mark.b.kavanagh@intel.com>
To: Yuanhan Liu <yuanhan.liu@linux.intel.com>
Cc: Dey <sodey@sonusnet.com>,
"stephen@networkplumber.org" <stephen@networkplumber.org>,
"dev@dpdk.org" <dev@dpdk.org>
Subject: Re: [dpdk-dev] [PATCH v7] net/virtio: add set_mtu in virtio
Date: Tue, 11 Oct 2016 08:12:26 +0000 [thread overview]
Message-ID: <DC5AD7FA266D86499789B1BCAEC715F85C726819@irsmsx105.ger.corp.intel.com> (raw)
In-Reply-To: <20161011040119.GJ1597@yliu-dev.sh.intel.com>
>-----Original Message-----
>From: Yuanhan Liu [mailto:yuanhan.liu@linux.intel.com]
>Sent: Tuesday, October 11, 2016 5:01 AM
>To: Kavanagh, Mark B <mark.b.kavanagh@intel.com>
>Cc: Dey <sodey@sonusnet.com>; stephen@networkplumber.org; dev@dpdk.org
>Subject: Re: [PATCH v7] net/virtio: add set_mtu in virtio
>
>On Mon, Oct 10, 2016 at 10:49:22AM +0000, Kavanagh, Mark B wrote:
>> >
>> >On Thu, Sep 29, 2016 at 04:31:30PM -0400, Dey wrote:
>> >> /*
>> >> * dev_ops for virtio, bare necessities for basic operation
>> >> */
>> >> @@ -677,7 +685,6 @@ static const struct eth_dev_ops virtio_eth_dev_ops = {
>> >> .allmulticast_enable = virtio_dev_allmulticast_enable,
>> >> .allmulticast_disable = virtio_dev_allmulticast_disable,
>> >> + .mtu_set = virtio_mtu_set,
>> >> .dev_infos_get = virtio_dev_info_get,
>> >> .stats_get = virtio_dev_stats_get,
>> >> .xstats_get = virtio_dev_xstats_get,
>> >> --
>> >> 2.9.3.windows.1
>> >
>> >Your patch is malformed: I got an error while trying to apply it.
>> >
>> > patch: **** malformed patch at line 167: * dev_ops for virtio,
>> > bare necessities for basic operation
>> >
>> >Seems like the way you were generating the patch is wrong.
>> >
>> >Anyway, I applied it manually, with the "- frame_size" fix as well
>> >as few more minor coding style fixes.
>> >
>> >So applied to dpdk-next-virtio.
>>
>> Hi Yuanhan/Souvik,
>>
>> Given my contributions to this patch (and in particular since comments from here -
>http://dpdk.org/ml/archives/dev/2016-September/047208.html - were copied directly into the
>commit message), I think that I should have been added as co-author of the patch?
>
>Mark,
>
>I appreciate your contributions here. But for this case, I think it
>might not be enough for adding you as the co-author: you don't co-write
>the code with Souvik after all.
>
>However, I'd suggest you to add your "Reviewed-by" if a patch looks to
>you after your review effort. This is another way to recognize your
>contributions to a patch.
No problem Yuanhan - thanks for clarifying.
Reviewed-by: Mark Kavanagh <mark.b.kavanagh@intel.com>
>
>Thanks.
>
> --yliu
>
>
>>
>> Let me know if you think that I am mistaken.
>>
>> Thanks in advance,
>> Mark
>> >
>> > --yliu
prev parent reply other threads:[~2016-10-11 8:13 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-09-16 17:13 [dpdk-dev] [PATCH v5]net/virtio: add mtu set " souvikdey33
2016-09-21 15:22 ` Kavanagh, Mark B
2016-09-22 13:56 ` [dpdk-dev] [PATCH v6] net/virtio: add set_mtu " Dey
2016-09-29 20:31 ` [dpdk-dev] [PATCH v7] " Dey
2016-10-01 14:08 ` Dey, Souvik
2016-10-04 23:18 ` Dey, Souvik
2016-10-05 8:15 ` Kavanagh, Mark B
2016-10-05 14:05 ` Dey, Souvik
2016-10-06 13:39 ` Dey, Souvik
2016-10-06 13:58 ` Kavanagh, Mark B
2016-10-06 22:29 ` Stephen Hemminger
2016-10-07 2:06 ` Dey, Souvik
2016-10-09 3:52 ` Yuanhan Liu
2016-10-10 10:49 ` Kavanagh, Mark B
2016-10-11 4:01 ` Yuanhan Liu
2016-10-11 8:12 ` Kavanagh, Mark B [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=DC5AD7FA266D86499789B1BCAEC715F85C726819@irsmsx105.ger.corp.intel.com \
--to=mark.b.kavanagh@intel.com \
--cc=dev@dpdk.org \
--cc=sodey@sonusnet.com \
--cc=stephen@networkplumber.org \
--cc=yuanhan.liu@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).