From: "Tummala, Sivaprasad" <Sivaprasad.Tummala@amd.com>
To: "Morten Brørup" <mb@smartsharesystems.com>,
"david.marchand@redhat.com" <david.marchand@redhat.com>,
"ktraynor@redhat.com" <ktraynor@redhat.com>,
"thomas@monjalon.net" <thomas@monjalon.net>,
"konstantin.ananyev@huawei.com" <konstantin.ananyev@huawei.com>,
"konstantin.v.ananyev@yandex.ru" <konstantin.v.ananyev@yandex.ru>,
"bruce.richardson@intel.com" <bruce.richardson@intel.com>,
"maxime.coquelin@redhat.com" <maxime.coquelin@redhat.com>,
"aconole@redhat.com" <aconole@redhat.com>,
"Yigit, Ferruh" <Ferruh.Yigit@amd.com>
Cc: "dev@dpdk.org" <dev@dpdk.org>
Subject: RE: [PATCH] config/x86: config support for AMD EPYC processors
Date: Wed, 20 Dec 2023 09:22:52 +0000 [thread overview]
Message-ID: <DM3PR12MB9286A42975A8547A2C1388DB8696A@DM3PR12MB9286.namprd12.prod.outlook.com> (raw)
In-Reply-To: <98CBD80474FA8B44BF855DF32C47DC35E9F0E2@smartserver.smartshare.dk>
[AMD Official Use Only - General]
Hi Morten,
> -----Original Message-----
> From: Morten Brørup <mb@smartsharesystems.com>
> Sent: Wednesday, December 20, 2023 12:58 PM
> To: Tummala, Sivaprasad <Sivaprasad.Tummala@amd.com>;
> david.marchand@redhat.com; ktraynor@redhat.com; thomas@monjalon.net;
> konstantin.ananyev@huawei.com; konstantin.v.ananyev@yandex.ru;
> bruce.richardson@intel.com; maxime.coquelin@redhat.com;
> aconole@redhat.com; Yigit, Ferruh <Ferruh.Yigit@amd.com>
> Cc: dev@dpdk.org
> Subject: RE: [PATCH] config/x86: config support for AMD EPYC processors
>
> Caution: This message originated from an External Source. Use proper caution
> when opening attachments, clicking links, or responding.
>
>
> > From: Sivaprasad Tummala [mailto:sivaprasad.tummala@amd.com]
> > Sent: Wednesday, 20 December 2023 08.11
> >
> > On x86 platforms, max lcores are limited to 128 by default.
> >
> > On AMD EPYC processors, this limit was adjusted for native builds in
> > the previous patch.
> > https://patches.dpdk.org/project/dpdk/patch/
> > 20230925151027.558546-1-sivaprasad.tummala@amd.com/
> >
> > As agreed earlier in mailing list, this patch adjusts the limit for
> > specific AMD EPYC target/cross builds.
> >
> > Signed-off-by: Sivaprasad Tummala <sivaprasad.tummala@amd.com>
> > ---
>
> [...]
>
> > + foreach m:epyc_zen_cores.keys()
> > + if m.contains(cpu_instruction_set)
> > + dpdk_conf.set('RTE_MAX_LCORE', epyc_zen_cores[m])
> > + break
>
> The indentation of "break" uses a mix of tab and spaces, and should be fixed.
Thanks for spotting this. Will fix this in v2.
>
> Acked-by: Morten Brørup <mb@smartsharesystems.com>
next prev parent reply other threads:[~2023-12-20 9:22 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-12-20 7:10 Sivaprasad Tummala
2023-12-20 7:27 ` Morten Brørup
2023-12-20 9:22 ` Tummala, Sivaprasad [this message]
2023-12-21 5:11 ` [PATCH v2] " Sivaprasad Tummala
2024-01-02 18:18 ` Konstantin Ananyev
2024-02-13 14:28 ` Thomas Monjalon
-- strict thread matches above, loose matches on Subject: below --
2023-09-25 15:10 [PATCH] " Sivaprasad Tummala
2023-10-06 7:50 ` David Marchand
2023-10-16 5:14 ` Tummala, Sivaprasad
2023-10-16 5:20 ` Tummala, Sivaprasad
2023-10-17 9:45 ` Kevin Traynor
2023-10-17 10:27 ` Morten Brørup
2023-11-06 21:05 ` Thomas Monjalon
2023-11-06 22:17 ` Morten Brørup
2023-11-07 13:13 ` Konstantin Ananyev
2023-11-07 13:30 ` Morten Brørup
2023-11-07 14:32 ` Konstantin Ananyev
2023-11-08 12:24 ` Tummala, Sivaprasad
2023-11-08 13:06 ` Morten Brørup
2023-11-09 16:43 ` Konstantin Ananyev
2023-10-17 10:58 ` Ferruh Yigit
2023-11-07 12:59 ` Konstantin Ananyev
2023-11-12 13:48 ` Thomas Monjalon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=DM3PR12MB9286A42975A8547A2C1388DB8696A@DM3PR12MB9286.namprd12.prod.outlook.com \
--to=sivaprasad.tummala@amd.com \
--cc=Ferruh.Yigit@amd.com \
--cc=aconole@redhat.com \
--cc=bruce.richardson@intel.com \
--cc=david.marchand@redhat.com \
--cc=dev@dpdk.org \
--cc=konstantin.ananyev@huawei.com \
--cc=konstantin.v.ananyev@yandex.ru \
--cc=ktraynor@redhat.com \
--cc=maxime.coquelin@redhat.com \
--cc=mb@smartsharesystems.com \
--cc=thomas@monjalon.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).