From: "Tummala, Sivaprasad" <Sivaprasad.Tummala@amd.com>
To: "christian.ehrhardt@canonical.com"
<christian.ehrhardt@canonical.com>, dev <dev@dpdk.org>,
Thomas Monjalon <thomas@monjalon.net>
Cc: Luca Boccassi <bluca@debian.org>
Subject: RE: [PATCH] build: riscv is not a valid -march value
Date: Wed, 22 Nov 2023 13:27:05 +0000 [thread overview]
Message-ID: <DM3PR12MB9286E3E975FBAFDC3BC1007C86BAA@DM3PR12MB9286.namprd12.prod.outlook.com> (raw)
In-Reply-To: <20231121164903.3982163-1-christian.ehrhardt@canonical.com>
[AMD Official Use Only - General]
> -----Original Message-----
> From: christian.ehrhardt@canonical.com <christian.ehrhardt@canonical.com>
> Sent: Tuesday, November 21, 2023 10:19 PM
> To: dev <dev@dpdk.org>; Thomas Monjalon <thomas@monjalon.net>
> Cc: Luca Boccassi <bluca@debian.org>; Christian Ehrhardt
> <christian.ehrhardt@canonical.com>
> Subject: [PATCH] build: riscv is not a valid -march value
>
> Caution: This message originated from an External Source. Use proper caution
> when opening attachments, clicking links, or responding.
>
>
> From: Christian Ehrhardt <christian.ehrhardt@canonical.com>
>
> If building riscv natively with -Dplatform=generic config/meson.build will select
> cpu_instruction_set=riscv.
>
> That was fine because config/riscv/meson.build did override it to valid values later,
> but since b7676fcccab4 ("config: verify machine arch
> flag") it will break the build as it tries to test -march=riscv which is not a value
> value.
>
> The generic setting used in most cases is rv64gc, set this here as well.
>
> Fixes: b7676fcccab4 ("config: verify machine arch flag"
> Fixes: f22e705ebf12 ("eal/riscv: support RISC-V architecture")
>
> Signed-off-by: Christian Ehrhardt <christian.ehrhardt@canonical.com>
> ---
> config/meson.build | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/config/meson.build b/config/meson.build index
> d732154731..a9ccd56deb 100644
> --- a/config/meson.build
> +++ b/config/meson.build
> @@ -152,7 +152,7 @@ if cpu_instruction_set == 'generic'
> elif host_machine.cpu_family().startswith('ppc')
> cpu_instruction_set = 'power8'
> elif host_machine.cpu_family().startswith('riscv')
> - cpu_instruction_set = 'riscv'
> + cpu_instruction_set = 'rv64gc'
> endif
> endif
>
> --
> 2.34.1
LGTM!
Acked-by: Sivaprasad Tummala <sivaprasad.tummala@amd.com>
next prev parent reply other threads:[~2023-11-22 13:27 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-11-21 16:49 christian.ehrhardt
2023-11-22 13:27 ` Tummala, Sivaprasad [this message]
2023-11-22 16:02 ` David Marchand
2023-11-22 16:17 ` Bruce Richardson
2023-11-22 16:41 ` David Marchand
2024-01-05 15:50 ` Stanisław Kardach
2023-11-22 16:39 ` David Marchand
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=DM3PR12MB9286E3E975FBAFDC3BC1007C86BAA@DM3PR12MB9286.namprd12.prod.outlook.com \
--to=sivaprasad.tummala@amd.com \
--cc=bluca@debian.org \
--cc=christian.ehrhardt@canonical.com \
--cc=dev@dpdk.org \
--cc=thomas@monjalon.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).