From: "Li, Xiaoyun" <xiaoyun.li@intel.com>
To: "Yigit, Ferruh" <ferruh.yigit@intel.com>,
Viacheslav Ovsiienko <viacheslavo@nvidia.com>,
"Wei Hu (Xavier)" <xavier.huwei@huawei.com>,
Chengchang Tang <tangchengchang@huawei.com>
Cc: "dev@dpdk.org" <dev@dpdk.org>,
"stable@dpdk.org" <stable@dpdk.org>,
"Andrew Boyer" <aboyer@pensando.io>
Subject: Re: [dpdk-stable] [PATCH v2] app/testpmd: fix segment number check
Date: Mon, 26 Apr 2021 11:23:50 +0000 [thread overview]
Message-ID: <DM4PR11MB5534365F8E1295CDD036972599429@DM4PR11MB5534.namprd11.prod.outlook.com> (raw)
In-Reply-To: <20210423160952.336272-1-ferruh.yigit@intel.com>
Hi
> -----Original Message-----
> From: Yigit, Ferruh <ferruh.yigit@intel.com>
> Sent: Saturday, April 24, 2021 00:10
> To: Viacheslav Ovsiienko <viacheslavo@nvidia.com>; Li, Xiaoyun
> <xiaoyun.li@intel.com>; Wei Hu (Xavier) <xavier.huwei@huawei.com>;
> Chengchang Tang <tangchengchang@huawei.com>
> Cc: Yigit, Ferruh <ferruh.yigit@intel.com>; dev@dpdk.org; stable@dpdk.org;
> Andrew Boyer <aboyer@pensando.io>
> Subject: [PATCH v2] app/testpmd: fix segment number check
>
> From: Viacheslav Ovsiienko <viacheslavo@nvidia.com>
>
> The --txpkts command line parameter was silently ignored due to application
> was unable to check the Tx queue ring sizes for non configured ports [1].
Remove this [1] or mark the following items as [1] [2] [3].
>
> The "set txpkts <len0[,len1]*>" was also rejected if there was some stopped or
> /unconfigured port.
>
> This provides the following:
>
> - If fails to get ring size from the port, this can be because port is
> not initialized yet, ignore the check and just be sure segment size
> won't cause an out of bound access. The port descriptor check will
> be done during Tx setup.
>
> - The capability to send single packet is supposed to be very basic
> and always supported, the setting segment number to 1 is always
> allowed, no check performed
>
> - At the moment of Tx queue setup the descriptor number is checked
> against configured segment number
>
> Bugzilla ID: 584
> Fixes: 8dae835d88b7 ("app/testpmd: remove restriction on Tx segments set")
> Cc: stable@dpdk.org
>
> Signed-off-by: Viacheslav Ovsiienko <viacheslavo@nvidia.com>
> Signed-off-by: Ferruh Yigit <ferruh.yigit@intel.com>
> ---
> Cc: Andrew Boyer <aboyer@pensando.io>
>
> v2:
> * Become more flexible for the '--txpkts' command line, if not able to
> get the descriptor size from port, ignore the check.
>
> ('nb_txd' check was proposed before, this will require '--txd'
> parameter, but also enforces a specific order on the parameters,
> instead going with the option to flex the checks for parameter.)
> ---
> app/test-pmd/cmdline.c | 4 ++++
> app/test-pmd/config.c | 32 ++++++++++++++++++++++++--------
> 2 files changed, 28 insertions(+), 8 deletions(-)
Except the one comment above for commit log,
Acked-by: Xiaoyun Li <xiaoyun.li@intel.com>
next prev parent reply other threads:[~2021-04-26 11:23 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <dc2efa45-23e1-f974-dbab-775977d094d6@intel.com>
2020-12-11 15:07 ` [dpdk-stable] [PATCH] " Viacheslav Ovsiienko
2020-12-11 16:00 ` [dpdk-stable] [dpdk-dev] " Andrew Boyer
2020-12-11 16:14 ` Slava Ovsiienko
2020-12-16 12:12 ` Ferruh Yigit
2020-12-16 12:33 ` Slava Ovsiienko
2020-12-16 12:36 ` [dpdk-stable] " Ferruh Yigit
2021-04-23 16:09 ` [dpdk-stable] [PATCH v2] " Ferruh Yigit
2021-04-26 11:23 ` Li, Xiaoyun [this message]
2021-04-27 11:42 ` Ferruh Yigit
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=DM4PR11MB5534365F8E1295CDD036972599429@DM4PR11MB5534.namprd11.prod.outlook.com \
--to=xiaoyun.li@intel.com \
--cc=aboyer@pensando.io \
--cc=dev@dpdk.org \
--cc=ferruh.yigit@intel.com \
--cc=stable@dpdk.org \
--cc=tangchengchang@huawei.com \
--cc=viacheslavo@nvidia.com \
--cc=xavier.huwei@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).