DPDK patches and discussions
 help / color / mirror / Atom feed
From: "Li, Xiaoyun" <xiaoyun.li@intel.com>
To: Andrew Rybchenko <andrew.rybchenko@oktetlabs.ru>,
	Ori Kam <orika@nvidia.com>
Cc: "dev@dpdk.org" <dev@dpdk.org>,
	"Richardson, Bruce" <bruce.richardson@intel.com>,
	"Yigit, Ferruh" <ferruh.yigit@intel.com>,
	"Singh, Aman Deep" <aman.deep.singh@intel.com>
Subject: Re: [dpdk-dev] [PATCH v3] app/testpmd: send failure logs to stderr
Date: Fri, 18 Jun 2021 08:32:39 +0000	[thread overview]
Message-ID: <DM4PR11MB5534D4CE90DE9C1A356BA0C0990D9@DM4PR11MB5534.namprd11.prod.outlook.com> (raw)
In-Reply-To: <20210617142026.1133460-1-andrew.rybchenko@oktetlabs.ru>

> -----Original Message-----
> From: Andrew Rybchenko <andrew.rybchenko@oktetlabs.ru>
> Sent: Thursday, June 17, 2021 22:20
> To: Li, Xiaoyun <xiaoyun.li@intel.com>; Ori Kam <orika@nvidia.com>
> Cc: dev@dpdk.org; Richardson, Bruce <bruce.richardson@intel.com>; Yigit,
> Ferruh <ferruh.yigit@intel.com>; Singh, Aman Deep
> <aman.deep.singh@intel.com>
> Subject: [PATCH v3] app/testpmd: send failure logs to stderr
> 
> Running with stdout suppressed or redirected for further processing
> is very confusing in the case of errors. Fix it by logging errors and
> warnings to stderr.
> 
> Since lines with log messages are touched anyway concatenate split
> format strings to make it easier to search using grep.
> 
> Fix indent of format string arguments.
> 
> Signed-off-by: Andrew Rybchenko <andrew.rybchenko@oktetlabs.ru>
> ---
> v3:
>  - fix typo in the patch description
>  - fix applicable coding style issues reported by patchwork
> 
> v2:
>  - switch from printf() to fpritnf(stderr, ...) in more cases
>  - do not inherit acks from the previous version since the patch is
>    much bigger
>  - fix style in few cases (TAB vs spaces, missing space separtor etc)
>  - still don't use TESTPMD_LOG() since the patch does not add new logs.
>    Also switching to TESTPMD_LOG() will add "testpmd: " prefix to log
>    messages and it is a real change and could be a pain for automation.
> 
>  app/test-pmd/bpf_cmd.c                 |   6 +-
>  app/test-pmd/cmdline.c                 | 957 ++++++++++++++-----------
>  app/test-pmd/cmdline_flow.c            |  20 +-
>  app/test-pmd/cmdline_mtr.c             |   8 +-
>  app/test-pmd/cmdline_tm.c              |  33 +-
>  app/test-pmd/config.c                  | 455 ++++++------
>  app/test-pmd/csumonly.c                |   5 +-
>  app/test-pmd/parameters.c              |  21 +-
>  app/test-pmd/testpmd.c                 | 298 ++++----
>  app/test-pmd/util.c                    |  19 +-
>  doc/guides/rel_notes/release_21_08.rst |   5 +
>  11 files changed, 1004 insertions(+), 823 deletions(-)

Acked-by: Xiaoyun Li <xiaoyun.li@intel.com>

  reply	other threads:[~2021-06-18  8:32 UTC|newest]

Thread overview: 20+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-05-27 16:24 [dpdk-dev] [PATCH] " Andrew Rybchenko
2021-06-11  2:06 ` Li, Xiaoyun
2021-06-11  9:19   ` Andrew Rybchenko
2021-06-11 10:35     ` Ferruh Yigit
2021-06-11 13:21       ` Bruce Richardson
2021-06-14 16:47         ` Andrew Rybchenko
2021-06-14 16:56       ` Andrew Rybchenko
2021-06-14 17:49         ` Singh, Aman Deep
2021-06-15  7:59         ` Ferruh Yigit
2021-06-15  8:14           ` Andrew Rybchenko
2021-06-15  8:52             ` Ferruh Yigit
2021-06-15  9:00               ` Andrew Rybchenko
2021-06-15  9:53                 ` Ferruh Yigit
2021-06-16 16:32 ` [dpdk-dev] [PATCH v2] " Andrew Rybchenko
2021-06-17  3:29   ` Li, Xiaoyun
2021-06-17 14:21     ` Andrew Rybchenko
2021-06-17 14:20 ` [dpdk-dev] [PATCH v3] " Andrew Rybchenko
2021-06-18  8:32   ` Li, Xiaoyun [this message]
2021-06-28 11:05     ` Andrew Rybchenko
2021-07-24 13:14     ` Thomas Monjalon

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=DM4PR11MB5534D4CE90DE9C1A356BA0C0990D9@DM4PR11MB5534.namprd11.prod.outlook.com \
    --to=xiaoyun.li@intel.com \
    --cc=aman.deep.singh@intel.com \
    --cc=andrew.rybchenko@oktetlabs.ru \
    --cc=bruce.richardson@intel.com \
    --cc=dev@dpdk.org \
    --cc=ferruh.yigit@intel.com \
    --cc=orika@nvidia.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).