From: "Zhang, Qi Z" <qi.z.zhang@intel.com>
To: "Zeng, ZhichaoX" <zhichaox.zeng@intel.com>,
"dev@dpdk.org" <dev@dpdk.org>
Cc: "stable@dpdk.org" <stable@dpdk.org>,
"Yang, Qiming" <qiming.yang@intel.com>,
"Zeng, ZhichaoX" <zhichaox.zeng@intel.com>,
"alvinx.zhang@intel.com" <alvinx.zhang@intel.com>,
"Guo, Junfeng" <junfeng.guo@intel.com>,
"Su, Simei" <simei.su@intel.com>,
Ferruh Yigit <ferruh.yigit@intel.com>
Subject: RE: [PATCH v2] net/igc: fix segmentation fault in secondary dpdk-symmetric_mp
Date: Thu, 23 Jun 2022 03:50:37 +0000 [thread overview]
Message-ID: <DM4PR11MB5994032884AA119E62BFB411D7B59@DM4PR11MB5994.namprd11.prod.outlook.com> (raw)
In-Reply-To: <20220622104907.862666-1-zhichaox.zeng@intel.com>
> -----Original Message-----
> From: zhichaox.zeng@intel.com <zhichaox.zeng@intel.com>
> Sent: Wednesday, June 22, 2022 6:49 PM
> To: dev@dpdk.org
> Cc: stable@dpdk.org; Yang, Qiming <qiming.yang@intel.com>; Zeng, ZhichaoX
> <zhichaox.zeng@intel.com>; alvinx.zhang@intel.com; Guo, Junfeng
> <junfeng.guo@intel.com>; Su, Simei <simei.su@intel.com>; Ferruh Yigit
> <ferruh.yigit@intel.com>
> Subject: [PATCH v2] net/igc: fix segmentation fault in secondary dpdk-
> symmetric_mp
>
> From: Zhichao Zeng <zhichaox.zeng@intel.com>
>
> In the secondary dpdk-symmetric_mp process, the "smp_port_init" was
> skipped, which cause some function pointers not to be initialized, and a
> segmentation fault occurred when calling these function pointers.
>
> This patch assigns initial values to rx_pkt_burst, tx_pkt_burst and
> tx_pkt_prepare pointers to avoid calling null function pointer.
>
> Fixes: 66fde1b943eb ("net/igc: add skeleton")
> Cc: alvinx.zhang@intel.com
> Cc: stable@dpdk.org
>
> Signed-off-by: Zhichao Zeng <zhichaox.zeng@intel.com>
>
> ---
> v2:
> remove unnecessary parameters, move declaration to relevant header file
> ---
> drivers/net/igc/igc_ethdev.c | 3 +++
> drivers/net/igc/igc_txrx.c | 6 +++---
> drivers/net/igc/igc_txrx.h | 4 ++++
> 3 files changed, 10 insertions(+), 3 deletions(-)
>
> diff --git a/drivers/net/igc/igc_ethdev.c b/drivers/net/igc/igc_ethdev.c index
> b9933b395d..25fb91bfec 100644
> --- a/drivers/net/igc/igc_ethdev.c
> +++ b/drivers/net/igc/igc_ethdev.c
> @@ -1234,6 +1234,9 @@ eth_igc_dev_init(struct rte_eth_dev *dev)
> dev->rx_queue_count = eth_igc_rx_queue_count;
> dev->rx_descriptor_status = eth_igc_rx_descriptor_status;
> dev->tx_descriptor_status = eth_igc_tx_descriptor_status;
> + dev->rx_pkt_burst = igc_recv_pkts;
> + dev->tx_pkt_burst = igc_xmit_pkts;
> + dev->tx_pkt_prepare = eth_igc_prep_pkts;
If you already assign the function point in dev_init, you should remove the following redundant code.
next prev parent reply other threads:[~2022-06-23 3:50 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20220615073915.13309-1-zhichaox.zeng@intel.com>
2022-06-22 10:49 ` zhichaox.zeng
2022-06-23 3:50 ` Zhang, Qi Z [this message]
2022-06-28 6:20 ` [PATCH v3] net/igc: move the initialization of data path into dev_init zhichaox.zeng
2022-06-28 7:00 ` Zhang, Qi Z
2022-06-30 11:03 ` [PATCH v4] net/igc: add support for secondary processes zhichaox.zeng
2022-06-30 11:47 ` Zhang, Qi Z
2022-07-01 3:13 ` Zeng, ZhichaoX
2022-07-01 3:47 ` Zhang, Qi Z
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=DM4PR11MB5994032884AA119E62BFB411D7B59@DM4PR11MB5994.namprd11.prod.outlook.com \
--to=qi.z.zhang@intel.com \
--cc=alvinx.zhang@intel.com \
--cc=dev@dpdk.org \
--cc=ferruh.yigit@intel.com \
--cc=junfeng.guo@intel.com \
--cc=qiming.yang@intel.com \
--cc=simei.su@intel.com \
--cc=stable@dpdk.org \
--cc=zhichaox.zeng@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).