From: "Zhang, Qi Z" <qi.z.zhang@intel.com>
To: "He, ShiyangX" <shiyangx.he@intel.com>, "dev@dpdk.org" <dev@dpdk.org>
Cc: "Zhou, YidingX" <yidingx.zhou@intel.com>,
"He, ShiyangX" <shiyangx.he@intel.com>,
"Wang, Liang-min" <liang-min.wang@intel.com>,
"Zhang, Yuying" <yuying.zhang@intel.com>,
"Xing, Beilei" <beilei.xing@intel.com>,
"Su, Simei" <simei.su@intel.com>,
"Wu, Wenjun1" <wenjun1.wu@intel.com>,
"Yang, Qiming" <qiming.yang@intel.com>,
"Wu, Jingjing" <jingjing.wu@intel.com>
Subject: RE: [PATCH v4] net/iavf: add devargs to enable vf auto-reset
Date: Tue, 26 Sep 2023 04:51:50 +0000 [thread overview]
Message-ID: <DM4PR11MB5994327B96DFE854554686B1D7C3A@DM4PR11MB5994.namprd11.prod.outlook.com> (raw)
In-Reply-To: <20230926113137.3861198-1-shiyangx.he@intel.com>
> -----Original Message-----
> From: Shiyang He <shiyangx.he@intel.com>
> Sent: Tuesday, September 26, 2023 7:32 PM
> To: dev@dpdk.org
> Cc: Zhou, YidingX <yidingx.zhou@intel.com>; He, ShiyangX
> <shiyangx.he@intel.com>; Wang, Liang-min <liang-min.wang@intel.com>;
> Zhang, Yuying <yuying.zhang@intel.com>; Xing, Beilei
> <beilei.xing@intel.com>; Su, Simei <simei.su@intel.com>; Wu, Wenjun1
> <wenjun1.wu@intel.com>; Yang, Qiming <qiming.yang@intel.com>; Wu,
> Jingjing <jingjing.wu@intel.com>
> Subject: [PATCH v4] net/iavf: add devargs to enable vf auto-reset
>
> Originally, the iavf PMD does not perform special actions when it receives a
> PF-to-VF reset event, resulting in vf being offline and unavailable.
>
> This patch enables vf auto-reset by setting 'watchdog_period' devargs to true.
> The iavf PMD will perform an automatic reset to bring the vf back online
> when it receives a PF-to-VF event.
>
> v2: handling reset by event handler
> v3: change reset process
> v3: rebase
>
> Signed-off-by: Shiyang He <shiyangx.he@intel.com>
> Signed-off-by: Liang-Min Larry Wang <liang-min.wang@intel.com>
> ---
> doc/guides/nics/intel_vf.rst | 3 +
> doc/guides/rel_notes/release_23_11.rst | 3 +
> drivers/net/iavf/iavf.h | 7 +++
> drivers/net/iavf/iavf_ethdev.c | 86 +++++++++++++++++++++++---
> drivers/net/iavf/iavf_rxtx.c | 52 ++++++++++------
> drivers/net/iavf/iavf_vchnl.c | 11 +++-
> 6 files changed, 135 insertions(+), 27 deletions(-)
>
> diff --git a/doc/guides/nics/intel_vf.rst b/doc/guides/nics/intel_vf.rst index
> d365dbc185..c0acd2a7f5 100644
> --- a/doc/guides/nics/intel_vf.rst
> +++ b/doc/guides/nics/intel_vf.rst
> @@ -101,6 +101,9 @@ For more detail on SR-IOV, please refer to the
> following documents:
> Set ``devargs`` parameter ``watchdog_period`` to adjust the watchdog
> period in microseconds, or set it to 0 to disable the watchdog,
> for example, ``-a 18:01.0,watchdog_period=5000`` or ``-a
> 18:01.0,watchdog_period=0``.
>
> + Enable vf auto-reset by setting the ``devargs`` parameter like ``-a
> 18:01.0,enable_auto_reset=1`` when IAVF is backed
The argument enable_auto_reset=1 seems somewhat redundant; why not simply use auto_reset=1 instead?
Otherwise
Acked-by: Qi Zhang <qi.z.zhang@intel.com>
next prev parent reply other threads:[~2023-09-26 4:52 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-08-01 9:48 [PATCH] " Shiyang He
2023-08-11 9:40 ` [PATCH v2] " Shiyang He
2023-09-15 13:02 ` [PATCH v3] " Shiyang He
2023-09-26 7:48 ` Bruce Richardson
2023-09-26 12:15 ` Zhang, Qi Z
2023-09-26 14:05 ` Bruce Richardson
2023-09-26 23:41 ` Zhang, Qi Z
2023-09-27 6:39 ` David Marchand
2023-09-26 11:31 ` [PATCH v4] " Shiyang He
2023-09-26 4:51 ` Zhang, Qi Z [this message]
2023-09-26 12:29 ` [PATCH v5] " Shiyang He
2023-09-26 12:31 ` Shiyang He
2023-09-26 12:38 ` Shiyang He
2023-09-26 5:33 ` Zhang, Qi Z
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=DM4PR11MB5994327B96DFE854554686B1D7C3A@DM4PR11MB5994.namprd11.prod.outlook.com \
--to=qi.z.zhang@intel.com \
--cc=beilei.xing@intel.com \
--cc=dev@dpdk.org \
--cc=jingjing.wu@intel.com \
--cc=liang-min.wang@intel.com \
--cc=qiming.yang@intel.com \
--cc=shiyangx.he@intel.com \
--cc=simei.su@intel.com \
--cc=wenjun1.wu@intel.com \
--cc=yidingx.zhou@intel.com \
--cc=yuying.zhang@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).