From: "Zhang, Qi Z" <qi.z.zhang@intel.com>
To: "Zhang, Peng1X" <peng1x.zhang@intel.com>,
"Yang, Qiming" <qiming.yang@intel.com>,
"dev@dpdk.org" <dev@dpdk.org>
Subject: RE: [PATCH v6] net/ice: add retry mechanism for DCF after failure
Date: Thu, 7 Jul 2022 06:55:45 +0000 [thread overview]
Message-ID: <DM4PR11MB5994494F25FC31F9CD3CF1EAD7839@DM4PR11MB5994.namprd11.prod.outlook.com> (raw)
In-Reply-To: <20220706141709.7681-1-peng1x.zhang@intel.com>
> -----Original Message-----
> From: Zhang, Peng1X <peng1x.zhang@intel.com>
> Sent: Wednesday, July 6, 2022 10:17 PM
> To: Yang, Qiming <qiming.yang@intel.com>; Zhang, Qi Z
> <qi.z.zhang@intel.com>; dev@dpdk.org
> Subject: [PATCH v6] net/ice: add retry mechanism for DCF after failure
>
> From: Peng Zhang <peng1x.zhang@intel.com>
>
> The origin design is if error happen during the step 3 of given situation, it will
> return error directly without retry. While in current patch, it will retry at every
> interval time during certain time if receive designed error code
> 'VIRTCHNL_STATUS_ERR_RETRY'
> from kernel. If retry succeed, rule can be continuously created.
>
> The given situation as following steps show:
> step 1. Kernel PF and DPDK DCF are ready at the beginning.
> step 2. A VF reset happen, kernel send an event to DCF and set STATE to pause.
> step 3. Before DCF receive the event, it is possible a rule creation is ongoing
> and virtual channel command from DCF to kernel PF is executing.
> step 4. Then result of command is failure, it will lead to error code return to
> DCF. Error code will be set as EINVAL, not EAGAIN.
>
> Fixes: daa714d55c72 ("net/ice: handle AdminQ command by DCF")
> Cc: stable@dpdk.org
>
> Signed-off-by: Peng Zhang <peng1x.zhang@intel.com>
> ---
> v6 changes:
> - Add retry mechanism for DCF if receive designed error code from kernel.
> v5 changes:
> - Add retry mechanism for DCF if the result of sending virtual channel
> command is failure.
> v4 changes:
> - Add retry mechanism if the result of sending adminQ queue command is
> failure.
> v3 Changes:
> - Add the situation description, expected error code and incorrect
> error code in commit log.
> v2 Changes:
> - Modify DCF state checking mechanism.
>
> drivers/common/iavf/virtchnl.h | 1 +
> drivers/net/ice/ice_dcf.c | 32 ++++++++++++++++++++------------
> 2 files changed, 21 insertions(+), 12 deletions(-)
>
> diff --git a/drivers/common/iavf/virtchnl.h b/drivers/common/iavf/virtchnl.h
> index f123daec8e..e15e3a4439 100644
> --- a/drivers/common/iavf/virtchnl.h
> +++ b/drivers/common/iavf/virtchnl.h
> @@ -49,6 +49,7 @@ enum virtchnl_status_code {
> VIRTCHNL_STATUS_ERR_CQP_COMPL_ERROR = -39,
> VIRTCHNL_STATUS_ERR_INVALID_VF_ID = -40,
> VIRTCHNL_STATUS_ERR_ADMIN_QUEUE_ERROR = -53,
> + VIRTCHNL_STATUS_ERR_RETRY = -63,
Where this error code be used?
next prev parent reply other threads:[~2022-07-07 6:55 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-07-06 14:17 peng1x.zhang
2022-07-07 6:55 ` Zhang, Qi Z [this message]
2022-07-29 10:14 ` Zhang, Peng1X
2022-08-01 5:44 ` Zhou, YidingX
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=DM4PR11MB5994494F25FC31F9CD3CF1EAD7839@DM4PR11MB5994.namprd11.prod.outlook.com \
--to=qi.z.zhang@intel.com \
--cc=dev@dpdk.org \
--cc=peng1x.zhang@intel.com \
--cc=qiming.yang@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).