From: "Zhang, Qi Z" <qi.z.zhang@intel.com>
To: "Wu, WenxuanX" <wenxuanx.wu@intel.com>,
"Yang, Qiming" <qiming.yang@intel.com>,
"dev@dpdk.org" <dev@dpdk.org>,
"thomas@monjalon.net" <thomas@monjalon.net>
Cc: "stephen@networkplumber.org" <stephen@networkplumber.org>,
"stable@dpdk.org" <stable@dpdk.org>
Subject: RE: [PATCH] ice/base: fix gcc 12 warning stringop-overflow
Date: Sun, 19 Jun 2022 12:34:53 +0000 [thread overview]
Message-ID: <DM4PR11MB59945F3815EB93984B62E236D7B19@DM4PR11MB5994.namprd11.prod.outlook.com> (raw)
In-Reply-To: <20220616103304.132368-1-wenxuanx.wu@intel.com>
> -----Original Message-----
> From: Wu, WenxuanX <wenxuanx.wu@intel.com>
> Sent: Thursday, June 16, 2022 6:33 PM
> To: Yang, Qiming <qiming.yang@intel.com>; Zhang, Qi Z
> <qi.z.zhang@intel.com>; dev@dpdk.org; thomas@monjalon.net
> Cc: stephen@networkplumber.org; Wu, WenxuanX <wenxuanx.wu@intel.com>;
> stable@dpdk.org
> Subject: [PATCH] ice/base: fix gcc 12 warning stringop-overflow
>
> From: Wenxuan Wu <wenxuanx.wu@intel.com>
>
> Gcc with -O2 flag, would retrieve the value in one time.
> This patch changed the type of fv_idx in struct ice_recp_grp_entry to align with
> its callers which is also u8 type.
>
> When u8 idx[5] = a value u16 index[4], gcc12 would give this warning, because
> it is not big enough to store the bytes(bigger than 5 bytes) in one time (-O2
> would do it in this way).
>
> Fixes: 04b8ec1ea807 ("net/ice/base: add protocol structures and defines")
> Cc: stable@dpdk.org
> Signed-off-by: Wenxuan Wu <wenxuanx.wu@intel.com>
> ---
> drivers/net/ice/base/ice_protocol_type.h | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/net/ice/base/ice_protocol_type.h
> b/drivers/net/ice/base/ice_protocol_type.h
> index 0e6e5990be..cfe3b62630 100644
> --- a/drivers/net/ice/base/ice_protocol_type.h
> +++ b/drivers/net/ice/base/ice_protocol_type.h
> @@ -421,7 +421,7 @@ struct ice_recp_grp_entry { #define
> ICE_INVAL_CHAIN_IND 0xFF
> u16 rid;
> u8 chain_idx;
> - u16 fv_idx[ICE_NUM_WORDS_RECIPE];
> + u8 fv_idx[ICE_NUM_WORDS_RECIPE];
If you change the data type from u16 to u8 for the FV index, you'd better also change the type of all the symbols to store the same thing. e.g. the parameter "fv_idx" of ice_find_prot_off.
So, what's exactly the issue that GCC 12 reported? can we fix it from the other side without changing a type in the base code?
> u16 fv_mask[ICE_NUM_WORDS_RECIPE];
> struct ice_pref_recipe_group r_group;
> };
> --
> 2.25.1
next prev parent reply other threads:[~2022-06-19 12:35 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-06-16 10:33 wenxuanx.wu
2022-06-16 14:29 ` David Marchand
2022-06-17 1:29 ` Wu, WenxuanX
2022-06-17 5:04 ` David Marchand
2022-06-19 12:34 ` Zhang, Qi Z [this message]
2022-06-20 1:38 ` Wu, WenxuanX
2022-06-20 5:06 ` Wu, WenxuanX
2022-06-23 7:42 ` David Marchand
2022-06-23 9:01 ` [PATCH v2] net/ice/base: " wenxuanx.wu
2022-06-23 9:21 ` Zhang, Qi Z
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=DM4PR11MB59945F3815EB93984B62E236D7B19@DM4PR11MB5994.namprd11.prod.outlook.com \
--to=qi.z.zhang@intel.com \
--cc=dev@dpdk.org \
--cc=qiming.yang@intel.com \
--cc=stable@dpdk.org \
--cc=stephen@networkplumber.org \
--cc=thomas@monjalon.net \
--cc=wenxuanx.wu@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).