From: "Zhang, Qi Z" <qi.z.zhang@intel.com>
To: "Xing, Beilei" <beilei.xing@intel.com>,
"Wu, Wenjun1" <wenjun1.wu@intel.com>,
"dev@dpdk.org" <dev@dpdk.org>,
"Zhang, Yuying" <yuying.zhang@intel.com>
Subject: RE: [PATCH v3] net/cpfl: fix datapath function configuration
Date: Tue, 26 Sep 2023 06:04:35 +0000 [thread overview]
Message-ID: <DM4PR11MB5994959F58569200D0EAF094D7C3A@DM4PR11MB5994.namprd11.prod.outlook.com> (raw)
In-Reply-To: <LV2PR11MB5997682DA2F9C7E06115E0FAF7C3A@LV2PR11MB5997.namprd11.prod.outlook.com>
> -----Original Message-----
> From: Xing, Beilei <beilei.xing@intel.com>
> Sent: Tuesday, September 26, 2023 2:00 PM
> To: Wu, Wenjun1 <wenjun1.wu@intel.com>; dev@dpdk.org; Zhang, Yuying
> <yuying.zhang@intel.com>; Zhang, Qi Z <qi.z.zhang@intel.com>
> Subject: RE: [PATCH v3] net/cpfl: fix datapath function configuration
>
>
>
> > -----Original Message-----
> > From: Wu, Wenjun1 <wenjun1.wu@intel.com>
> > Sent: Tuesday, September 26, 2023 2:05 PM
> > To: dev@dpdk.org; Zhang, Yuying <yuying.zhang@intel.com>; Xing, Beilei
> > <beilei.xing@intel.com>; Zhang, Qi Z <qi.z.zhang@intel.com>
> > Cc: Wu, Wenjun1 <wenjun1.wu@intel.com>
> > Subject: [PATCH v3] net/cpfl: fix datapath function configuration
> >
> > Vector datapath does not support any advanced features for now, so
> > disable vector path if TX checksum offload or RX scatter is enabled.
> >
> > Fixes: 2f39845891e6 ("net/cpfl: add AVX512 data path for single queue
> > model")
> >
> > Signed-off-by: Wenjun Wu <wenjun1.wu@intel.com>
> >
> > ---
> > v3: fix log typo.
> > v2: disable vector path for scatter cases.
> > ---
> > drivers/net/cpfl/cpfl_rxtx_vec_common.h | 9 ++++++++-
> > 1 file changed, 8 insertions(+), 1 deletion(-)
> >
> > diff --git a/drivers/net/cpfl/cpfl_rxtx_vec_common.h
> > b/drivers/net/cpfl/cpfl_rxtx_vec_common.h
> > index d8e9191196..479e1ddcb9 100644
> > --- a/drivers/net/cpfl/cpfl_rxtx_vec_common.h
> > +++ b/drivers/net/cpfl/cpfl_rxtx_vec_common.h
> > @@ -25,7 +25,11 @@
> > RTE_ETH_RX_OFFLOAD_TIMESTAMP)
> > #define CPFL_TX_NO_VECTOR_FLAGS ( \
> > RTE_ETH_TX_OFFLOAD_TCP_TSO | \
> > - RTE_ETH_TX_OFFLOAD_MULTI_SEGS)
> > + RTE_ETH_TX_OFFLOAD_MULTI_SEGS | \
> > + RTE_ETH_TX_OFFLOAD_IPV4_CKSUM | \
> > + RTE_ETH_TX_OFFLOAD_SCTP_CKSUM | \
> > + RTE_ETH_TX_OFFLOAD_UDP_CKSUM | \
> > + RTE_ETH_TX_OFFLOAD_TCP_CKSUM)
> >
> > static inline int
> > cpfl_rx_vec_queue_default(struct idpf_rx_queue *rxq) @@ -81,6 +85,9
> > @@ cpfl_rx_vec_dev_check_default(struct rte_eth_dev *dev)
> > struct cpfl_rx_queue *cpfl_rxq;
> > int i, default_ret, splitq_ret, ret = CPFL_SCALAR_PATH;
> >
> > + if (dev->data->scattered_rx)
> > + return CPFL_SCALAR_PATH;
> > +
> > for (i = 0; i < dev->data->nb_rx_queues; i++) {
> > cpfl_rxq = dev->data->rx_queues[i];
> > default_ret = cpfl_rx_vec_queue_default(&cpfl_rxq->base);
> > --
> > 2.34.1
>
> Acked-by: Beilei Xing <beilei.xing@intel.com>
Applied to dpdk-next-net-intel.
Thanks
Qi
prev parent reply other threads:[~2023-09-26 6:04 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-09-19 8:32 [PATCH v1] " Wenjun Wu
2023-09-19 8:49 ` [PATCH v2] " Wenjun Wu
2023-09-26 6:04 ` [PATCH v3] " Wenjun Wu
2023-09-26 6:00 ` Xing, Beilei
2023-09-26 6:04 ` Zhang, Qi Z [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=DM4PR11MB5994959F58569200D0EAF094D7C3A@DM4PR11MB5994.namprd11.prod.outlook.com \
--to=qi.z.zhang@intel.com \
--cc=beilei.xing@intel.com \
--cc=dev@dpdk.org \
--cc=wenjun1.wu@intel.com \
--cc=yuying.zhang@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).