From: "Zhang, Qi Z" <qi.z.zhang@intel.com>
To: "Guo, Junfeng" <junfeng.guo@intel.com>,
David Marchand <david.marchand@redhat.com>
Cc: "Yang, Qiming" <qiming.yang@intel.com>,
"dev@dpdk.org" <dev@dpdk.org>,
"stable@dpdk.org" <stable@dpdk.org>,
"Xu, Ting" <ting.xu@intel.com>
Subject: RE: [PATCH 0/2] fix variable type in pattern parsing for raw flow
Date: Mon, 19 Jun 2023 00:57:29 +0000 [thread overview]
Message-ID: <DM4PR11MB5994ABC3AE3DC44B2EE6C107D75FA@DM4PR11MB5994.namprd11.prod.outlook.com> (raw)
In-Reply-To: <DM6PR11MB3723C6BACA85A9B91D59B5A5E758A@DM6PR11MB3723.namprd11.prod.outlook.com>
> -----Original Message-----
> From: Guo, Junfeng <junfeng.guo@intel.com>
> Sent: Friday, June 16, 2023 2:22 PM
> To: Zhang, Qi Z <qi.z.zhang@intel.com>; David Marchand
> <david.marchand@redhat.com>
> Cc: Yang, Qiming <qiming.yang@intel.com>; dev@dpdk.org; stable@dpdk.org;
> Xu, Ting <ting.xu@intel.com>
> Subject: RE: [PATCH 0/2] fix variable type in pattern parsing for raw flow
>
>
>
> > -----Original Message-----
> > From: Zhang, Qi Z <qi.z.zhang@intel.com>
> > Sent: Friday, June 16, 2023 13:49
> > To: David Marchand <david.marchand@redhat.com>; Guo, Junfeng
> > <junfeng.guo@intel.com>
> > Cc: Yang, Qiming <qiming.yang@intel.com>; dev@dpdk.org;
> > stable@dpdk.org; Xu, Ting <ting.xu@intel.com>
> > Subject: RE: [PATCH 0/2] fix variable type in pattern parsing for raw
> > flow
> >
> >
> >
> > > -----Original Message-----
> > > From: David Marchand <david.marchand@redhat.com>
> > > Sent: Thursday, June 15, 2023 3:28 PM
> > > To: Guo, Junfeng <junfeng.guo@intel.com>
> > > Cc: Zhang, Qi Z <qi.z.zhang@intel.com>; Yang, Qiming
> > > <qiming.yang@intel.com>; dev@dpdk.org; stable@dpdk.org; Xu, Ting
> > > <ting.xu@intel.com>
> > > Subject: Re: [PATCH 0/2] fix variable type in pattern parsing for
> > > raw flow
> > >
> > > On Thu, Jun 15, 2023 at 7:17 AM Junfeng Guo <junfeng.guo@intel.com>
> > > wrote:
> > > >
> > > > In current pattern parsing function for protocol agnostic flow
> > > > offloading (raw flow), some of the variables of packet length are
> > > > defined as uint8_t, which are too small for some large-size
> > > > packets, such as srv6 (Segment Routing over IPv6 dataplane) type.
> > > > Change the type to uint16_t.
> > > >
> > > > For example, the length of below srv6 paket is 268 B, larger than
> > > > the max of uint8_t type (i.e., 256).
> > > >
> > "mac()/ipv6(nextheader=43)/ipv6srh(headerextlength=4,nextheader=41)\
> > > > /ipv6(dst=2001:2:0:0:0:0:0:2)"
> > > >
> > > > Junfeng Guo (2):
> > > > net/ice: fix variable type in pattern parsing for raw flow
> > > > net/iavf: fix variable type in pattern parsing for raw flow
> > >
> > > In the commit title, it is better to describe a functional impact
> > > rather
> > than
> > > repeat the implementation of a fix.
> > >
> > > This makes it easier for people looking for a fix for their specific
> > > issue
> > they
> > > are investigating.
> > > And, on the contrary, it also makes it easier when looking for a
> > regression on
> > > a specific feature.
> > >
> > > Here, "fix variable type" gives no clue that it is linked to packet
> > > length or
> > the
> > > protocol agnostic/raw pattern offloading feature.
> > >
> > > So, I don't understand this part of the code, but I think a better
> > > title
> > would
> > > be:
> > > net/ice: fix protocol agnostic offloading with big packets
> > >
> > > Does it sound ok to you?
> >
> > +1
> > Junfeng, could you comment, if no concern, I will merge patch with
> > the suggested title.
>
> Sure, that sounds good to me!
> Please go ahead with the suggested title.
>
> Thanks David for the comment!
> Yes, it's more reasonable to describe patch with more specific and valid
> words.
Acked-by: Qi Zhang <qi.z.zhang@intel.com>
Applied to dpdk-next-net-intel.
Thanks
Qi
>
> >
> > >
> > >
> > > >
> > > > drivers/net/iavf/iavf_hash.c | 2 +-
> > > > drivers/net/ice/ice_fdir_filter.c | 2 +-
> > > > drivers/net/ice/ice_hash.c | 2 +-
> > > > 3 files changed, 3 insertions(+), 3 deletions(-)
> > > >
> > > > --
> > > > 2.25.1
> > > >
> > >
> > >
> > > --
> > > David Marchand
prev parent reply other threads:[~2023-06-19 0:57 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-06-15 5:17 Junfeng Guo
2023-06-15 5:17 ` [PATCH 1/2] net/ice: " Junfeng Guo
2023-06-15 5:17 ` [PATCH 2/2] net/iavf: " Junfeng Guo
2023-06-15 5:23 ` [PATCH 0/2] " Xu, Ting
2023-06-15 7:28 ` David Marchand
2023-06-16 5:48 ` Zhang, Qi Z
2023-06-16 6:22 ` Guo, Junfeng
2023-06-19 0:57 ` Zhang, Qi Z [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=DM4PR11MB5994ABC3AE3DC44B2EE6C107D75FA@DM4PR11MB5994.namprd11.prod.outlook.com \
--to=qi.z.zhang@intel.com \
--cc=david.marchand@redhat.com \
--cc=dev@dpdk.org \
--cc=junfeng.guo@intel.com \
--cc=qiming.yang@intel.com \
--cc=stable@dpdk.org \
--cc=ting.xu@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).