DPDK patches and discussions
 help / color / mirror / Atom feed
From: "Zhang, Qi Z" <qi.z.zhang@intel.com>
To: "Xing, Beilei" <beilei.xing@intel.com>,
	"Wu, Jingjing" <jingjing.wu@intel.com>
Cc: "dev@dpdk.org" <dev@dpdk.org>, "Wu, Wenjun1" <wenjun1.wu@intel.com>
Subject: RE: [PATCH v2 05/15] common/idpf: add vport init/deinit
Date: Sun, 8 Jan 2023 12:10:47 +0000	[thread overview]
Message-ID: <DM4PR11MB5994B170EF4AA5B5CFE77D19D7F99@DM4PR11MB5994.namprd11.prod.outlook.com> (raw)
In-Reply-To: <20230106091627.13530-6-beilei.xing@intel.com>



> -----Original Message-----
> From: Xing, Beilei <beilei.xing@intel.com>
> Sent: Friday, January 6, 2023 5:16 PM
> To: Wu, Jingjing <jingjing.wu@intel.com>
> Cc: dev@dpdk.org; Zhang, Qi Z <qi.z.zhang@intel.com>; Xing, Beilei
> <beilei.xing@intel.com>; Wu, Wenjun1 <wenjun1.wu@intel.com>
> Subject: [PATCH v2 05/15] common/idpf: add vport init/deinit
> 
> From: Beilei Xing <beilei.xing@intel.com>
> 
> Add vport init/deinit in common module.
> 
> Signed-off-by: Wenjun Wu <wenjun1.wu@intel.com>
> Signed-off-by: Beilei Xing <beilei.xing@intel.com>
> ---
>  drivers/common/idpf/idpf_common_device.c   | 128 +++++++++++++++++++
>  drivers/common/idpf/idpf_common_device.h   |   8 ++
>  drivers/common/idpf/idpf_common_virtchnl.c |  16 +--
>  drivers/common/idpf/idpf_common_virtchnl.h |   2 -
>  drivers/common/idpf/version.map            |   4 +-
>  drivers/net/idpf/idpf_ethdev.c             | 138 ++-------------------
>  6 files changed, 156 insertions(+), 140 deletions(-)
> 
> diff --git a/drivers/common/idpf/idpf_common_device.c
> b/drivers/common/idpf/idpf_common_device.c
> index b2b42443e4..2aad9bcdd3 100644
> --- a/drivers/common/idpf/idpf_common_device.c
> +++ b/drivers/common/idpf/idpf_common_device.c
> @@ -158,4 +158,132 @@ idpf_adapter_deinit(struct idpf_adapter *adapter)
>  	return 0;
>  }
> 
> +int
> +idpf_vport_init(struct idpf_vport *vport,
> +		struct virtchnl2_create_vport *create_vport_info,
> +		void *dev_data)
> +{
> +	struct virtchnl2_create_vport *vport_info;
> +	int i, type, ret;
> +
> +	vport->vport_info = rte_zmalloc(NULL, IDPF_DFLT_MBX_BUF_SIZE, 0);

Can we embed vport_info structure into the vport structure?
Seems its not necessary to malloc/free the vport_info which always associated with a vport structure?



  reply	other threads:[~2023-01-08 12:10 UTC|newest]

Thread overview: 35+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-12-08  7:52 [PATCH 00/15] net/idpf: refactor idpf pmd beilei.xing
2022-12-08  7:52 ` [PATCH 01/15] common/idpf: add adapter structure beilei.xing
2022-12-08  7:52 ` [PATCH 02/15] common/idpf: add vport structure beilei.xing
2022-12-08  7:52 ` [PATCH 03/15] common/idpf: move vc functions to common module beilei.xing
2022-12-08  7:52 ` [PATCH 04/15] common/idpf: introduce adapter init and deinit beilei.xing
2022-12-08  7:52 ` [PATCH 05/15] common/idpf: add vport init/deinit beilei.xing
2022-12-08  7:53 ` [PATCH 06/15] common/idpf: add config RSS beilei.xing
2022-12-08  7:53 ` [PATCH 07/15] common/idpf: add irq map/unmap beilei.xing
2022-12-08  7:53 ` [PATCH 08/15] common/idpf: move ptype table to adapter structure beilei.xing
2022-12-08  7:53 ` [PATCH 09/15] common/idpf: init create vport info beilei.xing
2022-12-08  7:53 ` [PATCH 10/15] common/idpf: add vector flags in vport beilei.xing
2022-12-08  7:53 ` [PATCH 11/15] common/idpf: add rxq and txq struct beilei.xing
2022-12-08  7:53 ` [PATCH 12/15] common/idpf: add help functions for queue setup and release beilei.xing
2022-12-08  7:53 ` [PATCH 13/15] common/idpf: add scalar data path beilei.xing
2022-12-08  7:53 ` [PATCH 14/15] common/idpf: add vec queue setup beilei.xing
2022-12-08  7:53 ` [PATCH 15/15] common/idpf: add avx512 for single queue model beilei.xing
2023-01-06  9:16 ` [PATCH v2 00/15] net/idpf: introduce idpf common modle beilei.xing
2023-01-06  9:16   ` [PATCH v2 01/15] common/idpf: add adapter structure beilei.xing
2023-01-06  9:16   ` [PATCH v2 02/15] common/idpf: add vport structure beilei.xing
2023-01-06  9:16   ` [PATCH v2 03/15] common/idpf: move vc functions to common module beilei.xing
2023-01-06  9:16   ` [PATCH v2 04/15] common/idpf: introduce adapter init and deinit beilei.xing
2023-01-06  9:16   ` [PATCH v2 05/15] common/idpf: add vport init/deinit beilei.xing
2023-01-08 12:10     ` Zhang, Qi Z [this message]
2023-01-09  1:34       ` Xing, Beilei
2023-01-06  9:16   ` [PATCH v2 06/15] common/idpf: add config RSS beilei.xing
2023-01-06  9:16   ` [PATCH v2 07/15] common/idpf: add irq map/unmap beilei.xing
2023-01-17  1:14     ` Zhang, Qi Z
2023-01-06  9:16   ` [PATCH v2 08/15] common/idpf: move ptype table to adapter structure beilei.xing
2023-01-06  9:16   ` [PATCH v2 09/15] common/idpf: init create vport info beilei.xing
2023-01-06  9:16   ` [PATCH v2 10/15] common/idpf: add vector flags in vport beilei.xing
2023-01-06  9:16   ` [PATCH v2 11/15] common/idpf: add rxq and txq struct beilei.xing
2023-01-06  9:16   ` [PATCH v2 12/15] common/idpf: add help functions for queue setup and release beilei.xing
2023-01-06  9:16   ` [PATCH v2 13/15] common/idpf: add scalar data path beilei.xing
2023-01-06  9:16   ` [PATCH v2 14/15] common/idpf: add vec queue setup beilei.xing
2023-01-06  9:16   ` [PATCH v2 15/15] common/idpf: add avx512 for single queue model beilei.xing

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=DM4PR11MB5994B170EF4AA5B5CFE77D19D7F99@DM4PR11MB5994.namprd11.prod.outlook.com \
    --to=qi.z.zhang@intel.com \
    --cc=beilei.xing@intel.com \
    --cc=dev@dpdk.org \
    --cc=jingjing.wu@intel.com \
    --cc=wenjun1.wu@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).