From: "Zhang, Qi Z" <qi.z.zhang@intel.com>
To: "Yang, SteveX" <stevex.yang@intel.com>, "dev@dpdk.org" <dev@dpdk.org>
Cc: "Wu, Jingjing" <jingjing.wu@intel.com>,
"Xing, Beilei" <beilei.xing@intel.com>,
"Yang, SteveX" <stevex.yang@intel.com>
Subject: RE: [PATCH v2] net/iavf: fix taninted scalar
Date: Thu, 10 Nov 2022 10:01:31 +0000 [thread overview]
Message-ID: <DM4PR11MB5994D3B9B52464EA3D06BDF9D7019@DM4PR11MB5994.namprd11.prod.outlook.com> (raw)
In-Reply-To: <20221110083052.133399-1-stevex.yang@intel.com>
> -----Original Message-----
> From: Steve Yang <stevex.yang@intel.com>
> Sent: Thursday, November 10, 2022 4:31 PM
> To: dev@dpdk.org
> Cc: Wu, Jingjing <jingjing.wu@intel.com>; Xing, Beilei <beilei.xing@intel.com>;
> Yang, SteveX <stevex.yang@intel.com>
> Subject: [PATCH v2] net/iavf: fix taninted scalar
>
> tainted_data_downcast: Downcasting match_item->meta from void * to
> struct virtchnl_proto_hdrs implies that the data that this pointer points to is
> tainted.
>
> var_assign_var: Assigning: proto_hdrs = match_item->meta.
> Both are now tainted.
>
> var_assign_var: Assigning: rss_meta->proto_hdrs = *proto_hdrs. Both are
> now tainted.
>
> Passing tainted expression "rss_meta->proto_hdrs.count" to
> "iavf_refine_proto_hdrs", which uses it as a loop boundary.
>
> Removed temporary variable 'proto_hdrs', and copied whole memory of
> match_item meta with exact structure size to avoid data downcast.
>
> Coverity issue: 381131
>
> Fixes: 91f27b2e39ab ("net/iavf: refactor RSS")
>
> Signed-off-by: Steve Yang <stevex.yang@intel.com>
Acked-by: Qi Zhang <qi.z.zhang@intel.com>
Applied to dpdk-next-net-intel.
Thanks
Qi
prev parent reply other threads:[~2022-11-10 10:01 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-11-10 7:25 [PATCH v1] " Steve Yang
2022-11-10 8:30 ` [PATCH v2] " Steve Yang
2022-11-10 10:01 ` Zhang, Qi Z [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=DM4PR11MB5994D3B9B52464EA3D06BDF9D7019@DM4PR11MB5994.namprd11.prod.outlook.com \
--to=qi.z.zhang@intel.com \
--cc=beilei.xing@intel.com \
--cc=dev@dpdk.org \
--cc=jingjing.wu@intel.com \
--cc=stevex.yang@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).