From: "Zhang, Qi Z" <qi.z.zhang@intel.com>
To: "Ye, MingjinX" <mingjinx.ye@intel.com>, "dev@dpdk.org" <dev@dpdk.org>
Cc: "Yang, Qiming" <qiming.yang@intel.com>,
"Ye, MingjinX" <mingjinx.ye@intel.com>,
"Wu, Wenjun1" <wenjun1.wu@intel.com>,
"Zhang, Yuying" <yuying.zhang@intel.com>,
"Xing, Beilei" <beilei.xing@intel.com>,
"Su, Simei" <simei.su@intel.com>,
"Wu, Jingjing" <jingjing.wu@intel.com>
Subject: RE: [PATCH v7 2/2] net/iavf: add diagnostic support in TX path
Date: Wed, 3 Jan 2024 02:54:59 +0000 [thread overview]
Message-ID: <DM4PR11MB5994D787E9A503AD6E6A3C09D760A@DM4PR11MB5994.namprd11.prod.outlook.com> (raw)
In-Reply-To: <20240102105211.788819-3-mingjinx.ye@intel.com>
> -----Original Message-----
> From: Mingjin Ye <mingjinx.ye@intel.com>
> Sent: Tuesday, January 2, 2024 6:52 PM
> To: dev@dpdk.org
> Cc: Yang, Qiming <qiming.yang@intel.com>; Ye, MingjinX
> <mingjinx.ye@intel.com>; Wu, Wenjun1 <wenjun1.wu@intel.com>; Zhang,
> Yuying <yuying.zhang@intel.com>; Xing, Beilei <beilei.xing@intel.com>; Su,
> Simei <simei.su@intel.com>; Wu, Jingjing <jingjing.wu@intel.com>
> Subject: [PATCH v7 2/2] net/iavf: add diagnostic support in TX path
>
> The only way to enable diagnostics for TX paths is to modify the application
> source code. Making it difficult to diagnose faults.
>
> In this patch, the devarg option "mbuf_check" is introduced and the
> parameters are configured to enable the corresponding diagnostics.
>
> supported cases: mbuf, size, segment, offload.
> 1. mbuf: check for corrupted mbuf.
> 2. size: check min/max packet length according to hw spec.
> 3. segment: check number of mbuf segments not exceed hw limitation.
> 4. offload: check any unsupported offload flag.
>
> parameter format: mbuf_check=[mbuf,<case1>,<case2>]
> eg: dpdk-testpmd -a 0000:81:01.0,mbuf_check=[mbuf,size] -- -i
>
> Signed-off-by: Mingjin Ye <mingjinx.ye@intel.com>
> ---
> v2: Remove call chain.
> ---
> v3: Optimisation implementation.
> ---
> v4: Fix Windows os compilation error.
> ---
> v5: Split Patch.
> ---
> v6: remove strict.
> ---
> doc/guides/nics/intel_vf.rst | 4 ++
> drivers/net/iavf/iavf.h | 12 +++++
> drivers/net/iavf/iavf_ethdev.c | 72 +++++++++++++++++++++++++
> drivers/net/iavf/iavf_rxtx.c | 98 ++++++++++++++++++++++++++++++++++
> drivers/net/iavf/iavf_rxtx.h | 2 +
> 5 files changed, 188 insertions(+)
>
> diff --git a/doc/guides/nics/intel_vf.rst b/doc/guides/nics/intel_vf.rst index
> ad08198f0f..8e39bc831c 100644
> --- a/doc/guides/nics/intel_vf.rst
> +++ b/doc/guides/nics/intel_vf.rst
> @@ -111,6 +111,10 @@ For more detail on SR-IOV, please refer to the
> following documents:
> by setting the ``devargs`` parameter like ``-a 18:01.0,no-poll-on-link-
> down=1``
> when IAVF is backed by an Intel\ |reg| E810 device or an Intel\ |reg| 700
> Series Ethernet device.
>
> + Enable mbuf check for Tx diagnostics by setting the devargs parameter
> like
> + ``-a 18:01.0,mbuf_check=[mbuf,<case1>,<case2>]`` when IAVF is backed
> by an
> + Intel\ |reg| E810 device or an Intel\ |reg| 700 Series Ethernet device.
> +
Please list all the options with descriptions which you already have them in the commit log.
Its necessary for user to understand the detail about how to use the devarg from document.
next prev parent reply other threads:[~2024-01-03 2:55 UTC|newest]
Thread overview: 36+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-12-21 10:12 [PATCH] " Mingjin Ye
2023-12-21 12:00 ` Zhang, Qi Z
2023-12-22 10:44 ` [PATCH v2] " Mingjin Ye
2023-12-22 11:37 ` Zhang, Qi Z
2023-12-25 2:48 ` Ye, MingjinX
2023-12-26 10:07 ` [PATCH v3] " Mingjin Ye
2023-12-27 10:16 ` [PATCH v4 1/2] " Mingjin Ye
2023-12-27 11:30 ` Zhang, Qi Z
2023-12-28 10:26 ` [PATCH v5 0/2] net/iavf: add diagnostics and fix error Mingjin Ye
2023-12-28 10:26 ` [PATCH v5 1/2] net/iavf: fix Tx path error in multi-process Mingjin Ye
2023-12-28 10:50 ` Zhang, Qi Z
2023-12-29 10:11 ` [PATCH v6 0/2] net/iavf: fix Rx/Tx burst and add diagnostics Mingjin Ye
2023-12-29 10:11 ` [PATCH v6 1/2] net/iavf: fix Rx/Tx burst in multi-process Mingjin Ye
2023-12-31 6:41 ` Zhang, Qi Z
2024-01-02 10:52 ` [PATCH v7 0/2] net/iavf: fix Rx/Tx burst and add diagnostics Mingjin Ye
2024-01-02 10:52 ` [PATCH v7 1/2] net/iavf: fix Rx/Tx burst in multi-process Mingjin Ye
2024-01-03 2:22 ` Zhang, Qi Z
2024-01-02 10:52 ` [PATCH v7 2/2] net/iavf: add diagnostic support in TX path Mingjin Ye
2024-01-03 2:54 ` Zhang, Qi Z [this message]
2024-01-03 10:10 ` [PATCH v8 0/2] net/iavf: fix Rx/Tx burst and add diagnostics Mingjin Ye
2024-01-03 10:10 ` [PATCH v8 1/2] net/iavf: fix Rx/Tx burst in multi-process Mingjin Ye
2024-01-03 10:10 ` [PATCH v8 2/2] net/iavf: add diagnostic support in TX path Mingjin Ye
2024-01-04 10:18 ` [PATCH v9 0/2] net/iavf: fix Rx/Tx burst and add diagnostics Mingjin Ye
2024-01-04 10:18 ` [PATCH v9 1/2] net/iavf: fix Rx/Tx burst in multi-process Mingjin Ye
2024-01-04 10:18 ` [PATCH v9 2/2] net/iavf: add diagnostic support in TX path Mingjin Ye
2024-01-05 9:58 ` [PATCH v10] " Mingjin Ye
2024-01-09 10:09 ` [PATCH v11] " Mingjin Ye
2024-01-10 2:25 ` Mingjin Ye
2024-02-09 14:43 ` Burakov, Anatoly
2024-02-09 15:20 ` Burakov, Anatoly
2024-02-19 9:55 ` [PATCH v12] " Mingjin Ye
2024-02-29 18:38 ` Bruce Richardson
2024-03-04 12:34 ` Bruce Richardson
2024-01-05 0:44 ` [PATCH v8 2/2] " Zhang, Qi Z
2023-12-29 10:11 ` [PATCH v6 " Mingjin Ye
2023-12-28 10:26 ` [PATCH v5 " Mingjin Ye
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=DM4PR11MB5994D787E9A503AD6E6A3C09D760A@DM4PR11MB5994.namprd11.prod.outlook.com \
--to=qi.z.zhang@intel.com \
--cc=beilei.xing@intel.com \
--cc=dev@dpdk.org \
--cc=jingjing.wu@intel.com \
--cc=mingjinx.ye@intel.com \
--cc=qiming.yang@intel.com \
--cc=simei.su@intel.com \
--cc=wenjun1.wu@intel.com \
--cc=yuying.zhang@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).