From: "Sebastian, Selwin" <Selwin.Sebastian@amd.com>
To: David Marchand <david.marchand@redhat.com>
Cc: "dev@dpdk.org" <dev@dpdk.org>,
"Yigit, Ferruh" <Ferruh.Yigit@amd.com>,
"stable@dpdk.org" <stable@dpdk.org>
Subject: RE: [PATCH v2] net/axgbe: use CPUID to identify cpu
Date: Wed, 4 Oct 2023 09:49:29 +0000 [thread overview]
Message-ID: <DM4PR12MB50551F83C18CF130FDE0663C8DCBA@DM4PR12MB5055.namprd12.prod.outlook.com> (raw)
In-Reply-To: <CAJFAV8wBhNS479hQL-E8D_EwATNf3=2S0hSGq=y4obMBMsGnpg@mail.gmail.com>
[AMD Official Use Only - General]
Hi David,
Thank you, I will push the updated patch soon.
-----Original Message-----
From: David Marchand <david.marchand@redhat.com>
Sent: Wednesday, October 4, 2023 2:27 PM
To: Sebastian, Selwin <Selwin.Sebastian@amd.com>
Cc: dev@dpdk.org; Yigit, Ferruh <Ferruh.Yigit@amd.com>; stable@dpdk.org
Subject: Re: [PATCH v2] net/axgbe: use CPUID to identify cpu
Caution: This message originated from an External Source. Use proper caution when opening attachments, clicking links, or responding.
Hello Selwin,
On Tue, Oct 3, 2023 at 1:40 PM Selwin Sebastian <selwin.sebastian@amd.com> wrote:
>
> Using root complex to identify cpu will not work for vm passthrough.
> CPUID is used to get family and modelid to identify cpu
>
> Fixes: b0db927b5eba ("net/axgbe: use PCI root complex device to
> distinguish device")
> Cc: stable@dpdk.org
>
> Signed-off-by: Selwin Sebastian <selwin.sebastian@amd.com>
> ---
> drivers/net/axgbe/axgbe_ethdev.c | 106
> ++++++++++++++++++-------------
> 1 file changed, 63 insertions(+), 43 deletions(-)
>
> diff --git a/drivers/net/axgbe/axgbe_ethdev.c
> b/drivers/net/axgbe/axgbe_ethdev.c
> index 48714eebe6..4fdb0ae168 100644
> --- a/drivers/net/axgbe/axgbe_ethdev.c
> +++ b/drivers/net/axgbe/axgbe_ethdev.c
> @@ -12,6 +12,12 @@
>
> #include "eal_filesystem.h"
>
> +#ifdef RTE_ARCH_X86
> +#include <cpuid.h>
> +#else
> +#define __cpuid (n, a, b, c, d)
With a space in this macro definition, the precompiler will think that it must replace the __cpuid token as literally (n, a, b, c, d).
--
David Marchand
prev parent reply other threads:[~2023-10-04 9:49 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-10-03 11:39 Selwin Sebastian
2023-10-04 8:56 ` David Marchand
2023-10-04 9:49 ` Sebastian, Selwin [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=DM4PR12MB50551F83C18CF130FDE0663C8DCBA@DM4PR12MB5055.namprd12.prod.outlook.com \
--to=selwin.sebastian@amd.com \
--cc=Ferruh.Yigit@amd.com \
--cc=david.marchand@redhat.com \
--cc=dev@dpdk.org \
--cc=stable@dpdk.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).