From: Alex Vesker <valex@nvidia.com>
To: Slava Ovsiienko <viacheslavo@nvidia.com>,
"NBU-Contact-Thomas Monjalon (EXTERNAL)" <thomas@monjalon.net>,
Suanming Mou <suanmingm@nvidia.com>,
Matan Azrad <matan@nvidia.com>
Cc: "dev@dpdk.org" <dev@dpdk.org>, Ori Kam <orika@nvidia.com>
Subject: RE: [PATCH] net/mlx5/hws: fix possible negative return on sq create
Date: Thu, 3 Nov 2022 14:16:54 +0000 [thread overview]
Message-ID: <DM4PR12MB5150C4228446494C8217C63BCE389@DM4PR12MB5150.namprd12.prod.outlook.com> (raw)
In-Reply-To: <20221103125146.7291-1-valex@nvidia.com>
Also forgot to add to commit message:
Coverity issue: 381674
> -----Original Message-----
> From: Alex Vesker <valex@nvidia.com>
> Sent: Thursday, November 3, 2022 2:52 PM
> To: Alex Vesker <valex@nvidia.com>; Slava Ovsiienko
> <viacheslavo@nvidia.com>; NBU-Contact-Thomas Monjalon (EXTERNAL)
> <thomas@monjalon.net>; Suanming Mou <suanmingm@nvidia.com>;
> Matan Azrad <matan@nvidia.com>
> Cc: dev@dpdk.org; Ori Kam <orika@nvidia.com>
> Subject: [PATCH] net/mlx5/hws: fix possible negative return on sq create
>
> The sysconf call can return a negative value (-1) on failure this will lead to
> posix_memalign to fail. This is not a realistic case which was found by the
> static checkers.
>
> Fixes: 3eb7488 ("net/mlx5/hws: add send layer")
> Signed-off-by: Alex Vesker <valex@nvidia.com>
> Reviewed-by: Erez Shitrit <erezsh@nvidia.com>
> ---
> drivers/net/mlx5/hws/mlx5dr_send.c | 6 ++++--
> 1 file changed, 4 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/net/mlx5/hws/mlx5dr_send.c
> b/drivers/net/mlx5/hws/mlx5dr_send.c
> index 26904a9040..1e9953a38f 100644
> --- a/drivers/net/mlx5/hws/mlx5dr_send.c
> +++ b/drivers/net/mlx5/hws/mlx5dr_send.c
> @@ -524,6 +524,7 @@ static int mlx5dr_send_ring_open_sq(struct
> mlx5dr_context *ctx,
> size_t sq_log_buf_sz;
> size_t buf_aligned;
> size_t sq_buf_sz;
> + size_t page_size;
> size_t buf_sz;
> int err;
>
> @@ -532,8 +533,9 @@ static int mlx5dr_send_ring_open_sq(struct
> mlx5dr_context *ctx,
> sq_buf_sz = 1 << (sq_log_buf_sz +
> log2above(MLX5_SEND_WQE_BB));
> sq->reg_addr = queue->uar->reg_addr;
>
> - buf_aligned = align(sq_buf_sz, sysconf(_SC_PAGESIZE));
> - err = posix_memalign((void **)&sq->buf, sysconf(_SC_PAGESIZE),
> buf_aligned);
> + page_size = sysconf(_SC_PAGESIZE);
> + buf_aligned = align(sq_buf_sz, page_size);
> + err = posix_memalign((void **)&sq->buf, page_size, buf_aligned);
> if (err) {
> rte_errno = ENOMEM;
> return err;
> --
> 2.18.1
next prev parent reply other threads:[~2022-11-03 14:16 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-11-03 12:51 Alex Vesker
2022-11-03 14:16 ` Alex Vesker [this message]
2022-11-07 9:54 ` [PATCH 4/4] " Alex Vesker
2022-11-07 10:08 ` [PATCH] " Alex Vesker
2022-11-08 8:58 ` Raslan Darawsheh
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=DM4PR12MB5150C4228446494C8217C63BCE389@DM4PR12MB5150.namprd12.prod.outlook.com \
--to=valex@nvidia.com \
--cc=dev@dpdk.org \
--cc=matan@nvidia.com \
--cc=orika@nvidia.com \
--cc=suanmingm@nvidia.com \
--cc=thomas@monjalon.net \
--cc=viacheslavo@nvidia.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).